can: usb: ucan: modify unregister_netdev to unregister_candev

[PATCH] can: usb: ucan: modify unregister_netdev to unregister_candev

Posted by Dongliang Mu 3 years, 5 months ago

From API pairing, modify unregister_netdev to unregister_candev since
the registeration function is register_candev. Actually, they are the
same.

Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
---
 drivers/net/can/usb/ucan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/usb/ucan.c b/drivers/net/can/usb/ucan.c
index 7c35f50fda4e..60f730094e5d 100644
--- a/drivers/net/can/usb/ucan.c
+++ b/drivers/net/can/usb/ucan.c
@@ -1581,7 +1581,7 @@ static void ucan_disconnect(struct usb_interface *intf)
 	usb_set_intfdata(intf, NULL);
 
 	if (up) {
-		unregister_netdev(up->netdev);
+		unregister_candev(up->netdev);
 		free_candev(up->netdev);
 	}
 }
-- 
2.35.1

Re: [PATCH] can: usb: ucan: modify unregister_netdev to unregister_candev

Posted by Marc Kleine-Budde 3 years, 5 months ago

On 24.10.2022 19:00:30, Dongliang Mu wrote:
> From API pairing, modify unregister_netdev to unregister_candev since
> the registeration function is register_candev. Actually, they are the
            ^ typo
> same.
> 
> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>

Fixed while applying.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Re: [PATCH] can: usb: ucan: modify unregister_netdev to unregister_candev

Posted by Dongliang Mu 3 years, 5 months ago


> On Oct 24, 2022, at 21:54, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> 
> On 24.10.2022 19:00:30, Dongliang Mu wrote:
>> From API pairing, modify unregister_netdev to unregister_candev since
>> the registeration function is register_candev. Actually, they are the
>            ^ typo

:(

>> same.
>> 
>> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
> 
> Fixed while applying.

You mean it is already done in your own tree? If yes, that’s fine.

> 
> Thanks,
> Marc
> 
> -- 
> Pengutronix e.K.                 | Marc Kleine-Budde           |
> Embedded Linux                   | https://www.pengutronix.de  |
> Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Re: [PATCH] can: usb: ucan: modify unregister_netdev to unregister_candev

Posted by Marc Kleine-Budde 3 years, 5 months ago

On 25.10.2022 10:27:12, Dongliang Mu wrote:
> > Fixed while applying.
> 
> You mean it is already done in your own tree? If yes, that’s fine.

ACK

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |