[PATCH v3 1/3] dt-bindings: ingenic: Add support for the JZ4755 CGU

Siarhei Volkau posted 3 patches 3 years, 5 months ago
There is a newer version of this series
[PATCH v3 1/3] dt-bindings: ingenic: Add support for the JZ4755 CGU
Posted by Siarhei Volkau 3 years, 5 months ago
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Siarhei Volkau <lis8215@gmail.com>
---
 Documentation/devicetree/bindings/clock/ingenic,cgu.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/ingenic,cgu.yaml b/Documentation/devicetree/bindings/clock/ingenic,cgu.yaml
index aa1df03ef..df256ebcd 100644
--- a/Documentation/devicetree/bindings/clock/ingenic,cgu.yaml
+++ b/Documentation/devicetree/bindings/clock/ingenic,cgu.yaml
@@ -22,6 +22,7 @@ select:
         enum:
           - ingenic,jz4740-cgu
           - ingenic,jz4725b-cgu
+          - ingenic,jz4755-cgu
           - ingenic,jz4760-cgu
           - ingenic,jz4760b-cgu
           - ingenic,jz4770-cgu
@@ -51,6 +52,7 @@ properties:
       - enum:
           - ingenic,jz4740-cgu
           - ingenic,jz4725b-cgu
+          - ingenic,jz4755-cgu
           - ingenic,jz4760-cgu
           - ingenic,jz4760b-cgu
           - ingenic,jz4770-cgu
-- 
2.36.1
Re: [PATCH v3 1/3] dt-bindings: ingenic: Add support for the JZ4755 CGU
Posted by Krzysztof Kozlowski 3 years, 5 months ago
On 23/10/2022 08:39, Siarhei Volkau wrote:
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Unack. You still do not have commit msg.

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.

Thank you.

Best regards,
Krzysztof
Re: [PATCH v3 1/3] dt-bindings: ingenic: Add support for the JZ4755 CGU
Posted by Siarhei Volkau 3 years, 5 months ago
вс, 23 окт. 2022 г. в 15:42, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org>:
>  maybe you just forgot to apply it.

Exactly,  especially when returning back to that once a week.
Sorry for flooding.