From: Frank Wunderlich <frank-w@public-files.de>
Add SoC specific section for defining clock configuration.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v3:
- drop assigned-clocks/assigned-clock-parents
- fix clock description
---
.../devicetree/bindings/mmc/mtk-sd.yaml | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
index 31bb6dc329d2..17b346a60e4c 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
@@ -228,6 +228,29 @@ allOf:
- const: source_cg
- const: bus_clk
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - mediatek,mt7986-mmc
+ then:
+ properties:
+ clocks:
+ minItems: 3
+ items:
+ - description: source clock
+ - description: HCLK which used for host
+ - description: AXI bus clock gate
+ - description: AHB bus clock gate
+ clock-names:
+ minItems: 3
+ items:
+ - const: source
+ - const: hclk
+ - const: axi_cg
+ - const: ahb_cg
+
- if:
properties:
compatible:
--
2.34.1On 23/10/2022 05:12, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Add SoC specific section for defining clock configuration. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi
> Gesendet: Sonntag, 23. Oktober 2022 um 14:56 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
> An: "Frank Wunderlich" <linux@fw-web.de>, linux-mediatek@lists.infradead.org
> Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Chaotian Jing" <chaotian.jing@mediatek.com>, "Ulf Hansson" <ulf.hansson@linaro.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Matthias Brugger" <matthias.bgg@gmail.com>, "Wenbin Mei" <wenbin.mei@mediatek.com>, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
> Betreff: Re: [PATCH v3 3/7] dt-bindings: mmc: mtk-sd: add mt7986
>
> On 23/10/2022 05:12, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > Add SoC specific section for defining clock configuration.
> >
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Hi,
got another config from mtk which requires changing binding a bit
clocks = <&topckgen CLK_TOP_EMMC_416M_SEL>,
<&infracfg CLK_INFRA_MSDC_HCK_CK>,
<&infracfg CLK_INFRA_MSDC_CK>,
<&infracfg CLK_INFRA_MSDC_133M_CK>,
<&infracfg CLK_INFRA_MSDC_66M_CK>;
clock-names = "source", "hclk", "source_cg", "bus_clk",
"sys_cg";
in binding:
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
@@ -241,15 +241,17 @@ allOf:
items:
- description: source clock
- description: HCLK which used for host
- - description: AXI bus clock gate
- - description: AHB bus clock gate
+ - description: independent source clock gate
+ - description: bus clock used for internal register access (required for MSDC0/3).
+ - description: msdc subsys clock gate
clock-names:
minItems: 3
items:
- const: source
- const: hclk
- - const: axi_cg
- - const: ahb_cg
+ - const: "source_cg"
+ - const: "bus_clk"
+ - const: "sys_cg"
will send an updated v4...old version was working but i should use the new one.
@Krzysztof can i take your RB here or should i leave it as Patch was changed?
regards Frank
On 24/10/2022 10:55, Frank Wunderlich wrote: > Hi > >> Gesendet: Sonntag, 23. Oktober 2022 um 14:56 Uhr >> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> >> An: "Frank Wunderlich" <linux@fw-web.de>, linux-mediatek@lists.infradead.org >> Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Chaotian Jing" <chaotian.jing@mediatek.com>, "Ulf Hansson" <ulf.hansson@linaro.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Matthias Brugger" <matthias.bgg@gmail.com>, "Wenbin Mei" <wenbin.mei@mediatek.com>, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org >> Betreff: Re: [PATCH v3 3/7] dt-bindings: mmc: mtk-sd: add mt7986 >> >> On 23/10/2022 05:12, Frank Wunderlich wrote: >>> From: Frank Wunderlich <frank-w@public-files.de> >>> >>> Add SoC specific section for defining clock configuration. >>> >>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de> >> >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Hi, > > got another config from mtk which requires changing binding a bit > > clocks = <&topckgen CLK_TOP_EMMC_416M_SEL>, > <&infracfg CLK_INFRA_MSDC_HCK_CK>, > <&infracfg CLK_INFRA_MSDC_CK>, > <&infracfg CLK_INFRA_MSDC_133M_CK>, > <&infracfg CLK_INFRA_MSDC_66M_CK>; > clock-names = "source", "hclk", "source_cg", "bus_clk", > "sys_cg"; > in binding: > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > @@ -241,15 +241,17 @@ allOf: > items: > - description: source clock > - description: HCLK which used for host > - - description: AXI bus clock gate > - - description: AHB bus clock gate > + - description: independent source clock gate > + - description: bus clock used for internal register access (required for MSDC0/3). > + - description: msdc subsys clock gate > clock-names: > minItems: 3 > items: > - const: source > - const: hclk > - - const: axi_cg > - - const: ahb_cg > + - const: "source_cg" > + - const: "bus_clk" > + - const: "sys_cg" > > will send an updated v4...old version was working but i should use the new one. > > @Krzysztof can i take your RB here or should i leave it as Patch was changed? Please drop my tag, so I will re-review it. Thanks! Best regards, Krzysztof
© 2016 - 2024 Red Hat, Inc.