From: Arnd Bergmann <arnd@arndb.de>
This device was only used by the smdk6410 board file that is now
gone, so the driver can be removed as well.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/ata/Kconfig | 10 -
drivers/ata/Makefile | 1 -
drivers/ata/pata_samsung_cf.c | 662 -------------------
include/linux/platform_data/ata-samsung_cf.h | 31 -
4 files changed, 704 deletions(-)
delete mode 100644 drivers/ata/pata_samsung_cf.c
delete mode 100644 include/linux/platform_data/ata-samsung_cf.h
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 6b446cfc3455..3b8cb7a29efd 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1136,16 +1136,6 @@ config PATA_RZ1000
If unsure, say N.
-config PATA_SAMSUNG_CF
- tristate "Samsung SoC PATA support"
- depends on SAMSUNG_DEV_IDE || COMPILE_TEST
- select PATA_TIMINGS
- help
- This option enables basic support for Samsung's S3C/S5P board
- PATA controllers via the new ATA layer
-
- If unsure, say N.
-
config PATA_WINBOND_VLB
tristate "Winbond W83759A VLB PATA support (Experimental)"
depends on ISA
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 2cca9f500649..4ee5c0761d90 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -109,7 +109,6 @@ obj-$(CONFIG_PATA_PLATFORM) += pata_platform.o
obj-$(CONFIG_PATA_OF_PLATFORM) += pata_of_platform.o
obj-$(CONFIG_PATA_RB532) += pata_rb532_cf.o
obj-$(CONFIG_PATA_RZ1000) += pata_rz1000.o
-obj-$(CONFIG_PATA_SAMSUNG_CF) += pata_samsung_cf.o
obj-$(CONFIG_PATA_PXA) += pata_pxa.o
diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c
deleted file mode 100644
index aba1536ddd44..000000000000
diff --git a/include/linux/platform_data/ata-samsung_cf.h b/include/linux/platform_data/ata-samsung_cf.h
deleted file mode 100644
index fccf969dc4da..000000000000
--
2.29.2On 21/10/2022 16:27, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > This device was only used by the smdk6410 board file that is now > gone, so the driver can be removed as well. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/ata/Kconfig | 10 - > drivers/ata/Makefile | 1 - > drivers/ata/pata_samsung_cf.c | 662 ------------------- > include/linux/platform_data/ata-samsung_cf.h | 31 - > 4 files changed, 704 deletions(-) > delete mode 100644 drivers/ata/pata_samsung_cf.c > delete mode 100644 include/linux/platform_data/ata-samsung_cf.h > > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index 6b446cfc3455..3b8cb7a29efd 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -1136,16 +1136,6 @@ config PATA_RZ1000 > > If unsure, say N. > > -config PATA_SAMSUNG_CF > - tristate "Samsung SoC PATA support" > - depends on SAMSUNG_DEV_IDE || COMPILE_TEST > - select PATA_TIMINGS > - help > - This option enables basic support for Samsung's S3C/S5P board > - PATA controllers via the new ATA layer > - This driver is present and somehow usable on newer platform: S5PV210. It's not converted to DT, but someone might want to do it. OTOH, if no one added DT for all this time, I doubt anyone will. Postmarket/Lineage-folks target smartphones, so don't use it. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 10/22/22 05:27, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > This device was only used by the smdk6410 board file that is now > gone, so the driver can be removed as well. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Arnd, This patch does not apply to the for-6.2 branch of libata tree. I can fix that easily, but I am concerned about the fact that this deletes the header file include/linux/platform_data/ata-samsung_cf.h, which has some function declarations for gpio used under arch/arm/mach-s3c. So If I apply this before you queue the other patches for this driver in for-next, we may endup with build failures. No ? > --- > drivers/ata/Kconfig | 10 - > drivers/ata/Makefile | 1 - > drivers/ata/pata_samsung_cf.c | 662 ------------------- > include/linux/platform_data/ata-samsung_cf.h | 31 - > 4 files changed, 704 deletions(-) > delete mode 100644 drivers/ata/pata_samsung_cf.c > delete mode 100644 include/linux/platform_data/ata-samsung_cf.h > > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index 6b446cfc3455..3b8cb7a29efd 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -1136,16 +1136,6 @@ config PATA_RZ1000 > > If unsure, say N. > > -config PATA_SAMSUNG_CF > - tristate "Samsung SoC PATA support" > - depends on SAMSUNG_DEV_IDE || COMPILE_TEST > - select PATA_TIMINGS > - help > - This option enables basic support for Samsung's S3C/S5P board > - PATA controllers via the new ATA layer > - > - If unsure, say N. > - > config PATA_WINBOND_VLB > tristate "Winbond W83759A VLB PATA support (Experimental)" > depends on ISA > diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile > index 2cca9f500649..4ee5c0761d90 100644 > --- a/drivers/ata/Makefile > +++ b/drivers/ata/Makefile > @@ -109,7 +109,6 @@ obj-$(CONFIG_PATA_PLATFORM) += pata_platform.o > obj-$(CONFIG_PATA_OF_PLATFORM) += pata_of_platform.o > obj-$(CONFIG_PATA_RB532) += pata_rb532_cf.o > obj-$(CONFIG_PATA_RZ1000) += pata_rz1000.o > -obj-$(CONFIG_PATA_SAMSUNG_CF) += pata_samsung_cf.o > > obj-$(CONFIG_PATA_PXA) += pata_pxa.o > > diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c > deleted file mode 100644 > index aba1536ddd44..000000000000 > diff --git a/include/linux/platform_data/ata-samsung_cf.h b/include/linux/platform_data/ata-samsung_cf.h > deleted file mode 100644 > index fccf969dc4da..000000000000 -- Damien Le Moal Western Digital Research
On Mon, Oct 24, 2022, at 00:41, Damien Le Moal wrote:
> On 10/22/22 05:27, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> This device was only used by the smdk6410 board file that is now
>> gone, so the driver can be removed as well.
>
> This patch does not apply to the for-6.2 branch of libata tree. I can fix
> that easily, but I am concerned about the fact that this deletes the
> header file include/linux/platform_data/ata-samsung_cf.h, which has some
> function declarations for gpio used under arch/arm/mach-s3c. So If I apply
> this before you queue the other patches for this driver in for-next, we
> may endup with build failures. No ?
Right, that was a mistake on my end. I had tested the full 98-patch
series in sequence and assumed that the driver removal would be
fine to apply separately. I'll just merge this one through the
SoC tree then. I have double-checked the pbk3710 and palmld
drivers, and those should not have a problem like this one.
I still need to send the palmld driver, as the mach-pxa series
had some unrelated issues.
Arnd
On 10/24/22 07:41, Damien Le Moal wrote: > On 10/22/22 05:27, Arnd Bergmann wrote: >> From: Arnd Bergmann <arnd@arndb.de> >> >> This device was only used by the smdk6410 board file that is now >> gone, so the driver can be removed as well. >> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Arnd, > > This patch does not apply to the for-6.2 branch of libata tree. I can fix > that easily, but I am concerned about the fact that this deletes the > header file include/linux/platform_data/ata-samsung_cf.h, which has some > function declarations for gpio used under arch/arm/mach-s3c. So If I apply > this before you queue the other patches for this driver in for-next, we > may endup with build failures. No ? It may be simpler for you to take this patch ? If yes, then: Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> > >> --- >> drivers/ata/Kconfig | 10 - >> drivers/ata/Makefile | 1 - >> drivers/ata/pata_samsung_cf.c | 662 ------------------- >> include/linux/platform_data/ata-samsung_cf.h | 31 - >> 4 files changed, 704 deletions(-) >> delete mode 100644 drivers/ata/pata_samsung_cf.c >> delete mode 100644 include/linux/platform_data/ata-samsung_cf.h >> >> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig >> index 6b446cfc3455..3b8cb7a29efd 100644 >> --- a/drivers/ata/Kconfig >> +++ b/drivers/ata/Kconfig >> @@ -1136,16 +1136,6 @@ config PATA_RZ1000 >> >> If unsure, say N. >> >> -config PATA_SAMSUNG_CF >> - tristate "Samsung SoC PATA support" >> - depends on SAMSUNG_DEV_IDE || COMPILE_TEST >> - select PATA_TIMINGS >> - help >> - This option enables basic support for Samsung's S3C/S5P board >> - PATA controllers via the new ATA layer >> - >> - If unsure, say N. >> - >> config PATA_WINBOND_VLB >> tristate "Winbond W83759A VLB PATA support (Experimental)" >> depends on ISA >> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile >> index 2cca9f500649..4ee5c0761d90 100644 >> --- a/drivers/ata/Makefile >> +++ b/drivers/ata/Makefile >> @@ -109,7 +109,6 @@ obj-$(CONFIG_PATA_PLATFORM) += pata_platform.o >> obj-$(CONFIG_PATA_OF_PLATFORM) += pata_of_platform.o >> obj-$(CONFIG_PATA_RB532) += pata_rb532_cf.o >> obj-$(CONFIG_PATA_RZ1000) += pata_rz1000.o >> -obj-$(CONFIG_PATA_SAMSUNG_CF) += pata_samsung_cf.o >> >> obj-$(CONFIG_PATA_PXA) += pata_pxa.o >> >> diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c >> deleted file mode 100644 >> index aba1536ddd44..000000000000 >> diff --git a/include/linux/platform_data/ata-samsung_cf.h b/include/linux/platform_data/ata-samsung_cf.h >> deleted file mode 100644 >> index fccf969dc4da..000000000000 > -- Damien Le Moal Western Digital Research
Hello! On 10/21/22 11:27 PM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > This device was only used by the smdk6410 board file that is now > gone, so the driver can be removed as well. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> [...] MBR, Sergey
© 2016 - 2026 Red Hat, Inc.