ARM: s3c: clean out obsolete platforms

[PATCH 08/21] hwmon: remove s3c driver

Posted by Arnd Bergmann 3 years, 5 months ago

From: Arnd Bergmann <arnd@arndb.de>

The s3c adc driver was removed along with the s3c24xx platform, so the
hwmon driver is orphaned and can be removed.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/hwmon/Kconfig     |  17 --
 drivers/hwmon/Makefile    |   1 -
 drivers/hwmon/s3c-hwmon.c | 379 --------------------------------------
 3 files changed, 397 deletions(-)
 delete mode 100644 drivers/hwmon/s3c-hwmon.c

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 7ac3daaf59ce..c98a068b5be2 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1729,23 +1729,6 @@ config SENSORS_SHTC1
 	  This driver can also be built as a module. If so, the module
 	  will be called shtc1.
 
-config SENSORS_S3C
-	tristate "Samsung built-in ADC"
-	depends on S3C_ADC
-	help
-	  If you say yes here you get support for the on-board ADCs of
-	  the Samsung S3C24XX, S3C64XX and other series of SoC
-
-	  This driver can also be built as a module. If so, the module
-	  will be called s3c-hwmon.
-
-config SENSORS_S3C_RAW
-	bool "Include raw channel attributes in sysfs"
-	depends on SENSORS_S3C
-	help
-	  Say Y here if you want to include raw copies of all the ADC
-	  channels in sysfs.
-
 config SENSORS_SIS5595
 	tristate "Silicon Integrated Systems Corp. SiS5595"
 	depends on PCI
diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
index 11d076cad8a2..b5a401ce3285 100644
--- a/drivers/hwmon/Makefile
+++ b/drivers/hwmon/Makefile
@@ -173,7 +173,6 @@ obj-$(CONFIG_SENSORS_PCF8591)	+= pcf8591.o
 obj-$(CONFIG_SENSORS_POWR1220)  += powr1220.o
 obj-$(CONFIG_SENSORS_PWM_FAN)	+= pwm-fan.o
 obj-$(CONFIG_SENSORS_RASPBERRYPI_HWMON)	+= raspberrypi-hwmon.o
-obj-$(CONFIG_SENSORS_S3C)	+= s3c-hwmon.o
 obj-$(CONFIG_SENSORS_SBTSI)	+= sbtsi_temp.o
 obj-$(CONFIG_SENSORS_SBRMI)	+= sbrmi.o
 obj-$(CONFIG_SENSORS_SCH56XX_COMMON)+= sch56xx-common.o
diff --git a/drivers/hwmon/s3c-hwmon.c b/drivers/hwmon/s3c-hwmon.c
deleted file mode 100644
index 70ae665db477..000000000000
-- 
2.29.2

Re: [PATCH 08/21] hwmon: remove s3c driver

Posted by Krzysztof Kozlowski 3 years, 5 months ago

On 21/10/2022 16:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The s3c adc driver was removed along with the s3c24xx platform, so the
> hwmon driver is orphaned and can be removed.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 08/21] hwmon: remove s3c driver

Posted by Guenter Roeck 3 years, 5 months ago

On 10/21/22 13:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The s3c adc driver was removed along with the s3c24xx platform, so the
> hwmon driver is orphaned and can be removed.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Guenter Roeck <linux@roeck-us.net>

I assume you plan to push the series together. If not, please let me know.

Guenter

> ---
>   drivers/hwmon/Kconfig     |  17 --
>   drivers/hwmon/Makefile    |   1 -
>   drivers/hwmon/s3c-hwmon.c | 379 --------------------------------------
>   3 files changed, 397 deletions(-)
>   delete mode 100644 drivers/hwmon/s3c-hwmon.c
> 
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 7ac3daaf59ce..c98a068b5be2 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1729,23 +1729,6 @@ config SENSORS_SHTC1
>   	  This driver can also be built as a module. If so, the module
>   	  will be called shtc1.
>   
> -config SENSORS_S3C
> -	tristate "Samsung built-in ADC"
> -	depends on S3C_ADC
> -	help
> -	  If you say yes here you get support for the on-board ADCs of
> -	  the Samsung S3C24XX, S3C64XX and other series of SoC
> -
> -	  This driver can also be built as a module. If so, the module
> -	  will be called s3c-hwmon.
> -
> -config SENSORS_S3C_RAW
> -	bool "Include raw channel attributes in sysfs"
> -	depends on SENSORS_S3C
> -	help
> -	  Say Y here if you want to include raw copies of all the ADC
> -	  channels in sysfs.
> -
>   config SENSORS_SIS5595
>   	tristate "Silicon Integrated Systems Corp. SiS5595"
>   	depends on PCI
> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
> index 11d076cad8a2..b5a401ce3285 100644
> --- a/drivers/hwmon/Makefile
> +++ b/drivers/hwmon/Makefile
> @@ -173,7 +173,6 @@ obj-$(CONFIG_SENSORS_PCF8591)	+= pcf8591.o
>   obj-$(CONFIG_SENSORS_POWR1220)  += powr1220.o
>   obj-$(CONFIG_SENSORS_PWM_FAN)	+= pwm-fan.o
>   obj-$(CONFIG_SENSORS_RASPBERRYPI_HWMON)	+= raspberrypi-hwmon.o
> -obj-$(CONFIG_SENSORS_S3C)	+= s3c-hwmon.o
>   obj-$(CONFIG_SENSORS_SBTSI)	+= sbtsi_temp.o
>   obj-$(CONFIG_SENSORS_SBRMI)	+= sbrmi.o
>   obj-$(CONFIG_SENSORS_SCH56XX_COMMON)+= sch56xx-common.o
> diff --git a/drivers/hwmon/s3c-hwmon.c b/drivers/hwmon/s3c-hwmon.c
> deleted file mode 100644
> index 70ae665db477..000000000000

Re: [PATCH 08/21] hwmon: remove s3c driver

Posted by Arnd Bergmann 3 years, 5 months ago

On Sat, Oct 22, 2022, at 06:02, Guenter Roeck wrote:
> On 10/21/22 13:27, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> The s3c adc driver was removed along with the s3c24xx platform, so the
>> hwmon driver is orphaned and can be removed.
>> 
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Acked-by: Guenter Roeck <linux@roeck-us.net>
>
> I assume you plan to push the series together. If not, please let me know.

Yes. I plan to pick up all the patches from the series through the
soc tree that have not been NaK'd or applied to subsystem maintainer
trees.

     Arnd