kcsan: Fix trivial typo in Kconfig help comments

[PATCH] kcsan: Fix trivial typo in Kconfig help comments

Posted by Ryosuke Yasuoka 3 years, 5 months ago

Fix trivial typo in Kconfig help comments in KCSAN_SKIP_WATCH and
KCSAN_SKIP_WATCH_RANDOMIZE

Signed-off-by: Ryosuke Yasuoka <ryasuoka@redhat.com>
---
 lib/Kconfig.kcsan | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/Kconfig.kcsan b/lib/Kconfig.kcsan
index 47a693c45864..375575a5a0e3 100644
--- a/lib/Kconfig.kcsan
+++ b/lib/Kconfig.kcsan
@@ -125,7 +125,7 @@ config KCSAN_SKIP_WATCH
 	default 4000
 	help
 	  The number of per-CPU memory operations to skip, before another
-	  watchpoint is set up, i.e. one in KCSAN_WATCH_SKIP per-CPU
+	  watchpoint is set up, i.e. one in KCSAN_SKIP_WATCH per-CPU
 	  memory operations are used to set up a watchpoint. A smaller value
 	  results in more aggressive race detection, whereas a larger value
 	  improves system performance at the cost of missing some races.
@@ -135,8 +135,8 @@ config KCSAN_SKIP_WATCH_RANDOMIZE
 	default y
 	help
 	  If instruction skip count should be randomized, where the maximum is
-	  KCSAN_WATCH_SKIP. If false, the chosen value is always
-	  KCSAN_WATCH_SKIP.
+	  KCSAN_SKIP_WATCH. If false, the chosen value is always
+	  KCSAN_SKIP_WATCH.
 
 config KCSAN_INTERRUPT_WATCHER
 	bool "Interruptible watchers" if !KCSAN_STRICT
-- 
2.37.3

Re: [PATCH] kcsan: Fix trivial typo in Kconfig help comments

Posted by Marco Elver 3 years, 5 months ago

On Tue, 18 Oct 2022 at 03:23, Ryosuke Yasuoka <ryasuoka@redhat.com> wrote:
>
> Fix trivial typo in Kconfig help comments in KCSAN_SKIP_WATCH and
> KCSAN_SKIP_WATCH_RANDOMIZE
>
> Signed-off-by: Ryosuke Yasuoka <ryasuoka@redhat.com>

Reviewed-by: Marco Elver <elver@google.com>

Thanks.

> ---
>  lib/Kconfig.kcsan | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/Kconfig.kcsan b/lib/Kconfig.kcsan
> index 47a693c45864..375575a5a0e3 100644
> --- a/lib/Kconfig.kcsan
> +++ b/lib/Kconfig.kcsan
> @@ -125,7 +125,7 @@ config KCSAN_SKIP_WATCH
>         default 4000
>         help
>           The number of per-CPU memory operations to skip, before another
> -         watchpoint is set up, i.e. one in KCSAN_WATCH_SKIP per-CPU
> +         watchpoint is set up, i.e. one in KCSAN_SKIP_WATCH per-CPU
>           memory operations are used to set up a watchpoint. A smaller value
>           results in more aggressive race detection, whereas a larger value
>           improves system performance at the cost of missing some races.
> @@ -135,8 +135,8 @@ config KCSAN_SKIP_WATCH_RANDOMIZE
>         default y
>         help
>           If instruction skip count should be randomized, where the maximum is
> -         KCSAN_WATCH_SKIP. If false, the chosen value is always
> -         KCSAN_WATCH_SKIP.
> +         KCSAN_SKIP_WATCH. If false, the chosen value is always
> +         KCSAN_SKIP_WATCH.
>
>  config KCSAN_INTERRUPT_WATCHER
>         bool "Interruptible watchers" if !KCSAN_STRICT
> --
> 2.37.3
>

Re: [PATCH] kcsan: Fix trivial typo in Kconfig help comments

Posted by Paul E. McKenney 3 years, 5 months ago

On Tue, Oct 18, 2022 at 08:15:26AM -0700, Marco Elver wrote:
> On Tue, 18 Oct 2022 at 03:23, Ryosuke Yasuoka <ryasuoka@redhat.com> wrote:
> >
> > Fix trivial typo in Kconfig help comments in KCSAN_SKIP_WATCH and
> > KCSAN_SKIP_WATCH_RANDOMIZE
> >
> > Signed-off-by: Ryosuke Yasuoka <ryasuoka@redhat.com>
> 
> Reviewed-by: Marco Elver <elver@google.com>

Applied, thank you both!

							Thanx, Paul

> Thanks.
> 
> > ---
> >  lib/Kconfig.kcsan | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/Kconfig.kcsan b/lib/Kconfig.kcsan
> > index 47a693c45864..375575a5a0e3 100644
> > --- a/lib/Kconfig.kcsan
> > +++ b/lib/Kconfig.kcsan
> > @@ -125,7 +125,7 @@ config KCSAN_SKIP_WATCH
> >         default 4000
> >         help
> >           The number of per-CPU memory operations to skip, before another
> > -         watchpoint is set up, i.e. one in KCSAN_WATCH_SKIP per-CPU
> > +         watchpoint is set up, i.e. one in KCSAN_SKIP_WATCH per-CPU
> >           memory operations are used to set up a watchpoint. A smaller value
> >           results in more aggressive race detection, whereas a larger value
> >           improves system performance at the cost of missing some races.
> > @@ -135,8 +135,8 @@ config KCSAN_SKIP_WATCH_RANDOMIZE
> >         default y
> >         help
> >           If instruction skip count should be randomized, where the maximum is
> > -         KCSAN_WATCH_SKIP. If false, the chosen value is always
> > -         KCSAN_WATCH_SKIP.
> > +         KCSAN_SKIP_WATCH. If false, the chosen value is always
> > +         KCSAN_SKIP_WATCH.
> >
> >  config KCSAN_INTERRUPT_WATCHER
> >         bool "Interruptible watchers" if !KCSAN_STRICT
> > --
> > 2.37.3
> >