Staging: rtl8192e: fix a brace style issue

[PATCH] Staging: rtl8192e: fix a brace style issue

Posted by Rigel Di Scala 3 years, 5 months ago

Fixed a coding style issue affecting a conditional if statement.

Signed-off-by: Rigel Di Scala <zedr@zedr.com>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 19d13b3fc..e932ad1a9 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -180,11 +180,10 @@ static void rtllib_send_ADDBAReq(struct rtllib_device *ieee, u8 *dst,
 
 	skb = rtllib_ADDBA(ieee, dst, pBA, 0, ACT_ADDBAREQ);
 
-	if (skb) {
+	if (skb)
 		softmac_mgmt_xmit(skb, ieee);
-	} else {
+	else
 		netdev_dbg(ieee->dev, "Failed to generate ADDBAReq packet.\n");
-	}
 }
 
 static void rtllib_send_ADDBARsp(struct rtllib_device *ieee, u8 *dst,
-- 
2.37.3

Re: [PATCH] Staging: rtl8192e: fix a brace style issue

Posted by Philipp Hortmann 3 years, 5 months ago

On 10/12/22 23:16, Rigel Di Scala wrote:
> Fixed a coding style issue affecting a conditional if statement.
> 
> Signed-off-by: Rigel Di Scala <zedr@zedr.com>
> ---
>   drivers/staging/rtl8192e/rtl819x_BAProc.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 19d13b3fc..e932ad1a9 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -180,11 +180,10 @@ static void rtllib_send_ADDBAReq(struct rtllib_device *ieee, u8 *dst,
>   
>   	skb = rtllib_ADDBA(ieee, dst, pBA, 0, ACT_ADDBAREQ);
>   
> -	if (skb) {
> +	if (skb)
>   		softmac_mgmt_xmit(skb, ieee);
> -	} else {
> +	else
>   		netdev_dbg(ieee->dev, "Failed to generate ADDBAReq packet.\n");
> -	}
>   }
>   
>   static void rtllib_send_ADDBARsp(struct rtllib_device *ieee, u8 *dst,

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>