[PATCH v3 1/2] dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip

Dzmitry Sankouski posted 2 patches 3 years, 5 months ago
[PATCH v3 1/2] dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
Posted by Dzmitry Sankouski 3 years, 5 months ago
Add samsung,starqltechn board (Samsung Galaxy S9) binding.

Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes for v2,v3: none

 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index fb1d00bcc847..f728b527d4cf 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -661,6 +661,7 @@ properties:
               - oneplus,fajita
               - qcom,sdm845-mtp
               - shift,axolotl
+              - samsung,starqltechn
               - samsung,w737
               - sony,akari-row
               - sony,akatsuki-row
-- 
2.30.2
Re: [PATCH v3 1/2] dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
Posted by Krzysztof Kozlowski 3 years, 5 months ago
On 12/10/2022 14:54, Dzmitry Sankouski wrote:
> Add samsung,starqltechn board (Samsung Galaxy S9) binding.
> 
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Changes for v2,v3: none

Where is v2 and v3 of this?

Best regards,
Krzysztof
Re: [PATCH v3 1/2] dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
Posted by Dzmitry Sankouski 3 years, 5 months ago
чт, 13 окт. 2022 г. в 16:43, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org>:
>
> On 12/10/2022 14:54, Dzmitry Sankouski wrote:
> > Add samsung,starqltechn board (Samsung Galaxy S9) binding.
> >
> > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> > ---
> > Changes for v2,v3: none
>
> Where is v2 and v3 of this?
I've been told it's easier for maintainers to resend all patch series,
even if only 1 patch from the series requires change. So I decided to
keep versions equal in all patches, to clearly indicate those patches
are from the same series. Please, correct me if I'm wrong.
>
> Best regards,
> Krzysztof
>
Re: [PATCH v3 1/2] dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
Posted by Krzysztof Kozlowski 3 years, 5 months ago
On 14/10/2022 07:01, Dzmitry Sankouski wrote:
> чт, 13 окт. 2022 г. в 16:43, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org>:
>>
>> On 12/10/2022 14:54, Dzmitry Sankouski wrote:
>>> Add samsung,starqltechn board (Samsung Galaxy S9) binding.
>>>
>>> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
>>> ---
>>> Changes for v2,v3: none
>>
>> Where is v2 and v3 of this?
> I've been told it's easier for maintainers to resend all patch series,
> even if only 1 patch from the series requires change. So I decided to
> keep versions equal in all patches, to clearly indicate those patches
> are from the same series. Please, correct me if I'm wrong.

This is okay, but you wrote here there was a v1 and v2, and you changed
nothing against it. If there was v1 and v2, we would ack it, I think.

Or this changelog is for some other patch? Not for this one?

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
Posted by Dzmitry Sankouski 3 years, 5 months ago
пт, 14 окт. 2022 г. в 19:13, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org>:
>
> On 14/10/2022 07:01, Dzmitry Sankouski wrote:
> > чт, 13 окт. 2022 г. в 16:43, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org>:
> >>
> >> On 12/10/2022 14:54, Dzmitry Sankouski wrote:
> >>> Add samsung,starqltechn board (Samsung Galaxy S9) binding.
> >>>
> >>> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> >>> ---
> >>> Changes for v2,v3: none
> >>
> >> Where is v2 and v3 of this?
> > I've been told it's easier for maintainers to resend all patch series,
> > even if only 1 patch from the series requires change. So I decided to
> > keep versions equal in all patches, to clearly indicate those patches
> > are from the same series. Please, correct me if I'm wrong.
>
> This is okay, but you wrote here there was a v1 and v2, and you changed
> nothing against it. If there was v1 and v2, we would ack it, I think.
>
> Or this changelog is for some other patch? Not for this one?
There's no previous versions of this patch, since it was born in the
v3 patch series. The empty changelog for this patch indicates that
there's no point to look for previous versions. I think I'll do it
differently next time to avoid confusion - just a sentence that vN is
the start version for patch.
>
> Best regards,
> Krzysztof
>
Re: [PATCH v3 1/2] dt-bindings: arm: add samsung,starqltechn board based on sdm845 chip
Posted by Krzysztof Kozlowski 3 years, 5 months ago
On 17/10/2022 04:02, Dzmitry Sankouski wrote:
>>> I've been told it's easier for maintainers to resend all patch series,
>>> even if only 1 patch from the series requires change. So I decided to
>>> keep versions equal in all patches, to clearly indicate those patches
>>> are from the same series. Please, correct me if I'm wrong.
>>
>> This is okay, but you wrote here there was a v1 and v2, and you changed
>> nothing against it. If there was v1 and v2, we would ack it, I think.
>>
>> Or this changelog is for some other patch? Not for this one?
> There's no previous versions of this patch, since it was born in the
> v3 patch series. The empty changelog for this patch indicates that
> there's no point to look for previous versions. I think I'll do it
> differently next time to avoid confusion - just a sentence that vN is
> the start version for patch.

Yes, please. Something like:

Changes for v3: New patch.

Best regards,
Krzysztof