1. Patchew
  2. linux
  3. [PATCH 0/6] dt-bindings: usb: covert ci-hdrc-usb2/usbmisc-imx to yaml
  4. View patch

[PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml

Peng Fan (OSS) posted 6 patches 3 years, 5 months ago
There is a newer version of this series
[PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
Posted by Peng Fan (OSS) 3 years, 5 months ago 
From: Peng Fan <peng.fan@nxp.com>

Convert usbmisc-imx to yaml format.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
 .../devicetree/bindings/usb/usbmisc-imx.yaml  | 52 +++++++++++++++++++
 2 files changed, 52 insertions(+), 18 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
 create mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.yaml

diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
deleted file mode 100644
index b796836d2ce7..000000000000
--- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
+++ /dev/null
@@ -1,18 +0,0 @@
-* Freescale i.MX non-core registers
-
-Required properties:
-- #index-cells: Cells used to describe usb controller index. Should be <1>
-- compatible: Should be one of below:
-	"fsl,imx6q-usbmisc" for imx6q
-	"fsl,vf610-usbmisc" for Vybrid vf610
-	"fsl,imx6sx-usbmisc" for imx6sx
-	"fsl,imx7d-usbmisc" for imx7d
-	"fsl,imx7ulp-usbmisc" for imx7ulp
-- reg: Should contain registers location and length
-
-Examples:
-usbmisc@2184800 {
-	#index-cells = <1>;
-	compatible = "fsl,imx6q-usbmisc";
-	reg = <0x02184800 0x200>;
-};
diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
new file mode 100644
index 000000000000..c0741ce9b523
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/usbmisc-imx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale i.MX non-core registers
+
+maintainers:
+  - Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+properties:
+  compatible:
+    oneOf:
+      - enum:
+          - fsl,imx6q-usbmisc
+          - fsl,imx7ulp-usbmisc
+          - fsl,vf610-usbmisc
+      - items:
+          - enum:
+              - fsl,imx6ul-usbmisc
+              - fsl,imx6sx-usbmisc
+              - fsl,imx7d-usbmisc
+          - const: fsl,imx6q-usbmisc
+      - items:
+          - enum:
+              - fsl,imx7ulp-usbmisc
+          - const: fsl,imx7d-usbmisc
+
+  reg:
+    maxItems: 1
+
+  '#index-cells':
+    const: 1
+    description: Cells used to describe usb controller index. Should be <1>
+
+required:
+  - compatible
+  - reg
+  - '#index-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    usbmisc@2184800 {
+        #index-cells = <1>;
+        compatible = "fsl,imx6q-usbmisc";
+        reg = <0x02184800 0x200>;
+    };
+
+...
-- 
2.37.1
Re: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
Posted by Krzysztof Kozlowski 3 years, 5 months ago 
On 10/10/2022 06:18, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Convert usbmisc-imx to yaml format.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
>  .../devicetree/bindings/usb/usbmisc-imx.yaml  | 52 +++++++++++++++++++
>  2 files changed, 52 insertions(+), 18 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
>  create mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> deleted file mode 100644
> index b796836d2ce7..000000000000
> --- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -* Freescale i.MX non-core registers
> -
> -Required properties:
> -- #index-cells: Cells used to describe usb controller index. Should be <1>
> -- compatible: Should be one of below:
> -	"fsl,imx6q-usbmisc" for imx6q
> -	"fsl,vf610-usbmisc" for Vybrid vf610
> -	"fsl,imx6sx-usbmisc" for imx6sx
> -	"fsl,imx7d-usbmisc" for imx7d
> -	"fsl,imx7ulp-usbmisc" for imx7ulp
> -- reg: Should contain registers location and length
> -
> -Examples:
> -usbmisc@2184800 {
> -	#index-cells = <1>;
> -	compatible = "fsl,imx6q-usbmisc";
> -	reg = <0x02184800 0x200>;
> -};
> diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml

Filename: fsl,usbmisc.yaml

> new file mode 100644
> index 000000000000..c0741ce9b523
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/usbmisc-imx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX non-core registers

non-core registers? Does not look right.


Best regards,
Krzysztof
RE: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
Posted by Peng Fan 3 years, 5 months ago 
> Subject: Re: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
> 
> On 10/10/2022 06:18, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Convert usbmisc-imx to yaml format.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
> >  .../devicetree/bindings/usb/usbmisc-imx.yaml  | 52
> > +++++++++++++++++++
> >  2 files changed, 52 insertions(+), 18 deletions(-)  delete mode
> > 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> >  create mode 100644
> > Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > deleted file mode 100644
> > index b796836d2ce7..000000000000
> > --- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > +++ /dev/null
> > @@ -1,18 +0,0 @@
> > -* Freescale i.MX non-core registers
> > -
> > -Required properties:
> > -- #index-cells: Cells used to describe usb controller index. Should
> > be <1>
> > -- compatible: Should be one of below:
> > -	"fsl,imx6q-usbmisc" for imx6q
> > -	"fsl,vf610-usbmisc" for Vybrid vf610
> > -	"fsl,imx6sx-usbmisc" for imx6sx
> > -	"fsl,imx7d-usbmisc" for imx7d
> > -	"fsl,imx7ulp-usbmisc" for imx7ulp
> > -- reg: Should contain registers location and length
> > -
> > -Examples:
> > -usbmisc@2184800 {
> > -	#index-cells = <1>;
> > -	compatible = "fsl,imx6q-usbmisc";
> > -	reg = <0x02184800 0x200>;
> > -};
> > diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> 
> Filename: fsl,usbmisc.yaml
> 
> > new file mode 100644
> > index 000000000000..c0741ce9b523
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> >
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> > +cetree.org%2Fschemas%2Fusb%2Fusbmisc-
> imx.yaml%23&amp;data=05%7C01%7Cp
> >
> +eng.fan%40nxp.com%7C8e789b7d73a645df2a5e08daac55e59c%7C686ea1
> d3bc2b4c
> >
> +6fa92cd99c5c301635%7C0%7C0%7C638011782161619006%7CUnknown%7
> CTWFpbGZsb
> >
> +3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M
> n0%3D
> >
> +%7C3000%7C%7C%7C&amp;sdata=zokmV96uHbH8kf6c%2BRhktNfjGOBsd
> %2BhhtrloJV
> > +vGuUI%3D&amp;reserved=0
> > +$schema:
> >
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> > +cetree.org%2Fmeta-
> schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cpeng.fan%
> >
> +40nxp.com%7C8e789b7d73a645df2a5e08daac55e59c%7C686ea1d3bc2b4c
> 6fa92cd9
> >
> +9c5c301635%7C0%7C0%7C638011782161775149%7CUnknown%7CTWFpb
> GZsb3d8eyJWI
> >
> +joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> C3000%
> >
> +7C%7C%7C&amp;sdata=DFe%2BH5iWFF9yEKRiXzWnhqqXHK4zExiK%2F%2F
> gB1Ux8csg%
> > +3D&amp;reserved=0
> > +
> > +title: Freescale i.MX non-core registers
> 
> non-core registers? Does not look right.

The txt binding has title: Freescale i.MX non-core registers,
so I just reuse it.

Thanks,
Peng.
> 
> 
> Best regards,
> Krzysztof
Re: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
Posted by Greg KH 3 years, 5 months ago 
On Mon, Oct 10, 2022 at 06:18:14PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Convert usbmisc-imx to yaml format.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
>  .../devicetree/bindings/usb/usbmisc-imx.yaml  | 52 +++++++++++++++++++
>  2 files changed, 52 insertions(+), 18 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
>  create mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> deleted file mode 100644
> index b796836d2ce7..000000000000
> --- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -* Freescale i.MX non-core registers
> -
> -Required properties:
> -- #index-cells: Cells used to describe usb controller index. Should be <1>
> -- compatible: Should be one of below:
> -	"fsl,imx6q-usbmisc" for imx6q
> -	"fsl,vf610-usbmisc" for Vybrid vf610
> -	"fsl,imx6sx-usbmisc" for imx6sx
> -	"fsl,imx7d-usbmisc" for imx7d
> -	"fsl,imx7ulp-usbmisc" for imx7ulp
> -- reg: Should contain registers location and length
> -
> -Examples:
> -usbmisc@2184800 {
> -	#index-cells = <1>;
> -	compatible = "fsl,imx6q-usbmisc";
> -	reg = <0x02184800 0x200>;
> -};
> diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> new file mode 100644
> index 000000000000..c0741ce9b523
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/usbmisc-imx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX non-core registers
> +
> +maintainers:
> +  - Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Cool, is nxp going to pay me to maintain this?  If not, then don't be
assigning such a thing to someone else.  Why can you not maintain it?

Assigning a file to someone without even asking them is a bit odd,
please never do that.

thanks,

greg k-h
RE: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
Posted by Jun Li 3 years, 5 months ago 
+ Xu

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Tuesday, October 11, 2022 4:25 AM
> To: Peng Fan (OSS) <peng.fan@oss.nxp.com>
> Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>;
> linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Jun
> Li <jun.li@nxp.com>; Peng Fan <peng.fan@nxp.com>
> Subject: Re: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
> 
> On Mon, Oct 10, 2022 at 06:18:14PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Convert usbmisc-imx to yaml format.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
> >  .../devicetree/bindings/usb/usbmisc-imx.yaml  | 52
> > +++++++++++++++++++
> >  2 files changed, 52 insertions(+), 18 deletions(-)  delete mode
> > 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> >  create mode 100644
> > Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > deleted file mode 100644
> > index b796836d2ce7..000000000000
> > --- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > +++ /dev/null
> > @@ -1,18 +0,0 @@
> > -* Freescale i.MX non-core registers
> > -
> > -Required properties:
> > -- #index-cells: Cells used to describe usb controller index. Should
> > be <1>
> > -- compatible: Should be one of below:
> > -	"fsl,imx6q-usbmisc" for imx6q
> > -	"fsl,vf610-usbmisc" for Vybrid vf610
> > -	"fsl,imx6sx-usbmisc" for imx6sx
> > -	"fsl,imx7d-usbmisc" for imx7d
> > -	"fsl,imx7ulp-usbmisc" for imx7ulp
> > -- reg: Should contain registers location and length
> > -
> > -Examples:
> > -usbmisc@2184800 {
> > -	#index-cells = <1>;
> > -	compatible = "fsl,imx6q-usbmisc";
> > -	reg = <0x02184800 0x200>;
> > -};
> > diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > new file mode 100644
> > index 000000000000..c0741ce9b523
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> >
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fschemas%2Fusb%2Fusbmisc-imx.yaml%23&amp;data=05%7C01%7Cj
> >
> +un.li%40nxp.com%7Ca362b29633474826da9408daaafd7315%7C686ea1d3bc2b4c6f
> >
> +a92cd99c5c301635%7C0%7C0%7C638010302778862012%7CUnknown%7CTWFpbGZsb3d
> >
> +8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> >
> +C3000%7C%7C%7C&amp;sdata=Kw6EHKfbwZ%2FfGgX6xJxML4W4E5DLiRx6pauQbLEbt0
> > +g%3D&amp;reserved=0
> > +$schema:
> >
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cjun.li%40
> >
> +nxp.com%7Ca362b29633474826da9408daaafd7315%7C686ea1d3bc2b4c6fa92cd99c
> >
> +5c301635%7C0%7C0%7C638010302778862012%7CUnknown%7CTWFpbGZsb3d8eyJWIjo
> >
> +iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> >
> +%7C%7C&amp;sdata=akKA3n0sxbOhvwDURs%2FoV7nM680QcOQCLKgxnakRe8w%3D&amp
> > +;reserved=0
> > +
> > +title: Freescale i.MX non-core registers
> > +
> > +maintainers:
> > +  - Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Cool, is nxp going to pay me to maintain this?  If not, then don't be assigning
> such a thing to someone else.  Why can you not maintain it?
> 
> Assigning a file to someone without even asking them is a bit odd, please
> never do that.

Hi Peng,

Thanks for this patchset.

Since xu.yang_2@nxp.com is now actively working on this IP for iMX, so he knows
well this h/w, I guess maybe he can maintain this, @Xu Yang, can you comments on
this?

Thanks
Li Jun

> 
> thanks,
> 
> greg k-h
RE: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
Posted by Xu Yang 3 years, 5 months ago 
Hi Peng,

> -----Original Message-----
> From: Jun Li <jun.li@nxp.com>
> Sent: Tuesday, October 11, 2022 9:51 AM
> To: Greg KH <gregkh@linuxfoundation.org>; Peng Fan (OSS) <peng.fan@oss.nxp.com>; Xu Yang <xu.yang_2@nxp.com>
> Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux-usb@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Peng Fan
> <peng.fan@nxp.com>
> Subject: RE: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
> 
> + Xu
> 
> > -----Original Message-----
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: Tuesday, October 11, 2022 4:25 AM
> > To: Peng Fan (OSS) <peng.fan@oss.nxp.com>
> > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>;
> > linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Jun
> > Li <jun.li@nxp.com>; Peng Fan <peng.fan@nxp.com>
> > Subject: Re: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
> >
> > On Mon, Oct 10, 2022 at 06:18:14PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > Convert usbmisc-imx to yaml format.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
> > >  .../devicetree/bindings/usb/usbmisc-imx.yaml  | 52
> > > +++++++++++++++++++
> > >  2 files changed, 52 insertions(+), 18 deletions(-)  delete mode
> > > 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > >  create mode 100644
> > > Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > > b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > > deleted file mode 100644
> > > index b796836d2ce7..000000000000
> > > --- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > > +++ /dev/null
> > > @@ -1,18 +0,0 @@
> > > -* Freescale i.MX non-core registers
> > > -
> > > -Required properties:
> > > -- #index-cells: Cells used to describe usb controller index. Should
> > > be <1>
> > > -- compatible: Should be one of below:
> > > -	"fsl,imx6q-usbmisc" for imx6q
> > > -	"fsl,vf610-usbmisc" for Vybrid vf610
> > > -	"fsl,imx6sx-usbmisc" for imx6sx
> > > -	"fsl,imx7d-usbmisc" for imx7d
> > > -	"fsl,imx7ulp-usbmisc" for imx7ulp
> > > -- reg: Should contain registers location and length
> > > -
> > > -Examples:
> > > -usbmisc@2184800 {
> > > -	#index-cells = <1>;
> > > -	compatible = "fsl,imx6q-usbmisc";
> > > -	reg = <0x02184800 0x200>;
> > > -};
> > > diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > > b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > > new file mode 100644
> > > index 000000000000..c0741ce9b523
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > > @@ -0,0 +1,52 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > > +---
> > > +$id:
> > >
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> > >
> > +cetree.org%2Fschemas%2Fusb%2Fusbmisc-imx.yaml%23&amp;data=05%7C01%7Cj
> > >
> > +un.li%40nxp.com%7Ca362b29633474826da9408daaafd7315%7C686ea1d3bc2b4c6f
> > >
> > +a92cd99c5c301635%7C0%7C0%7C638010302778862012%7CUnknown%7CTWFpbGZsb3d
> > >
> > +8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> > >
> > +C3000%7C%7C%7C&amp;sdata=Kw6EHKfbwZ%2FfGgX6xJxML4W4E5DLiRx6pauQbLEbt0
> > > +g%3D&amp;reserved=0
> > > +$schema:
> > >
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> > >
> > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cjun.li%40
> > >
> > +nxp.com%7Ca362b29633474826da9408daaafd7315%7C686ea1d3bc2b4c6fa92cd99c
> > >
> > +5c301635%7C0%7C0%7C638010302778862012%7CUnknown%7CTWFpbGZsb3d8eyJWIjo
> > >
> > +iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> > >
> > +%7C%7C&amp;sdata=akKA3n0sxbOhvwDURs%2FoV7nM680QcOQCLKgxnakRe8w%3D&amp
> > > +;reserved=0
> > > +
> > > +title: Freescale i.MX non-core registers
> > > +
> > > +maintainers:
> > > +  - Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > Cool, is nxp going to pay me to maintain this?  If not, then don't be assigning
> > such a thing to someone else.  Why can you not maintain it?
> >
> > Assigning a file to someone without even asking them is a bit odd, please
> > never do that.
> 
> Hi Peng,
> 
> Thanks for this patchset.
> 
> Since xu.yang_2@nxp.com is now actively working on this IP for iMX, so he knows
> well this h/w, I guess maybe he can maintain this, @Xu Yang, can you comments on
> this?

You can assign me as maintainer temporarily.
By the way, it seems that the following compatible strings should be added too.

fsl,imx25-usbmisc
fsl,imx27-usbmisc
fsl,imx35-usbmisc
fsl,imx51-usbmisc
fsl,imx53-usbmisc

Thanks,
Xu Yang

> 
> Thanks
> Li Jun
> 
> >
> > thanks,
> >
> > greg k-h
RE: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
Posted by Peng Fan 3 years, 5 months ago 
> Subject: RE: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
> 
> Hi Peng,
> 
> > -----Original Message-----
> > From: Jun Li <jun.li@nxp.com>
> > Sent: Tuesday, October 11, 2022 9:51 AM
> > To: Greg KH <gregkh@linuxfoundation.org>; Peng Fan (OSS)
> > <peng.fan@oss.nxp.com>; Xu Yang <xu.yang_2@nxp.com>
> > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>;
> > linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > Peng Fan <peng.fan@nxp.com>
> > Subject: RE: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to
> > yaml
> >
> > + Xu
> >
> > > -----Original Message-----
> > > From: Greg KH <gregkh@linuxfoundation.org>
> > > Sent: Tuesday, October 11, 2022 4:25 AM
> > > To: Peng Fan (OSS) <peng.fan@oss.nxp.com>
> > > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> > > shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de;
> > > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>;
> > > linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > > Jun Li <jun.li@nxp.com>; Peng Fan <peng.fan@nxp.com>
> > > Subject: Re: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to
> > > yaml
> > >
> > > On Mon, Oct 10, 2022 at 06:18:14PM +0800, Peng Fan (OSS) wrote:
> > > > From: Peng Fan <peng.fan@nxp.com>
> > > >
> > > > Convert usbmisc-imx to yaml format.
> > > >
> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > ---
> > > >  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
> > > >  .../devicetree/bindings/usb/usbmisc-imx.yaml  | 52
> > > > +++++++++++++++++++
> > > >  2 files changed, 52 insertions(+), 18 deletions(-)  delete mode
> > > > 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > > >  create mode 100644
> > > > Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > > > b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > > > deleted file mode 100644
> > > > index b796836d2ce7..000000000000
> > > > --- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > > > +++ /dev/null
> > > > @@ -1,18 +0,0 @@
> > > > -* Freescale i.MX non-core registers
> > > > -
> > > > -Required properties:
> > > > -- #index-cells: Cells used to describe usb controller index.
> > > > Should be <1>
> > > > -- compatible: Should be one of below:
> > > > -	"fsl,imx6q-usbmisc" for imx6q
> > > > -	"fsl,vf610-usbmisc" for Vybrid vf610
> > > > -	"fsl,imx6sx-usbmisc" for imx6sx
> > > > -	"fsl,imx7d-usbmisc" for imx7d
> > > > -	"fsl,imx7ulp-usbmisc" for imx7ulp
> > > > -- reg: Should contain registers location and length
> > > > -
> > > > -Examples:
> > > > -usbmisc@2184800 {
> > > > -	#index-cells = <1>;
> > > > -	compatible = "fsl,imx6q-usbmisc";
> > > > -	reg = <0x02184800 0x200>;
> > > > -};
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > > > b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > > > new file mode 100644
> > > > index 000000000000..c0741ce9b523
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > > > @@ -0,0 +1,52 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML
> > > > +1.2
> > > > +---
> > > > +$id:
> > > >
> > >
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde
> > > +vi
> > > >
> > > +cetree.org%2Fschemas%2Fusb%2Fusbmisc-
> imx.yaml%23&amp;data=05%7C01%7
> > > +Cj
> > > >
> > >
> +un.li%40nxp.com%7Ca362b29633474826da9408daaafd7315%7C686ea1d3
> bc2b4c
> > > +6f
> > > >
> > >
> +a92cd99c5c301635%7C0%7C0%7C638010302778862012%7CUnknown%7CT
> WFpbGZsb
> > > +3d
> > > >
> > >
> +8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0
> %3D
> > > +%7
> > > >
> > >
> +C3000%7C%7C%7C&amp;sdata=Kw6EHKfbwZ%2FfGgX6xJxML4W4E5DLiRx6
> pauQbLEb
> > > +t0
> > > > +g%3D&amp;reserved=0
> > > > +$schema:
> > > >
> > >
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde
> > > +vi
> > > >
> > > +cetree.org%2Fmeta-
> schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cjun.li%
> > > +40
> > > >
> > >
> +nxp.com%7Ca362b29633474826da9408daaafd7315%7C686ea1d3bc2b4c6f
> a92cd9
> > > +9c
> > > >
> > >
> +5c301635%7C0%7C0%7C638010302778862012%7CUnknown%7CTWFpbGZ
> sb3d8eyJWI
> > > +jo
> > > >
> > >
> +iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> 3000%
> > > +7C
> > > >
> > >
> +%7C%7C&amp;sdata=akKA3n0sxbOhvwDURs%2FoV7nM680QcOQCLKgxna
> kRe8w%3D&a
> > > +mp
> > > > +;reserved=0
> > > > +
> > > > +title: Freescale i.MX non-core registers
> > > > +
> > > > +maintainers:
> > > > +  - Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >
> > > Cool, is nxp going to pay me to maintain this?  If not, then don't
> > > be assigning such a thing to someone else.  Why can you not maintain it?
> > >
> > > Assigning a file to someone without even asking them is a bit odd,
> > > please never do that.
> >
> > Hi Peng,
> >
> > Thanks for this patchset.
> >
> > Since xu.yang_2@nxp.com is now actively working on this IP for iMX, so
> > he knows well this h/w, I guess maybe he can maintain this, @Xu Yang,
> > can you comments on this?
> 
> You can assign me as maintainer temporarily.

Sure, thanks.
> By the way, it seems that the following compatible strings should be added
> too.
> 
> fsl,imx25-usbmisc
> fsl,imx27-usbmisc
> fsl,imx35-usbmisc
> fsl,imx51-usbmisc
> fsl,imx53-usbmisc

Patch 6/6 has these. This patch is just convert to yaml format.

Thanks,
Peng.
> 
> Thanks,
> Xu Yang
> 
> >
> > Thanks
> > Li Jun
> >
> > >
> > > thanks,
> > >
> > > greg k-h
RE: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
Posted by Xu Yang 3 years, 5 months ago 
> -----Original Message-----
> From: Peng Fan <peng.fan@nxp.com>
> Sent: Wednesday, October 12, 2022 2:19 PM
> To: Xu Yang <xu.yang_2@nxp.com>; Jun Li <jun.li@nxp.com>; Greg KH <gregkh@linuxfoundation.org>; Peng Fan (OSS)
> <peng.fan@oss.nxp.com>
> Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux-usb@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: RE: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
> 
> > Subject: RE: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
> >
> > Hi Peng,
> >
> > > -----Original Message-----
> > > From: Jun Li <jun.li@nxp.com>
> > > Sent: Tuesday, October 11, 2022 9:51 AM
> > > To: Greg KH <gregkh@linuxfoundation.org>; Peng Fan (OSS)
> > > <peng.fan@oss.nxp.com>; Xu Yang <xu.yang_2@nxp.com>
> > > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> > > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> > > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>;
> > > linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > > Peng Fan <peng.fan@nxp.com>
> > > Subject: RE: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to
> > > yaml
> > >
> > > + Xu
> > >
> > > > -----Original Message-----
> > > > From: Greg KH <gregkh@linuxfoundation.org>
> > > > Sent: Tuesday, October 11, 2022 4:25 AM
> > > > To: Peng Fan (OSS) <peng.fan@oss.nxp.com>
> > > > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> > > > shawnguo@kernel.org; s.hauer@pengutronix.de;
> > kernel@pengutronix.de;
> > > > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>;
> > > > linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> > > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > > > Jun Li <jun.li@nxp.com>; Peng Fan <peng.fan@nxp.com>
> > > > Subject: Re: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to
> > > > yaml
> > > >
> > > > On Mon, Oct 10, 2022 at 06:18:14PM +0800, Peng Fan (OSS) wrote:
> > > > > From: Peng Fan <peng.fan@nxp.com>
> > > > >
> > > > > Convert usbmisc-imx to yaml format.
> > > > >
> > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > > ---
> > > > >  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
> > > > >  .../devicetree/bindings/usb/usbmisc-imx.yaml  | 52
> > > > > +++++++++++++++++++
> > > > >  2 files changed, 52 insertions(+), 18 deletions(-)  delete mode
> > > > > 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > > > >  create mode 100644
> > > > > Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > > > > b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > > > > deleted file mode 100644
> > > > > index b796836d2ce7..000000000000
> > > > > --- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> > > > > +++ /dev/null
> > > > > @@ -1,18 +0,0 @@
> > > > > -* Freescale i.MX non-core registers
> > > > > -
> > > > > -Required properties:
> > > > > -- #index-cells: Cells used to describe usb controller index.
> > > > > Should be <1>
> > > > > -- compatible: Should be one of below:
> > > > > -	"fsl,imx6q-usbmisc" for imx6q
> > > > > -	"fsl,vf610-usbmisc" for Vybrid vf610
> > > > > -	"fsl,imx6sx-usbmisc" for imx6sx
> > > > > -	"fsl,imx7d-usbmisc" for imx7d
> > > > > -	"fsl,imx7ulp-usbmisc" for imx7ulp
> > > > > -- reg: Should contain registers location and length
> > > > > -
> > > > > -Examples:
> > > > > -usbmisc@2184800 {
> > > > > -	#index-cells = <1>;
> > > > > -	compatible = "fsl,imx6q-usbmisc";
> > > > > -	reg = <0x02184800 0x200>;
> > > > > -};
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > > > > b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > > > > new file mode 100644
> > > > > index 000000000000..c0741ce9b523
> > > > > --- /dev/null
> > > > > +++ b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> > > > > @@ -0,0 +1,52 @@
> > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML
> > > > > +1.2
> > > > > +---
> > > > > +$id:
> > > > >
> > > >
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde
> > > > +vi
> > > > >
> > > > +cetree.org%2Fschemas%2Fusb%2Fusbmisc-
> > imx.yaml%23&amp;data=05%7C01%7
> > > > +Cj
> > > > >
> > > >
> > +un.li%40nxp.com%7Ca362b29633474826da9408daaafd7315%7C686ea1d3
> > bc2b4c
> > > > +6f
> > > > >
> > > >
> > +a92cd99c5c301635%7C0%7C0%7C638010302778862012%7CUnknown%7CT
> > WFpbGZsb
> > > > +3d
> > > > >
> > > >
> > +8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0
> > %3D
> > > > +%7
> > > > >
> > > >
> > +C3000%7C%7C%7C&amp;sdata=Kw6EHKfbwZ%2FfGgX6xJxML4W4E5DLiRx6
> > pauQbLEb
> > > > +t0
> > > > > +g%3D&amp;reserved=0
> > > > > +$schema:
> > > > >
> > > >
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde
> > > > +vi
> > > > >
> > > > +cetree.org%2Fmeta-
> > schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cjun.li%
> > > > +40
> > > > >
> > > >
> > +nxp.com%7Ca362b29633474826da9408daaafd7315%7C686ea1d3bc2b4c6f
> > a92cd9
> > > > +9c
> > > > >
> > > >
> > +5c301635%7C0%7C0%7C638010302778862012%7CUnknown%7CTWFpbGZ
> > sb3d8eyJWI
> > > > +jo
> > > > >
> > > >
> > +iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> > 3000%
> > > > +7C
> > > > >
> > > >
> > +%7C%7C&amp;sdata=akKA3n0sxbOhvwDURs%2FoV7nM680QcOQCLKgxna
> > kRe8w%3D&a
> > > > +mp
> > > > > +;reserved=0
> > > > > +
> > > > > +title: Freescale i.MX non-core registers
> > > > > +
> > > > > +maintainers:
> > > > > +  - Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > >
> > > > Cool, is nxp going to pay me to maintain this?  If not, then don't
> > > > be assigning such a thing to someone else.  Why can you not maintain it?
> > > >
> > > > Assigning a file to someone without even asking them is a bit odd,
> > > > please never do that.
> > >
> > > Hi Peng,
> > >
> > > Thanks for this patchset.
> > >
> > > Since xu.yang_2@nxp.com is now actively working on this IP for iMX, so
> > > he knows well this h/w, I guess maybe he can maintain this, @Xu Yang,
> > > can you comments on this?
> >
> > You can assign me as maintainer temporarily.
> 
> Sure, thanks.
> > By the way, it seems that the following compatible strings should be added
> > too.
> >
> > fsl,imx25-usbmisc
> > fsl,imx27-usbmisc
> > fsl,imx35-usbmisc
> > fsl,imx51-usbmisc
> > fsl,imx53-usbmisc
> 
> Patch 6/6 has these. This patch is just convert to yaml format.

Okay, got it. Then no problem.

Thanks,
Xu Yang

> 
> Thanks,
> Peng.
> >
> > Thanks,
> > Xu Yang
> >
> > >
> > > Thanks
> > > Li Jun
> > >
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
Re: [PATCH 4/6] dt-bindings: usb: usbmisc-imx: convert to yaml
Posted by Rob Herring 3 years, 5 months ago 
On Mon, Oct 10, 2022 at 06:18:14PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Convert usbmisc-imx to yaml format.

s/yaml/DT schema/

> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
>  .../devicetree/bindings/usb/usbmisc-imx.yaml  | 52 +++++++++++++++++++
>  2 files changed, 52 insertions(+), 18 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
>  create mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> deleted file mode 100644
> index b796836d2ce7..000000000000
> --- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -* Freescale i.MX non-core registers
> -
> -Required properties:
> -- #index-cells: Cells used to describe usb controller index. Should be <1>
> -- compatible: Should be one of below:
> -	"fsl,imx6q-usbmisc" for imx6q
> -	"fsl,vf610-usbmisc" for Vybrid vf610
> -	"fsl,imx6sx-usbmisc" for imx6sx
> -	"fsl,imx7d-usbmisc" for imx7d
> -	"fsl,imx7ulp-usbmisc" for imx7ulp
> -- reg: Should contain registers location and length
> -
> -Examples:
> -usbmisc@2184800 {
> -	#index-cells = <1>;
> -	compatible = "fsl,imx6q-usbmisc";
> -	reg = <0x02184800 0x200>;
> -};
> diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> new file mode 100644
> index 000000000000..c0741ce9b523
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/usbmisc-imx.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/usbmisc-imx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX non-core registers
> +
> +maintainers:
> +  - Greg Kroah-Hartman <gregkh@linuxfoundation.org>

No, should be someone that knows this h/w, not who applies patches.

> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - fsl,imx6q-usbmisc
> +          - fsl,imx7ulp-usbmisc
> +          - fsl,vf610-usbmisc
> +      - items:
> +          - enum:
> +              - fsl,imx6ul-usbmisc
> +              - fsl,imx6sx-usbmisc
> +              - fsl,imx7d-usbmisc
> +          - const: fsl,imx6q-usbmisc
> +      - items:
> +          - enum:
> +              - fsl,imx7ulp-usbmisc
> +          - const: fsl,imx7d-usbmisc
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#index-cells':

Humm, I doubt this got reviewed...

> +    const: 1
> +    description: Cells used to describe usb controller index. Should be <1>

Drop 'Should be <1>'. The constraints already say that.

> +
> +required:
> +  - compatible
> +  - reg
> +  - '#index-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    usbmisc@2184800 {
> +        #index-cells = <1>;
> +        compatible = "fsl,imx6q-usbmisc";
> +        reg = <0x02184800 0x200>;
> +    };
> +
> +...
> -- 
> 2.37.1
> 
>

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.