I am introducing these patches for the patch for ethernet driver which I
will send later.

In Patch 1, I abstract `match_string` to `__match_string` with a comparison
function, make the original name calling it with `strcmp` and add
`match_string_nocase` calling it with `strcasecmp`.

In Patch 2 & 3, I implement `{device,fwnode}_property_match_string_nocase`
and `fwnode_is_compatible` for compatible property matching.

Soha Jin (3):
  string: add match_string_nocase() for case-insensitive match
  device property: add {device,fwnode}_property_match_string_nocase()
  device property: add fwnode_is_compatible() for compatible match

 drivers/base/property.c  | 92 ++++++++++++++++++++++++++++++++--------
 include/linux/property.h | 13 ++++++
 include/linux/string.h   | 31 +++++++++++++-
 lib/string_helpers.c     | 10 +++--
 4 files changed, 123 insertions(+), 23 deletions(-)

-- 
2.30.2

On Mon, Oct 10, 2022 at 12:21:52AM +0800, Soha Jin wrote:
> I am introducing these patches for the patch for ethernet driver which I
> will send later.
> 
> In Patch 1, I abstract `match_string` to `__match_string` with a comparison
> function, make the original name calling it with `strcmp` and add
> `match_string_nocase` calling it with `strcasecmp`.
> 
> In Patch 2 & 3, I implement `{device,fwnode}_property_match_string_nocase`
> and `fwnode_is_compatible` for compatible property matching.

Let's ask Rob about usage of case-insensitive comparator for compatible
strings.

So, why do we have such in the OF code and do we really need it in the modern
world?

-- 
With Best Regards,
Andy Shevchenko

On Mon, Oct 10, 2022 at 12:21:52AM +0800, Soha Jin wrote:
> I am introducing these patches for the patch for ethernet driver which I
> will send later.

We can't take functions that have no real users.  Please send these
patches as part of your driver submission so we can see how they are
used and if they are even needed at all.

thanks,

greg k-h

Hi Greg,

> 
> On Mon, Oct 10, 2022 at 12:21:52AM +0800, Soha Jin wrote:
> > I am introducing these patches for the patch for ethernet driver which
> > I will send later.
> 
> We can't take functions that have no real users.  Please send these patches
> as part of your driver submission so we can see how they are used and if they
> are even needed at all.
> 

This is the first time I submit patches to kernel, I am sorry for anything
wrong I did.

I am just thinking these patches and the driver patches are in different
trees, so I split the patches into different parts. The driver patch is at
https://lore.kernel.org/all/20221009162247.1336-1-soha@lohu.info/.

Regards,
Soha

On Mon, Oct 10, 2022 at 11:07:13AM +0800, Soha Jin wrote:
> Hi Greg,
> 
> > 
> > On Mon, Oct 10, 2022 at 12:21:52AM +0800, Soha Jin wrote:
> > > I am introducing these patches for the patch for ethernet driver which
> > > I will send later.
> > 
> > We can't take functions that have no real users.  Please send these patches
> > as part of your driver submission so we can see how they are used and if they
> > are even needed at all.
> > 
> 
> This is the first time I submit patches to kernel, I am sorry for anything
> wrong I did.
> 
> I am just thinking these patches and the driver patches are in different
> trees, so I split the patches into different parts. The driver patch is at
> https://lore.kernel.org/all/20221009162247.1336-1-soha@lohu.info/.

As you can see, the kernel test robot reported that these changes are
broken as it does not know about this separate series you submitted.

Please make them all one series so we can properly review them together
and the testing infrastructure can correctly run.

thanks,

greg k-h

Hi Greg,

> From: 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>
> Sent: Monday, October 10, 2022 2:26 PM
> 
> On Mon, Oct 10, 2022 at 11:07:13AM +0800, Soha Jin wrote:
> > Hi Greg,
> >
> > This is the first time I submit patches to kernel, I am sorry for
> > anything wrong I did.
> >
> > I am just thinking these patches and the driver patches are in
> > different trees, so I split the patches into different parts. The
> > driver patch is at
> https://lore.kernel.org/all/20221009162247.1336-1-soha@lohu.info/.
> 
> As you can see, the kernel test robot reported that these changes are broken
> as it does not know about this separate series you submitted.
> 
> Please make them all one series so we can properly review them together
> and the testing infrastructure can correctly run.

I see. I will put this patch series into that thread as patch v2 after the
letter case problem is settled.

Regards,
Soha