[PATCH v2 0/3] ipmi: fix ipmi memleak and unload bug

Zhang Yuchen posted 3 patches 3 years, 5 months ago
drivers/char/ipmi/ipmi_kcs_sm.c     | 16 +++++++++++-----
drivers/char/ipmi/ipmi_msghandler.c |  5 ++++-
drivers/char/ipmi/ipmi_si_intf.c    | 27 +++++++++++++++++++--------
3 files changed, 34 insertions(+), 14 deletions(-)
[PATCH v2 0/3] ipmi: fix ipmi memleak and unload bug
Posted by Zhang Yuchen 3 years, 5 months ago
Our users have reported a memory leak. The IPMI driver consumes a lot of
memory.

We found this problem because IPMI was slow to release messages after
being disconnected, causing what appeared to be a memory leak.

Fix commit as:
  ipmi: fix msg stack when IPMI is disconnected

Two other issues were addressed in the process of solving this problem.

1. Unloading the driver takes a long time.

Fix commit as:
  ipmi: fix long wait in unload when IPMI disconnect

2. Memory leaks during driver unloading.

Fix commit as:
  ipmi: fix memleak when unload ipmi driver


v1: https://lore.kernel.org/lkml/20221007092617.87597-1-zhangyuchen.lcr@bytedance.com/

Changelog in v1 -> v2 (suggested by corey):
 - Change HOSED to the invalid state and not allowed to send.[TESTED]
 - Remove incorrect comment.

Zhang Yuchen (3):
  ipmi: fix msg stack when IPMI is disconnected
  ipmi: fix long wait in unload when IPMI disconnect
  ipmi: fix memleak when unload ipmi driver

 drivers/char/ipmi/ipmi_kcs_sm.c     | 16 +++++++++++-----
 drivers/char/ipmi/ipmi_msghandler.c |  5 ++++-
 drivers/char/ipmi/ipmi_si_intf.c    | 27 +++++++++++++++++++--------
 3 files changed, 34 insertions(+), 14 deletions(-)

-- 
2.30.2