drm/imx: Kconfig: Remove duplicated 'select DRM_KMS_HELPER' line

[PATCH] drm/imx: Kconfig: Remove duplicated 'select DRM_KMS_HELPER' line

Posted by Liu Ying 3 years, 5 months ago

A duplicated line 'select DRM_KMS_HELPER' was introduced in Kconfig file
by commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option"),
so remove it.

Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 drivers/gpu/drm/imx/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig
index 975de4ff7313..fd5b2471fdf0 100644
--- a/drivers/gpu/drm/imx/Kconfig
+++ b/drivers/gpu/drm/imx/Kconfig
@@ -4,7 +4,6 @@ config DRM_IMX
 	select DRM_KMS_HELPER
 	select VIDEOMODE_HELPERS
 	select DRM_GEM_DMA_HELPER
-	select DRM_KMS_HELPER
 	depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM || COMPILE_TEST)
 	depends on IMX_IPUV3_CORE
 	help
-- 
2.37.1

Re: [PATCH] drm/imx: Kconfig: Remove duplicated 'select DRM_KMS_HELPER' line

Posted by Philipp Zabel 3 years, 5 months ago

On So, 2022-10-09 at 10:35 +0800, Liu Ying wrote:
> A duplicated line 'select DRM_KMS_HELPER' was introduced in Kconfig file
> by commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option"),
> so remove it.
> 
> Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
>  drivers/gpu/drm/imx/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig
> index 975de4ff7313..fd5b2471fdf0 100644
> --- a/drivers/gpu/drm/imx/Kconfig
> +++ b/drivers/gpu/drm/imx/Kconfig
> @@ -4,7 +4,6 @@ config DRM_IMX
>  	select DRM_KMS_HELPER
>  	select VIDEOMODE_HELPERS
>  	select DRM_GEM_DMA_HELPER
> -	select DRM_KMS_HELPER
>  	depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM || COMPILE_TEST)
>  	depends on IMX_IPUV3_CORE
>  	help

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

and pushed to drm-misc-fixes.

regards
Philipp

Re: [PATCH] drm/imx: Kconfig: Remove duplicated 'select DRM_KMS_HELPER' line

Posted by Liu Ying 3 years, 5 months ago

Hi Philipp,

On Sun, 2022-10-09 at 10:35 +0800, Liu Ying wrote:
> A duplicated line 'select DRM_KMS_HELPER' was introduced in Kconfig
> file
> by commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER
> option"),
> so remove it.
> 
> Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
>  drivers/gpu/drm/imx/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

If no objections, can you please pick this small fix up through
imx-drm/fixes? Or through drm-misc-fixes?

Regards,
Liu Ying