[v2] arm64: dts: qcom: sm8250-edo: Add NXP PN553 NFC

[PATCH v2] arm64: dts: qcom: sm8250-edo: Add NXP PN553 NFC

Posted by Konrad Dybcio 3 years, 6 months ago

Add a node for NXP PN553 NFC, using the nxp-nci driver.

Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
Changes since v1:
- dropped useless label
- use generic node name

 arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
index f7d7f502f48b..ae94065c6daa 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
@@ -462,7 +462,16 @@ &i2c1 {
 	status = "okay";
 	clock-frequency = <400000>;
 
-	/* NXP PN553 NFC @ 28 */
+	nfc@28 {
+		compatible = "nxp,nxp-nci-i2c";
+		reg = <0x28>;
+
+		interrupt-parent = <&tlmm>;
+		interrupts = <111 IRQ_TYPE_EDGE_RISING>;
+
+		enable-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
+		firmware-gpios = <&tlmm 110 GPIO_ACTIVE_HIGH>;
+	};
 };
 
 &i2c2 {
-- 
2.37.3

Re: [PATCH v2] arm64: dts: qcom: sm8250-edo: Add NXP PN553 NFC

Posted by Bjorn Andersson 3 years, 5 months ago

On Sat, 8 Oct 2022 20:17:13 +0200, Konrad Dybcio wrote:
> Add a node for NXP PN553 NFC, using the nxp-nci driver.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sm8250-edo: Add NXP PN553 NFC
      commit: 37eac5a5fe27b1ab189d12064ffdd7db42f26900

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH v2] arm64: dts: qcom: sm8250-edo: Add NXP PN553 NFC

Posted by Marijn Suijten 3 years, 6 months ago

On 2022-10-08 20:17:13, Konrad Dybcio wrote:
> Add a node for NXP PN553 NFC, using the nxp-nci driver.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>

[On Sony Xperia 5 II, pdx206]
Tested-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>

> ---
> Changes since v1:
> - dropped useless label
> - use generic node name

Thanks!

> 
>  arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> index f7d7f502f48b..ae94065c6daa 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> @@ -462,7 +462,16 @@ &i2c1 {
>  	status = "okay";
>  	clock-frequency = <400000>;
>  
> -	/* NXP PN553 NFC @ 28 */
> +	nfc@28 {
> +		compatible = "nxp,nxp-nci-i2c";
> +		reg = <0x28>;
> +
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <111 IRQ_TYPE_EDGE_RISING>;
> +
> +		enable-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
> +		firmware-gpios = <&tlmm 110 GPIO_ACTIVE_HIGH>;
> +	};
>  };
>  
>  &i2c2 {
> -- 
> 2.37.3
>