tools/perf/builtin-mem.c | 8 ++++++++ 1 file changed, 8 insertions(+)
The -C/--cpu option was maily for report but it also affected record as
it ate the option. So users needed to use "--" after perf mem record to
pass the info to the perf record properly.
Check if this option is set for record, and pass it to the actual perf
record.
Before)
$ sudo perf --debug perf-event-open mem record -C 0 2>&1 | grep -a sys_perf_event_open
...
sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 4
sys_perf_event_open: pid -1 cpu 1 group_fd -1 flags 0x8 = 5
sys_perf_event_open: pid -1 cpu 2 group_fd -1 flags 0x8 = 6
sys_perf_event_open: pid -1 cpu 3 group_fd -1 flags 0x8 = 7
sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 8
sys_perf_event_open: pid -1 cpu 1 group_fd -1 flags 0x8 = 9
sys_perf_event_open: pid -1 cpu 2 group_fd -1 flags 0x8 = 10
sys_perf_event_open: pid -1 cpu 3 group_fd -1 flags 0x8 = 11
...
After)
$ sudo perf --debug perf-event-open mem record -C 0 2>&1 | grep -a sys_perf_event_open
...
sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 4
sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 5
sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 6
sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 7
Cc: Leo Yan <leo.yan@linaro.org>
Reported-by: Ravi Bangoria <ravi.bangoria@amd.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/builtin-mem.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c
index 9e435fd23503..02e7a5dbeb00 100644
--- a/tools/perf/builtin-mem.c
+++ b/tools/perf/builtin-mem.c
@@ -97,6 +97,9 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem)
else
rec_argc = argc + 9 * perf_pmu__hybrid_pmu_num();
+ if (mem->cpu_list)
+ rec_argc += 2;
+
rec_argv = calloc(rec_argc + 1, sizeof(char *));
if (!rec_argv)
return -1;
@@ -158,6 +161,11 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem)
if (all_kernel)
rec_argv[i++] = "--all-kernel";
+ if (mem->cpu_list) {
+ rec_argv[i++] = "-C";
+ rec_argv[i++] = mem->cpu_list;
+ }
+
for (j = 0; j < argc; j++, i++)
rec_argv[i] = argv[j];
--
2.38.0.rc1.362.ged0d419d3c-googOn Tue, Oct 04, 2022 at 01:02:11PM -0700, Namhyung Kim wrote: > The -C/--cpu option was maily for report but it also affected record as > it ate the option. So users needed to use "--" after perf mem record to > pass the info to the perf record properly. > > Check if this option is set for record, and pass it to the actual perf > record. > > Before) > $ sudo perf --debug perf-event-open mem record -C 0 2>&1 | grep -a sys_perf_event_open > ... > sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 4 > sys_perf_event_open: pid -1 cpu 1 group_fd -1 flags 0x8 = 5 > sys_perf_event_open: pid -1 cpu 2 group_fd -1 flags 0x8 = 6 > sys_perf_event_open: pid -1 cpu 3 group_fd -1 flags 0x8 = 7 > sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 8 > sys_perf_event_open: pid -1 cpu 1 group_fd -1 flags 0x8 = 9 > sys_perf_event_open: pid -1 cpu 2 group_fd -1 flags 0x8 = 10 > sys_perf_event_open: pid -1 cpu 3 group_fd -1 flags 0x8 = 11 > ... > > After) > $ sudo perf --debug perf-event-open mem record -C 0 2>&1 | grep -a sys_perf_event_open > ... > sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 4 > sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 5 > sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 6 > sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 7 > > Cc: Leo Yan <leo.yan@linaro.org> > Reported-by: Ravi Bangoria <ravi.bangoria@amd.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> The change LGTM: Reviewed-by: Leo Yan <leo.yan@linaro.org> Tested-by: Leo Yan <leo.yan@linaro.org>
Em Thu, Oct 06, 2022 at 02:01:54PM +0800, Leo Yan escreveu: > On Tue, Oct 04, 2022 at 01:02:11PM -0700, Namhyung Kim wrote: > > The -C/--cpu option was maily for report but it also affected record as > > it ate the option. So users needed to use "--" after perf mem record to > > pass the info to the perf record properly. > > > > Check if this option is set for record, and pass it to the actual perf > > record. > > > > Before) > > $ sudo perf --debug perf-event-open mem record -C 0 2>&1 | grep -a sys_perf_event_open > > ... > > sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 4 > > sys_perf_event_open: pid -1 cpu 1 group_fd -1 flags 0x8 = 5 > > sys_perf_event_open: pid -1 cpu 2 group_fd -1 flags 0x8 = 6 > > sys_perf_event_open: pid -1 cpu 3 group_fd -1 flags 0x8 = 7 > > sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 8 > > sys_perf_event_open: pid -1 cpu 1 group_fd -1 flags 0x8 = 9 > > sys_perf_event_open: pid -1 cpu 2 group_fd -1 flags 0x8 = 10 > > sys_perf_event_open: pid -1 cpu 3 group_fd -1 flags 0x8 = 11 > > ... > > > > After) > > $ sudo perf --debug perf-event-open mem record -C 0 2>&1 | grep -a sys_perf_event_open > > ... > > sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 4 > > sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 5 > > sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 6 > > sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 7 > > > > Cc: Leo Yan <leo.yan@linaro.org> > > Reported-by: Ravi Bangoria <ravi.bangoria@amd.com> > > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > > The change LGTM: > > Reviewed-by: Leo Yan <leo.yan@linaro.org> > Tested-by: Leo Yan <leo.yan@linaro.org> Thanks, applied. - Arnaldo
© 2016 - 2026 Red Hat, Inc.