[PATCH v3 0/5] device property: Consitify a few APIs and

Andy Shevchenko posted 5 patches 3 years, 6 months ago
drivers/base/property.c     | 29 ++++++++++++++++++-----------
drivers/usb/roles/class.c   |  2 +-
drivers/usb/typec/mux.c     |  8 ++++----
drivers/usb/typec/retimer.c |  2 +-
include/linux/property.h    | 34 +++++++++++++++++++---------------
5 files changed, 43 insertions(+), 32 deletions(-)
[PATCH v3 0/5] device property: Consitify a few APIs and
Posted by Andy Shevchenko 3 years, 6 months ago
The property.h has inconsistency in how we annotate the parameters which
are not modified anyhow by the certain APIs. Also dev_fwnode() needs to
be rectified in sense of the handling const qualifier.

This series improves the above with only a couple of APIs left for now
untouched (PHY, which I believe doesn't belong to property.h to begin
with).

Changelog v3:
- used _Generic() to hide the _const API (Sakari, Greg)

Changelog v2:
- fixed USB Type-C compilation issues (LKP)
- added tags (Sakari, Heikki)

Andy Shevchenko (5):
  device property: Allow const parameter to dev_fwnode()
  device property: Constify fwnode connection match APIs
  device property: Constify parameter in fwnode_graph_is_endpoint()
  device property: Constify device child node APIs
  device property: Constify parameter in device_dma_supported() and
    device_get_dma_attr()

 drivers/base/property.c     | 29 ++++++++++++++++++-----------
 drivers/usb/roles/class.c   |  2 +-
 drivers/usb/typec/mux.c     |  8 ++++----
 drivers/usb/typec/retimer.c |  2 +-
 include/linux/property.h    | 34 +++++++++++++++++++---------------
 5 files changed, 43 insertions(+), 32 deletions(-)

-- 
2.35.1
Re: [PATCH v3 0/5] device property: Consitify a few APIs and
Posted by Greg Kroah-Hartman 3 years, 6 months ago
On Tue, Oct 04, 2022 at 12:21:24PM +0300, Andy Shevchenko wrote:
> The property.h has inconsistency in how we annotate the parameters which
> are not modified anyhow by the certain APIs. Also dev_fwnode() needs to
> be rectified in sense of the handling const qualifier.
> 
> This series improves the above with only a couple of APIs left for now
> untouched (PHY, which I believe doesn't belong to property.h to begin
> with).

Looks sane at first glance.  I'll look at it some more once 6.1-rc1 is
out, thanks.

greg k-h
Re: [PATCH v3 0/5] device property: Consitify a few APIs and
Posted by Greg Kroah-Hartman 3 years, 5 months ago
On Tue, Oct 04, 2022 at 02:11:10PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Oct 04, 2022 at 12:21:24PM +0300, Andy Shevchenko wrote:
> > The property.h has inconsistency in how we annotate the parameters which
> > are not modified anyhow by the certain APIs. Also dev_fwnode() needs to
> > be rectified in sense of the handling const qualifier.
> > 
> > This series improves the above with only a couple of APIs left for now
> > untouched (PHY, which I believe doesn't belong to property.h to begin
> > with).
> 
> Looks sane at first glance.  I'll look at it some more once 6.1-rc1 is
> out, thanks.

All now applied, thanks.,

greg k-h