[PATCH v3 2/2] dt-bindings: arm: add xiaomi,sagit board based on msm8998 chip

Dzmitry Sankouski posted 2 patches 3 years, 6 months ago
There is a newer version of this series
[PATCH v3 2/2] dt-bindings: arm: add xiaomi,sagit board based on msm8998 chip
Posted by Dzmitry Sankouski 3 years, 6 months ago
add xiaomi,sagit board (Xiaomi Mi 6) binding

Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes for v3:
- remove unused 'sagit' compatible line

 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index fb1d00bcc847..294075bafb97 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -239,6 +239,7 @@ properties:
               - sony,xperia-lilac
               - sony,xperia-maple
               - sony,xperia-poplar
+              - xiaomi,sagit
           - const: qcom,msm8998
 
       - items:
-- 
2.30.2
Re: [PATCH v3 2/2] dt-bindings: arm: add xiaomi,sagit board based on msm8998 chip
Posted by Krzysztof Kozlowski 3 years, 6 months ago
On 03/10/2022 20:55, Dzmitry Sankouski wrote:
> add xiaomi,sagit board (Xiaomi Mi 6) binding

Start with capital letter and finish with full-stop.

> 
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Changes for v3:
> - remove unused 'sagit' compatible line

With commit fixes:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [PATCH v3 2/2] dt-bindings: arm: add xiaomi,sagit board based on msm8998 chip
Posted by Konrad Dybcio 3 years, 6 months ago
On 03/10/2022 20:55, Dzmitry Sankouski wrote:
> add xiaomi,sagit board (Xiaomi Mi 6) binding
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---

Binding changes should generally go before the actual patch, so that

there's no commit where there's an undocumented compatible.

Konrad

> Changes for v3:
> - remove unused 'sagit' compatible line
>
>   Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index fb1d00bcc847..294075bafb97 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -239,6 +239,7 @@ properties:
>                 - sony,xperia-lilac
>                 - sony,xperia-maple
>                 - sony,xperia-poplar
> +              - xiaomi,sagit
>             - const: qcom,msm8998
>   
>         - items: