[PATCH RESEND v4 1/2] get_maintainer: Print maintainer for S: Supported

Bryan O'Donoghue posted 2 patches 3 years, 6 months ago
There is a newer version of this series
[PATCH RESEND v4 1/2] get_maintainer: Print maintainer for S: Supported
Posted by Bryan O'Donoghue 3 years, 6 months ago
Throughout the documentation we make reference to maintainers as the people
who ought to be mailed when sending patches.

Right now get_maintainer.pl returns "supporter" for maintained files which
are denoted "S: Supported".

Update get_maintainer to output "maintainer" for "S: Supported" the
differentiation between paid (v) non-paid maintainers doesn't impact who
needs to be mailed for patch submissions.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 scripts/get_maintainer.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index ab123b498fd9b..7a8d2961d948d 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -1283,7 +1283,7 @@ sub get_maintainer_role {
 
     $role = lc($role);
     if      ($role eq "supported") {
-	$role = "supporter";
+	$role = "maintainer";
     } elsif ($role eq "maintained") {
 	$role = "maintainer";
     } elsif ($role eq "odd fixes") {
-- 
2.37.3
Re: [PATCH RESEND v4 1/2] get_maintainer: Print maintainer for S: Supported
Posted by Joe Perches 3 years, 6 months ago
On Mon, 2022-10-03 at 17:24 +0100, Bryan O'Donoghue wrote:
> Throughout the documentation we make reference to maintainers as the people
> who ought to be mailed when sending patches.
> 
> Right now get_maintainer.pl returns "supporter" for maintained files which
> are denoted "S: Supported".

As it should.

I think this patch is misguided and do not agree with the concept.

Either do away with the concept of S: Supported or use it.

As is, it merely hides the actual content of the MAINTAINERS file.

A reader of the MAINTAINERS file would still see the actual value.
Using other options of get_maintainer.pl like --sections would show
the actual content.

Other options would still show S:
> 
> Update get_maintainer to output "maintainer" for "S: Supported" the
> differentiation between paid (v) non-paid maintainers doesn't impact who
> needs to be mailed for patch submissions.
[]
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
[]
> @@ -1283,7 +1283,7 @@ sub get_maintainer_role {
>  
>      $role = lc($role);
>      if      ($role eq "supported") {
> -	$role = "supporter";
> +	$role = "maintainer";
>      } elsif ($role eq "maintained") {
>  	$role = "maintainer";
>      } elsif ($role eq "odd fixes") {
Re: [PATCH RESEND v4 1/2] get_maintainer: Print maintainer for S: Supported
Posted by Bryan O'Donoghue 3 years, 6 months ago
On 04/10/2022 09:02, Joe Perches wrote:
> As it should.
> 
> I think this patch is misguided and do not agree with the concept.
> 
> Either do away with the concept of S: Supported or use it.

Sure, I can simply resend as V5 minus this patch, since the 
documentation change calls out "supporter" - which is FWIW what the 
original proposed patch did, albeit with different wording.

---
bod