[PATCH 0/5] staging: r8188eu: some cleanups

Michael Straube posted 5 patches 3 years, 6 months ago
drivers/staging/r8188eu/core/rtw_cmd.c         | 16 +++++++---------
drivers/staging/r8188eu/core/rtw_mlme.c        | 12 ++++--------
drivers/staging/r8188eu/core/rtw_sta_mgt.c     |  6 +++---
drivers/staging/r8188eu/include/odm.h          |  3 ++-
drivers/staging/r8188eu/include/odm_RTL8188E.h |  7 +++++++
drivers/staging/r8188eu/include/odm_types.h    | 16 ----------------
drivers/staging/r8188eu/include/rtl8188e_hal.h |  1 -
drivers/staging/r8188eu/include/rtw_cmd.h      |  4 ++--
drivers/staging/r8188eu/include/sta_info.h     |  2 +-
drivers/staging/r8188eu/os_dep/os_intfs.c      |  8 ++++----
10 files changed, 30 insertions(+), 45 deletions(-)
delete mode 100644 drivers/staging/r8188eu/include/odm_types.h
[PATCH 0/5] staging: r8188eu: some cleanups
Posted by Michael Straube 3 years, 6 months ago
The first patch of this series merges leftover macros in odm_types.h
into appropriate other headers and removes odm_types.h.

The other patches convert some functions away from returning _FAIL /
_SUCCESS.

Note: Converting _rtw_init_xmit_priv() and _rtw_init_recv_priv() away
from _FAIL / _SUCCESS is a bit more complicated. I am going to do that
in follow up patches.

Tested on x86_64 with Inter-Tech DMG-02.

Michael Straube (5):
  staging: r8188eu: merge odm_types.h into other headers
  staging: r8188eu: convert rtw_init_evt_priv() to common error logic
  staging: r8188eu: convert rtw_init_cmd_priv() to common error logic
  staging: r8188eu: convert rtw_init_mlme_priv() to common error logic
  staging: r8188eu: convert _rtw_init_sta_priv() to common error logic

 drivers/staging/r8188eu/core/rtw_cmd.c         | 16 +++++++---------
 drivers/staging/r8188eu/core/rtw_mlme.c        | 12 ++++--------
 drivers/staging/r8188eu/core/rtw_sta_mgt.c     |  6 +++---
 drivers/staging/r8188eu/include/odm.h          |  3 ++-
 drivers/staging/r8188eu/include/odm_RTL8188E.h |  7 +++++++
 drivers/staging/r8188eu/include/odm_types.h    | 16 ----------------
 drivers/staging/r8188eu/include/rtl8188e_hal.h |  1 -
 drivers/staging/r8188eu/include/rtw_cmd.h      |  4 ++--
 drivers/staging/r8188eu/include/sta_info.h     |  2 +-
 drivers/staging/r8188eu/os_dep/os_intfs.c      |  8 ++++----
 10 files changed, 30 insertions(+), 45 deletions(-)
 delete mode 100644 drivers/staging/r8188eu/include/odm_types.h

-- 
2.37.3
Re: [PATCH 0/5] staging: r8188eu: some cleanups
Posted by Philipp Hortmann 3 years, 6 months ago
On 10/2/22 09:48, Michael Straube wrote:
> The first patch of this series merges leftover macros in odm_types.h
> into appropriate other headers and removes odm_types.h.
> 
> The other patches convert some functions away from returning _FAIL /
> _SUCCESS.
> 
> Note: Converting _rtw_init_xmit_priv() and _rtw_init_recv_priv() away
> from _FAIL / _SUCCESS is a bit more complicated. I am going to do that
> in follow up patches.
> 
> Tested on x86_64 with Inter-Tech DMG-02.
> 
> Michael Straube (5):
>    staging: r8188eu: merge odm_types.h into other headers
>    staging: r8188eu: convert rtw_init_evt_priv() to common error logic
>    staging: r8188eu: convert rtw_init_cmd_priv() to common error logic
>    staging: r8188eu: convert rtw_init_mlme_priv() to common error logic
>    staging: r8188eu: convert _rtw_init_sta_priv() to common error logic
> 
>   drivers/staging/r8188eu/core/rtw_cmd.c         | 16 +++++++---------
>   drivers/staging/r8188eu/core/rtw_mlme.c        | 12 ++++--------
>   drivers/staging/r8188eu/core/rtw_sta_mgt.c     |  6 +++---
>   drivers/staging/r8188eu/include/odm.h          |  3 ++-
>   drivers/staging/r8188eu/include/odm_RTL8188E.h |  7 +++++++
>   drivers/staging/r8188eu/include/odm_types.h    | 16 ----------------
>   drivers/staging/r8188eu/include/rtl8188e_hal.h |  1 -
>   drivers/staging/r8188eu/include/rtw_cmd.h      |  4 ++--
>   drivers/staging/r8188eu/include/sta_info.h     |  2 +-
>   drivers/staging/r8188eu/os_dep/os_intfs.c      |  8 ++++----
>   10 files changed, 30 insertions(+), 45 deletions(-)
>   delete mode 100644 drivers/staging/r8188eu/include/odm_types.h
> 

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150