[PATCH net-next v7 0/9] net: marvell: prestera: add nexthop routes offloading

Yevhen Orlov posted 9 patches 1 year, 6 months ago
.../net/ethernet/marvell/prestera/prestera.h  |   12 +
.../ethernet/marvell/prestera/prestera_hw.c   |  130 ++
.../ethernet/marvell/prestera/prestera_hw.h   |   11 +
.../ethernet/marvell/prestera/prestera_main.c |   11 +
.../marvell/prestera/prestera_router.c        | 1119 ++++++++++++++++-
.../marvell/prestera/prestera_router_hw.c     |  366 +++++-
.../marvell/prestera/prestera_router_hw.h     |   76 +-
7 files changed, 1683 insertions(+), 42 deletions(-)
[PATCH net-next v7 0/9] net: marvell: prestera: add nexthop routes offloading
Posted by Yevhen Orlov 1 year, 6 months ago
Add support for nexthop routes for Marvell Prestera driver.
Subscribe on NEIGH_UPDATE events.

Add features:
 - Support connected route adding
   e.g.: "ip address add 1.1.1.1/24 dev sw1p1"
   e.g.: "ip route add 6.6.6/24 dev sw1p1"
 - Support nexthop route adding
   e.g.: "ip route add 5.5.5/24 via 1.1.1.2"
 - Support ECMP route adding
   e.g.: "ip route add 5.5.5/24 nexthop via 1.1.1.2 nexthop via 1.1.1.3"
 - Support "offload" and "trap" flags per each nexthop
 - Support "offload" flag for neighbours

Limitations:
 - Only "local" and "main" tables supported
 - Only generic interfaces supported for router (no bridges or vlans)

Flags meaning:
  ip route add 5.5.5/24 nexthop via 2.2.2.2 nexthop via 2.2.2.3
  ip route show
  ...
  5.5.5.0/24 rt_offload
        nexthop via 2.2.2.2 dev sw1p31 weight 1 trap
        nexthop via 2.2.2.3 dev sw1p31 weight 1 trap
  ...
  # When you just add route - lpm entry became occupied
  # in HW ("rt_offload" flag), but related to nexthops neighbours
  # still not resolved ("trap" flag).
  #
  # After some time...
  ip route show
  ...
  5.5.5.0/24 rt_offload
        nexthop via 2.2.2.2 dev sw1p31 weight 1 offload
        nexthop via 2.2.2.3 dev sw1p31 weight 1 offload
  ...
  # You will see, that appropriate neighbours was resolved and nexthop
  # entries occupied in HW too ("offload" flag)

Co-developed-by: Taras Chornyi <tchornyi@marvell.com>
Signed-off-by: Taras Chornyi <tchornyi@marvell.com>
Co-developed-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>

Changes for v2:
* Add more reviewers in CC
* Check if route nexthop or direct with fib_nh_gw_family instead of fib_nh_scope
  This is needed after,
  747c14307214 ("ip: fix dflt addr selection for connected nexthop"),
  because direct route is now with the same scope as nexthop (RT_SCOPE_LINK)

Changes for v3:
* Resolve "unused functions" warnings, after
  patch ("net: marvell: prestera: Add heplers to interact ... "), and before
  patch ("net: marvell: prestera: Add neighbour cache accounting")

Changes for v4:
* Rebase to the latest master to resolve patch applying issues

Changes for v5:
* Repack structures to prevent holes
* Remove unused variables
* Fix misspeling issues

Changes for v6:
* Rebase on top of master
* Fix smatch warnings

Changes for v7:
* Rebase on top of master
* Refactor: use "fib_lookup" instead of "fib_new_table"+"fib_table_lookup",
  according to Paolo Abeni suggestion
* Refactor: use "rhashtable_free_and_destroy" instead of rhashtable
  walk, according to Paolo Abeni suggestion

Yevhen Orlov (9):
  net: marvell: prestera: Add router nexthops ABI
  net: marvell: prestera: Add cleanup of allocated fib_nodes
  net: marvell: prestera: Add strict cleanup of fib arbiter
  net: marvell: prestera: add delayed wq and flush wq on deinit
  net: marvell: prestera: Add length macros for prestera_ip_addr
  net: marvell: prestera: Add heplers to interact with fib_notifier_info
  net: marvell: prestera: add stub handler neighbour events
  net: marvell: prestera: Add neighbour cache accounting
  net: marvell: prestera: Propagate nh state from hw to kernel

 .../net/ethernet/marvell/prestera/prestera.h  |   12 +
 .../ethernet/marvell/prestera/prestera_hw.c   |  130 ++
 .../ethernet/marvell/prestera/prestera_hw.h   |   11 +
 .../ethernet/marvell/prestera/prestera_main.c |   11 +
 .../marvell/prestera/prestera_router.c        | 1119 ++++++++++++++++-
 .../marvell/prestera/prestera_router_hw.c     |  366 +++++-
 .../marvell/prestera/prestera_router_hw.h     |   76 +-
 7 files changed, 1683 insertions(+), 42 deletions(-)

-- 
2.17.1
Re: [PATCH net-next v7 0/9] net: marvell: prestera: add nexthop routes offloading
Posted by patchwork-bot+netdevbpf@kernel.org 1 year, 6 months ago
Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Sat,  1 Oct 2022 12:34:08 +0300 you wrote:
> Add support for nexthop routes for Marvell Prestera driver.
> Subscribe on NEIGH_UPDATE events.
> 
> Add features:
>  - Support connected route adding
>    e.g.: "ip address add 1.1.1.1/24 dev sw1p1"
>    e.g.: "ip route add 6.6.6/24 dev sw1p1"
>  - Support nexthop route adding
>    e.g.: "ip route add 5.5.5/24 via 1.1.1.2"
>  - Support ECMP route adding
>    e.g.: "ip route add 5.5.5/24 nexthop via 1.1.1.2 nexthop via 1.1.1.3"
>  - Support "offload" and "trap" flags per each nexthop
>  - Support "offload" flag for neighbours
> 
> [...]

Here is the summary with links:
  - [net-next,v7,1/9] net: marvell: prestera: Add router nexthops ABI
    https://git.kernel.org/netdev/net-next/c/0a23ae237171
  - [net-next,v7,2/9] net: marvell: prestera: Add cleanup of allocated fib_nodes
    https://git.kernel.org/netdev/net-next/c/1e7313e83ef7
  - [net-next,v7,3/9] net: marvell: prestera: Add strict cleanup of fib arbiter
    https://git.kernel.org/netdev/net-next/c/333fe4d033fa
  - [net-next,v7,4/9] net: marvell: prestera: add delayed wq and flush wq on deinit
    https://git.kernel.org/netdev/net-next/c/90b6f9c09851
  - [net-next,v7,5/9] net: marvell: prestera: Add length macros for prestera_ip_addr
    https://git.kernel.org/netdev/net-next/c/59b44ea8aa56
  - [net-next,v7,6/9] net: marvell: prestera: Add heplers to interact with fib_notifier_info
    https://git.kernel.org/netdev/net-next/c/04f24a1e6de6
  - [net-next,v7,7/9] net: marvell: prestera: add stub handler neighbour events
    https://git.kernel.org/netdev/net-next/c/8b1ef4911a41
  - [net-next,v7,8/9] net: marvell: prestera: Add neighbour cache accounting
    https://git.kernel.org/netdev/net-next/c/396b80cb5cc8
  - [net-next,v7,9/9] net: marvell: prestera: Propagate nh state from hw to kernel
    https://git.kernel.org/netdev/net-next/c/ae15ed6e40c9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html