[v1] Add dma gpi support for QDU1000/QRU1000 SoCs

[PATCH 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

Posted by Melody Olvera 3 years, 4 months ago

Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs.

Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
 drivers/dma/qcom/gpi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index 8f0c9c4e2efd..94f92317979c 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -2292,6 +2292,8 @@ static const struct of_device_id gpi_of_match[] = {
 	{ .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 },
 	{ .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },
 	{ .compatible = "qcom,sm8450-gpi-dma", .data = (void *)0x10000 },
+	{ .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 },
+	{ .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, gpi_of_match);
-- 
2.37.3

Re: [PATCH 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

Posted by Dmitry Baryshkov 3 years, 4 months ago

On Sat, 1 Oct 2022 at 06:08, Melody Olvera <quic_molvera@quicinc.com> wrote:
>
> Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
>  drivers/dma/qcom/gpi.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index 8f0c9c4e2efd..94f92317979c 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -2292,6 +2292,8 @@ static const struct of_device_id gpi_of_match[] = {
>         { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 },
>         { .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },
>         { .compatible = "qcom,sm8450-gpi-dma", .data = (void *)0x10000 },
> +       { .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 },
> +       { .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 },

As usual

>         { },
>  };
>  MODULE_DEVICE_TABLE(of, gpi_of_match);
> --
> 2.37.3
>


-- 
With best wishes
Dmitry

Re: [PATCH 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

Posted by Krzysztof Kozlowski 3 years, 4 months ago

On 01/10/2022 09:14, Dmitry Baryshkov wrote:
> On Sat, 1 Oct 2022 at 06:08, Melody Olvera <quic_molvera@quicinc.com> wrote:
>>
>> Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>>  drivers/dma/qcom/gpi.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
>> index 8f0c9c4e2efd..94f92317979c 100644
>> --- a/drivers/dma/qcom/gpi.c
>> +++ b/drivers/dma/qcom/gpi.c
>> @@ -2292,6 +2292,8 @@ static const struct of_device_id gpi_of_match[] = {
>>         { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 },
>>         { .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },
>>         { .compatible = "qcom,sm8450-gpi-dma", .data = (void *)0x10000 },
>> +       { .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 },
>> +       { .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 },
> 
> As usual

I would say - drop entire patch and rebase patchset on:

https://patchwork.kernel.org/project/linux-arm-msm/list/?series=680815&state=*

Best regards,
Krzysztof

Re: [PATCH 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

Posted by Melody Olvera 3 years, 4 months ago


On 10/1/2022 4:30 AM, Krzysztof Kozlowski wrote:
> On 01/10/2022 09:14, Dmitry Baryshkov wrote:
>> On Sat, 1 Oct 2022 at 06:08, Melody Olvera <quic_molvera@quicinc.com> wrote:
>>> Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs.
>>>
>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>> ---
>>>  drivers/dma/qcom/gpi.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
>>> index 8f0c9c4e2efd..94f92317979c 100644
>>> --- a/drivers/dma/qcom/gpi.c
>>> +++ b/drivers/dma/qcom/gpi.c
>>> @@ -2292,6 +2292,8 @@ static const struct of_device_id gpi_of_match[] = {
>>>         { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 },
>>>         { .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },
>>>         { .compatible = "qcom,sm8450-gpi-dma", .data = (void *)0x10000 },
>>> +       { .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 },
>>> +       { .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 },
>> As usual
Will address ordering.
> I would say - drop entire patch and rebase patchset on:
>
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=680815&state=*
Sure thing; will rebase.
>
> Best regards,
> Krzysztof
Thanks,
Melody