[v1] usb: dwc3: st: Rely on child's compatible instead of name

[PATCH] usb: dwc3: st: Rely on child's compatible instead of name

Posted by patrice.chotard@foss.st.com 3 years, 6 months ago

From: Patrice Chotard <patrice.chotard@foss.st.com>

To ensure that child node is found, don't rely on child's node name
which can take different value, but on child's compatible name.

Cc: Jerome Audu <jerome.audu@st.com>
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
 drivers/usb/dwc3/dwc3-st.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
index 166b5bde45cb..fea5290de83f 100644
--- a/drivers/usb/dwc3/dwc3-st.c
+++ b/drivers/usb/dwc3/dwc3-st.c
@@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
 	/* Manage SoftReset */
 	reset_control_deassert(dwc3_data->rstc_rst);
 
-	child = of_get_child_by_name(node, "dwc3");
+	child = of_get_compatible_child(node, "snps,dwc3");
 	if (!child) {
 		dev_err(&pdev->dev, "failed to find dwc3 core node\n");
 		ret = -ENODEV;
-- 
2.25.1

Re: [PATCH] usb: dwc3: st: Rely on child's compatible instead of name

Posted by Greg Kroah-Hartman 3 years, 6 months ago

On Fri, Sep 30, 2022 at 08:44:06AM +0200, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
> 
> To ensure that child node is found, don't rely on child's node name
> which can take different value, but on child's compatible name.
> 
> Cc: Jerome Audu <jerome.audu@st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>

What commit id does this fix?

Who reported the problem?

thanks,

greg k-h

Re: [PATCH] usb: dwc3: st: Rely on child's compatible instead of name

Posted by Patrice CHOTARD 3 years, 6 months ago

Hi Greg

On 9/30/22 08:50, Greg Kroah-Hartman wrote:
> On Fri, Sep 30, 2022 at 08:44:06AM +0200, patrice.chotard@foss.st.com wrote:
>> From: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> To ensure that child node is found, don't rely on child's node name
>> which can take different value, but on child's compatible name.
>>
>> Cc: Jerome Audu <jerome.audu@st.com>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> 
> What commit id does this fix?

A fix has been already merged [1]
The goal of this patch is to hardened the child's check, but okay,
i will add a Fixes reference.

> 
> Who reported the problem?

Ah, sorry, i forgot to add reported-by Felipe Balbi <felipe@balbi.sh>

Will send a v2

Thanks
Patrice

[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220926124359.304770-1-patrice.chotard@foss.st.com

> 
> thanks,
> 
> greg k-h