On 30.09.22 08:35, Zhao Gongyi wrote:
> Redirect misleading error message to /dev/null for
> offline_memory_expect_success(), And, add an output
> for online->offline test.
>
> Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> ---
> tools/testing/selftests/memory-hotplug/mem-on-off-test.sh | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> index 91a7457616bb..74ee5067a8ce 100755
> --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> @@ -207,8 +207,11 @@ echo -e "\t trying to offline $target out of $hotpluggable_num memory block(s):"
> for memory in `hotpluggable_online_memory`; do
> if [ "$target" -gt 0 ]; then
> echo "online->offline memory$memory"
> - if offline_memory_expect_success $memory; then
> + if offline_memory_expect_success $memory &>/dev/null; then
> target=$(($target - 1))
> + echo "-> Success"
> + else
> + echo "-> Failure"
> fi
> fi
> done
> @@ -267,7 +270,7 @@ prerequisite_extra
> echo 0 > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_OFFLINE/error
> for memory in `hotpluggable_online_memory`; do
> if [ $((RANDOM % 100)) -lt $ratio ]; then
> - offline_memory_expect_success $memory
> + offline_memory_expect_success $memory &>/dev/null
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb