[PATCH v4 0/7] pwm: lpss: Clean up and convert to a pure library

Andy Shevchenko posted 7 patches 3 years, 6 months ago
drivers/pwm/pwm-lpss-pci.c      | 48 ++++++++-------------------------
drivers/pwm/pwm-lpss-platform.c | 40 +++++++--------------------
drivers/pwm/pwm-lpss.c          | 46 ++++++++++++++++++++++++++-----
drivers/pwm/pwm-lpss.h          | 12 ++++++++-
4 files changed, 72 insertions(+), 74 deletions(-)
[PATCH v4 0/7] pwm: lpss: Clean up and convert to a pure library
Posted by Andy Shevchenko 3 years, 6 months ago
First of all, a set of cleanups and code deduplications (for better
maintenance) to the PWM LPSS driver.

Second, we may (re-)use the core part as a library in the future in
the devices that combine the same PWM IP in their address space. So
convert the core file to be a pure library which doesn't require any
special resource handling or alike.

Changelog v4:
- dropped the forward declaration use patch, seems too many questions to it

Changelog v3:
- postponed last patch until we have a new user
- added tags (Uwe, Hans)
- expanded commit message on why forward declarations are preferred over
  full header inclusions

Changelog v2:
- replace patch 1 by Uwe's version (Uwe)
- update NS patch to have a default namespace defined (Uwe)
- describe all changes done in patch 4 (Uwe)


Andy Shevchenko (6):
  pwm: lpss: Move exported symbols to PWM_LPSS namespace
  pwm: lpss: Move resource mapping to the glue drivers
  pwm: lpss: Use device_get_match_data to get device data
  pwm: lpss: Use DEFINE_RUNTIME_DEV_PM_OPS() and pm_ptr() macros
  pwm: lpss: Make use of bits.h macros for all masks
  pwm: lpss: Add a comment to the bypass field

Uwe Kleine-König (1):
  pwm: lpss: Deduplicate board info data structures

 drivers/pwm/pwm-lpss-pci.c      | 48 ++++++++-------------------------
 drivers/pwm/pwm-lpss-platform.c | 40 +++++++--------------------
 drivers/pwm/pwm-lpss.c          | 46 ++++++++++++++++++++++++++-----
 drivers/pwm/pwm-lpss.h          | 12 ++++++++-
 4 files changed, 72 insertions(+), 74 deletions(-)

-- 
2.35.1

Re: [PATCH v4 0/7] pwm: lpss: Clean up and convert to a pure library
Posted by Thierry Reding 3 years, 6 months ago
On Tue, Sep 27, 2022 at 07:24:14PM +0300, Andy Shevchenko wrote:
> First of all, a set of cleanups and code deduplications (for better
> maintenance) to the PWM LPSS driver.
> 
> Second, we may (re-)use the core part as a library in the future in
> the devices that combine the same PWM IP in their address space. So
> convert the core file to be a pure library which doesn't require any
> special resource handling or alike.
> 
> Changelog v4:
> - dropped the forward declaration use patch, seems too many questions to it
> 
> Changelog v3:
> - postponed last patch until we have a new user
> - added tags (Uwe, Hans)
> - expanded commit message on why forward declarations are preferred over
>   full header inclusions
> 
> Changelog v2:
> - replace patch 1 by Uwe's version (Uwe)
> - update NS patch to have a default namespace defined (Uwe)
> - describe all changes done in patch 4 (Uwe)
> 
> 
> Andy Shevchenko (6):
>   pwm: lpss: Move exported symbols to PWM_LPSS namespace
>   pwm: lpss: Move resource mapping to the glue drivers
>   pwm: lpss: Use device_get_match_data to get device data
>   pwm: lpss: Use DEFINE_RUNTIME_DEV_PM_OPS() and pm_ptr() macros
>   pwm: lpss: Make use of bits.h macros for all masks
>   pwm: lpss: Add a comment to the bypass field
> 
> Uwe Kleine-König (1):
>   pwm: lpss: Deduplicate board info data structures
> 
>  drivers/pwm/pwm-lpss-pci.c      | 48 ++++++++-------------------------
>  drivers/pwm/pwm-lpss-platform.c | 40 +++++++--------------------
>  drivers/pwm/pwm-lpss.c          | 46 ++++++++++++++++++++++++++-----
>  drivers/pwm/pwm-lpss.h          | 12 ++++++++-
>  4 files changed, 72 insertions(+), 74 deletions(-)

Series applied, thanks.

Thierry
Re: [PATCH v4 0/7] pwm: lpss: Clean up and convert to a pure library
Posted by Andy Shevchenko 3 years, 6 months ago
On Wed, Sep 28, 2022 at 04:22:18PM +0200, Thierry Reding wrote:
> On Tue, Sep 27, 2022 at 07:24:14PM +0300, Andy Shevchenko wrote:
> > First of all, a set of cleanups and code deduplications (for better
> > maintenance) to the PWM LPSS driver.
> > 
> > Second, we may (re-)use the core part as a library in the future in
> > the devices that combine the same PWM IP in their address space. So
> > convert the core file to be a pure library which doesn't require any
> > special resource handling or alike.

> Series applied, thanks.

Thank you!

-- 
With Best Regards,
Andy Shevchenko