From: Xiang wangx <wangxiang@cdjrlc.com>

[ Upstream commit fc378794a2f7a19cf26010dc33b89ba608d4c70f ]

Delete the redundant word 'its'.

Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/video/fbdev/skeletonfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/skeletonfb.c b/drivers/video/fbdev/skeletonfb.c
index f948baa16d82..254bb6e2187c 100644
--- a/drivers/video/fbdev/skeletonfb.c
+++ b/drivers/video/fbdev/skeletonfb.c
@@ -96,7 +96,7 @@ static struct fb_fix_screeninfo xxxfb_fix = {
 
     /*
      * 	Modern graphical hardware not only supports pipelines but some 
-     *  also support multiple monitors where each display can have its  
+     *  also support multiple monitors where each display can have
      *  its own unique data. In this case each display could be  
      *  represented by a separate framebuffer device thus a separate 
      *  struct fb_info. Now the struct xxx_par represents the graphics
-- 
2.35.1

On Mon 2022-09-26 12:11:35, Greg Kroah-Hartman wrote:
> From: Xiang wangx <wangxiang@cdjrlc.com>
> 
> [ Upstream commit fc378794a2f7a19cf26010dc33b89ba608d4c70f ]
> 
> Delete the redundant word 'its'.

This does not belong in stable.

Best regards,
							Pavel

> +++ b/drivers/video/fbdev/skeletonfb.c
> @@ -96,7 +96,7 @@ static struct fb_fix_screeninfo xxxfb_fix = {
>  
>      /*
>       * 	Modern graphical hardware not only supports pipelines but some 
> -     *  also support multiple monitors where each display can have its  
> +     *  also support multiple monitors where each display can have
>       *  its own unique data. In this case each display could be  
>       *  represented by a separate framebuffer device thus a separate 
>       *  struct fb_info. Now the struct xxx_par represents the graphics

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

On Mon, Sep 26, 2022 at 12:28:01PM +0200, Pavel Machek wrote:
> On Mon 2022-09-26 12:11:35, Greg Kroah-Hartman wrote:
> > From: Xiang wangx <wangxiang@cdjrlc.com>
> > 
> > [ Upstream commit fc378794a2f7a19cf26010dc33b89ba608d4c70f ]
> > 
> > Delete the redundant word 'its'.
> 
> This does not belong in stable.

Agreed, I thought I caught this before.  Now dropped.

greg k-h

On 9/26/22 17:28, Pavel Machek wrote:
> On Mon 2022-09-26 12:11:35, Greg Kroah-Hartman wrote:
>> From: Xiang wangx <wangxiang@cdjrlc.com>
>>
>> [ Upstream commit fc378794a2f7a19cf26010dc33b89ba608d4c70f ]
>>
>> Delete the redundant word 'its'.
> 
> This does not belong in stable.
> 

Without seeing the upstream commit, the patch subject is misleading:
the patch doesn't fix any syntax errors as one might get from the
compiler.

Also, what I find irritating is that I have never seen reply from
@cdjrlc.com people to review comments pointing flaws of their patch.
I guess they don't have any other jobs here in LKML other than just
throwing one-line redundant word stripping patches. The similar cause
is why Jani Nikula [1] and Greg NAKed cgel.zte patches (ignoring
reviews and "atypical" corporate email structure [2])

Hence NAK (agree with your verdict). However, should the upstream
commit be reverted?

[1]: https://lore.kernel.org/lkml/878rn1dd8l.fsf@intel.com/
[2]: https://lore.kernel.org/lkml/Yylv5hbSBejJ58nt@kroah.com/

-- 
An old man doll... just what I always wanted! - Clara