[PATCH] virtio_ring: split: Operators use unified style

Deming Wang posted 1 patch 3 years, 6 months ago
drivers/virtio/virtio_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] virtio_ring: split: Operators use unified style
Posted by Deming Wang 3 years, 6 months ago
The operators of vring_alloc_queue_split should use the unified style.Add
space for the '|' ,make it be looked more pretty.

Signed-off-by: Deming Wang <wangdeming@inspur.com>
---
 drivers/virtio/virtio_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 8974c34b40fd..7510163565b7 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -1074,7 +1074,7 @@ static int vring_alloc_queue_split(struct vring_virtqueue_split *vring_split,
 	if (!queue) {
 		/* Try to get a single page. You are my only hope! */
 		queue = vring_alloc_queue(vdev, vring_size(num, vring_align),
-					  &dma_addr, GFP_KERNEL|__GFP_ZERO);
+					  &dma_addr, GFP_KERNEL | __GFP_ZERO);
 	}
 	if (!queue)
 		return -ENOMEM;
-- 
2.27.0
Re: [PATCH] virtio_ring: split: Operators use unified style
Posted by Michael S. Tsirkin 3 years, 5 months ago
On Sun, Sep 25, 2022 at 10:22:02PM -0400, Deming Wang wrote:
> The operators of vring_alloc_queue_split should use the unified style.Add
> space for the '|' ,make it be looked more pretty.
> 
> Signed-off-by: Deming Wang <wangdeming@inspur.com>

Thanks for the patch!
Since this is about cosmetics let's make the patch look good:

Pls tweak the commit log. Space after . and , no space before ,
unified style -> kernel coding style
make it be looked more pretty -> make it prettier.


> ---
>  drivers/virtio/virtio_ring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 8974c34b40fd..7510163565b7 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -1074,7 +1074,7 @@ static int vring_alloc_queue_split(struct vring_virtqueue_split *vring_split,
>  	if (!queue) {
>  		/* Try to get a single page. You are my only hope! */
>  		queue = vring_alloc_queue(vdev, vring_size(num, vring_align),
> -					  &dma_addr, GFP_KERNEL|__GFP_ZERO);
> +					  &dma_addr, GFP_KERNEL | __GFP_ZERO);
>  	}
>  	if (!queue)
>  		return -ENOMEM;
> -- 
> 2.27.0