[PATCH printk 03/18] printk: Remove write only variable nr_ext_console_drivers

John Ogness posted 18 patches 3 years, 6 months ago
[PATCH printk 03/18] printk: Remove write only variable nr_ext_console_drivers
Posted by John Ogness 3 years, 6 months ago
From: Thomas Gleixner <tglx@linutronix.de>

Commit a699449bb13b ("printk: refactor and rework printing logic")
removed the need for @nr_ext_console_drivers. Remove the unneeded
variable.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
---
 kernel/printk/printk.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 14d7d39d118d..d6bba2ea14e8 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -220,9 +220,6 @@ int devkmsg_sysctl_set_loglvl(struct ctl_table *table, int write,
 }
 #endif /* CONFIG_PRINTK && CONFIG_SYSCTL */
 
-/* Number of registered extended console drivers. */
-static int nr_ext_console_drivers;
-
 /*
  * Helper macros to handle lockdep when locking/unlocking console_sem. We use
  * macros instead of functions so that _RET_IP_ contains useful information.
@@ -3188,9 +3185,6 @@ void register_console(struct console *newcon)
 		console_drivers->next = newcon;
 	}
 
-	if (newcon->flags & CON_EXTENDED)
-		nr_ext_console_drivers++;
-
 	newcon->dropped = 0;
 	if (newcon->flags & CON_PRINTBUFFER) {
 		/* Get a consistent copy of @syslog_seq. */
@@ -3256,9 +3250,6 @@ int unregister_console(struct console *console)
 	if (res)
 		goto out_disable_unlock;
 
-	if (console->flags & CON_EXTENDED)
-		nr_ext_console_drivers--;
-
 	/*
 	 * If this isn't the last console and it has CON_CONSDEV set, we
 	 * need to set it on the next preferred console.
-- 
2.30.2
Re: [PATCH printk 03/18] printk: Remove write only variable nr_ext_console_drivers
Posted by Petr Mladek 3 years, 6 months ago
On Sat 2022-09-24 02:10:39, John Ogness wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Commit a699449bb13b ("printk: refactor and rework printing logic")
> removed the need for @nr_ext_console_drivers. Remove the unneeded
> variable.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
> Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr