[PATCH linux-next] ALSA: hda/ca0132 - remove the unneeded result variable

cgel.zte@gmail.com posted 1 patch 3 years, 6 months ago
sound/pci/hda/patch_ca0132.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
[PATCH linux-next] ALSA: hda/ca0132 - remove the unneeded result variable
Posted by cgel.zte@gmail.com 3 years, 6 months ago
From: ye xingchen <ye.xingchen@zte.com.cn>

Return the value dsp_allocate_ports() directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 sound/pci/hda/patch_ca0132.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index 208933792787..9580fe00cbd9 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -2962,7 +2962,6 @@ static int dsp_allocate_ports_format(struct hda_codec *codec,
 			const unsigned short fmt,
 			unsigned int *port_map)
 {
-	int status;
 	unsigned int num_chans;
 
 	unsigned int sample_rate_div = ((get_hdafmt_rate(fmt) >> 0) & 3) + 1;
@@ -2976,9 +2975,7 @@ static int dsp_allocate_ports_format(struct hda_codec *codec,
 
 	num_chans = get_hdafmt_chs(fmt) + 1;
 
-	status = dsp_allocate_ports(codec, num_chans, rate_multi, port_map);
-
-	return status;
+	return dsp_allocate_ports(codec, num_chans, rate_multi, port_map);
 }
 
 /*
-- 
2.25.1
Re: [PATCH linux-next] ALSA: hda/ca0132 - remove the unneeded result variable
Posted by Takashi Iwai 3 years, 6 months ago
On Thu, 22 Sep 2022 13:28:46 +0200,
cgel.zte@gmail.com wrote:
> 
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Return the value dsp_allocate_ports() directly instead of storing it in
> another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Thanks, applied.


Takashi