[Patch net-next v4 3/6] net: dsa: microchip: lan937x: return zero if mdio node not present

Arun Ramadoss posted 6 patches 3 years, 2 months ago
[Patch net-next v4 3/6] net: dsa: microchip: lan937x: return zero if mdio node not present
Posted by Arun Ramadoss 3 years, 2 months ago
Currently, if the mdio node is not present in the dts file then
lan937x_mdio_register return -ENODEV and entire probing process fails.
To make the mdio_register generic for all ksz series switches and to
maintain back-compatibility with existing dts file, return -ENODEV is
replaced with return 0.

Signed-off-by: Arun Ramadoss <arun.ramadoss@microchip.com>
---
 drivers/net/dsa/microchip/lan937x_main.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/dsa/microchip/lan937x_main.c b/drivers/net/dsa/microchip/lan937x_main.c
index 2664331cc743..d7382a77d454 100644
--- a/drivers/net/dsa/microchip/lan937x_main.c
+++ b/drivers/net/dsa/microchip/lan937x_main.c
@@ -214,10 +214,8 @@ static int lan937x_mdio_register(struct ksz_device *dev)
 	int ret;
 
 	mdio_np = of_get_child_by_name(dev->dev->of_node, "mdio");
-	if (!mdio_np) {
-		dev_err(ds->dev, "no MDIO bus node\n");
-		return -ENODEV;
-	}
+	if (!mdio_np)
+		return 0;
 
 	bus = devm_mdiobus_alloc(ds->dev);
 	if (!bus) {
-- 
2.36.1
Re: [Patch net-next v4 3/6] net: dsa: microchip: lan937x: return zero if mdio node not present
Posted by Andrew Lunn 3 years, 2 months ago
On Thu, Sep 22, 2022 at 12:40:25PM +0530, Arun Ramadoss wrote:
> Currently, if the mdio node is not present in the dts file then
> lan937x_mdio_register return -ENODEV and entire probing process fails.
> To make the mdio_register generic for all ksz series switches and to
> maintain back-compatibility with existing dts file, return -ENODEV is
> replaced with return 0.
> 
> Signed-off-by: Arun Ramadoss <arun.ramadoss@microchip.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew