lib/vdso: use "grep -E" instead of "egrep"

[PATCH] lib/vdso: use "grep -E" instead of "egrep"

Posted by Greg Kroah-Hartman 3 years, 6 months ago

The latest version of grep claims the egrep is now obsolete so the build
now contains warnings that look like:
	egrep: warning: egrep is obsolescent; using grep -E
fix this up by moving the vdso Makefile to use "grep -E" instead.

Cc: Andy Lutomirski <luto@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 lib/vdso/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/vdso/Makefile b/lib/vdso/Makefile
index c415a685d61b..e814061d6aa0 100644
--- a/lib/vdso/Makefile
+++ b/lib/vdso/Makefile
@@ -17,6 +17,6 @@ $(error ARCH_REL_TYPE_ABS is not set)
 endif
 
 quiet_cmd_vdso_check = VDSOCHK $@
-      cmd_vdso_check = if $(OBJDUMP) -R $@ | egrep -h "$(ARCH_REL_TYPE_ABS)"; \
+      cmd_vdso_check = if $(OBJDUMP) -R $@ | grep -E -h "$(ARCH_REL_TYPE_ABS)"; \
 		       then (echo >&2 "$@: dynamic relocations are not supported"; \
 			     rm -f $@; /bin/false); fi
-- 
2.37.3

Re: [PATCH] lib/vdso: use "grep -E" instead of "egrep"

Posted by Vincenzo Frascino 3 years, 6 months ago

On 9/20/22 18:06, Greg Kroah-Hartman wrote:
> The latest version of grep claims the egrep is now obsolete so the build
> now contains warnings that look like:
> 	egrep: warning: egrep is obsolescent; using grep -E
> fix this up by moving the vdso Makefile to use "grep -E" instead.
> 
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>

> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  lib/vdso/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/vdso/Makefile b/lib/vdso/Makefile
> index c415a685d61b..e814061d6aa0 100644
> --- a/lib/vdso/Makefile
> +++ b/lib/vdso/Makefile
> @@ -17,6 +17,6 @@ $(error ARCH_REL_TYPE_ABS is not set)
>  endif
>  
>  quiet_cmd_vdso_check = VDSOCHK $@
> -      cmd_vdso_check = if $(OBJDUMP) -R $@ | egrep -h "$(ARCH_REL_TYPE_ABS)"; \
> +      cmd_vdso_check = if $(OBJDUMP) -R $@ | grep -E -h "$(ARCH_REL_TYPE_ABS)"; \
>  		       then (echo >&2 "$@: dynamic relocations are not supported"; \
>  			     rm -f $@; /bin/false); fi

-- 
Regards,
Vincenzo

Re: [PATCH] lib/vdso: use "grep -E" instead of "egrep"

Posted by Tiezhu Yang 3 years, 4 months ago

Hi,

This patch can not be found in the torvalds/linux.git or
next/linux-next.git tree, please take a look, thank you.

Thanks,
Tiezhu

Re: [PATCH] lib/vdso: use "grep -E" instead of "egrep"

Posted by Greg KH 3 years, 4 months ago

On Fri, Nov 18, 2022 at 04:44:50PM +0800, Tiezhu Yang wrote:
> Hi,
> 
> This patch can not be found in the torvalds/linux.git or
> next/linux-next.git tree, please take a look, thank you.

That is because no one has applied it to their trees :(

Re: [PATCH] lib/vdso: use "grep -E" instead of "egrep"

Posted by Tiezhu Yang 3 years, 4 months ago

Cc Andrew Morton <akpm@linux-foundation.org>

On 11/18/2022 05:12 PM, Greg KH wrote:
> On Fri, Nov 18, 2022 at 04:44:50PM +0800, Tiezhu Yang wrote:
>> Hi,
>>
>> This patch can not be found in the torvalds/linux.git or
>> next/linux-next.git tree, please take a look, thank you.
>
> That is because no one has applied it to their trees :(
>

Maybe Andrew can pick the following two patches sent by Greg.

[PATCH] lib/vdso: use "grep -E" instead of "egrep"
https://lore.kernel.org/lkml/20220920170633.3133829-1-gregkh@linuxfoundation.org/

[PATCH] scripts: coccicheck: use "grep -E" instead of "egrep"
https://lore.kernel.org/lkml/20220921091341.217365-1-gregkh@linuxfoundation.org/

Thanks,
Tiezhu

Re: [PATCH] lib/vdso: use "grep -E" instead of "egrep"

Posted by Tiezhu Yang 3 years, 4 months ago

Hi all,

Just FYI.

On 11/19/2022 09:54 AM, Tiezhu Yang wrote:
> Cc Andrew Morton <akpm@linux-foundation.org>
>
> On 11/18/2022 05:12 PM, Greg KH wrote:
>> On Fri, Nov 18, 2022 at 04:44:50PM +0800, Tiezhu Yang wrote:
>>> Hi,
>>>
>>> This patch can not be found in the torvalds/linux.git or
>>> next/linux-next.git tree, please take a look, thank you.
>>
>> That is because no one has applied it to their trees :(
>>
>
> Maybe Andrew can pick the following two patches sent by Greg.
>
> [PATCH] lib/vdso: use "grep -E" instead of "egrep"
> https://lore.kernel.org/lkml/20220920170633.3133829-1-gregkh@linuxfoundation.org/
>

AFAIK, this patch is not in any tree now.

>
> [PATCH] scripts: coccicheck: use "grep -E" instead of "egrep"
> https://lore.kernel.org/lkml/20220921091341.217365-1-gregkh@linuxfoundation.org/
>

This patch is in the following tree, sorry for missing that.

https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git/commit/?h=for-6.1&id=2d63e6a3d971

Thanks,
Tiezhu