[PATCH linux-next] ARM: OMAP2+: Remove the unneeded result variable

cgel.zte@gmail.com posted 1 patch 3 years, 6 months ago
arch/arm/mach-omap2/pm33xx-core.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
[PATCH linux-next] ARM: OMAP2+: Remove the unneeded result variable
Posted by cgel.zte@gmail.com 3 years, 6 months ago
From: ye xingchen <ye.xingchen@zte.com.cn>

Return the value amx3_common_init() directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 arch/arm/mach-omap2/pm33xx-core.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm/mach-omap2/pm33xx-core.c b/arch/arm/mach-omap2/pm33xx-core.c
index bf0d25fd2cea..4b29d8323ffc 100644
--- a/arch/arm/mach-omap2/pm33xx-core.c
+++ b/arch/arm/mach-omap2/pm33xx-core.c
@@ -105,8 +105,6 @@ static int amx3_common_init(int (*idle)(u32 wfi_flags))
 
 static int am33xx_suspend_init(int (*idle)(u32 wfi_flags))
 {
-	int ret;
-
 	gfx_l4ls_clkdm = clkdm_lookup("gfx_l4ls_gfx_clkdm");
 
 	if (!gfx_l4ls_clkdm) {
@@ -114,9 +112,7 @@ static int am33xx_suspend_init(int (*idle)(u32 wfi_flags))
 		return -ENODEV;
 	}
 
-	ret = amx3_common_init(idle);
-
-	return ret;
+	return amx3_common_init(idle);
 }
 
 static int am43xx_suspend_init(int (*idle)(u32 wfi_flags))
-- 
2.25.1
Re: [PATCH linux-next] ARM: OMAP2+: Remove the unneeded result variable
Posted by Tony Lindgren 3 years ago
* cgel.zte@gmail.com <cgel.zte@gmail.com> [220920 09:43]:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Return the value amx3_common_init() directly instead of storing it in
> another redundant variable.

Thanks applying into omap-for-v6.4/cleanup.

Tony