[PATCH linux-next] ALSA: es18xx: Remove the unneeded result variable

cgel.zte@gmail.com posted 1 patch 3 years, 6 months ago
sound/isa/es18xx.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
[PATCH linux-next] ALSA: es18xx: Remove the unneeded result variable
Posted by cgel.zte@gmail.com 3 years, 6 months ago
From: ye xingchen <ye.xingchen@zte.com.cn>

Return the value inb() directly instead of storing it in another redundant
 variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 sound/isa/es18xx.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/sound/isa/es18xx.c b/sound/isa/es18xx.c
index 3fcd168480b6..0a32845b1017 100644
--- a/sound/isa/es18xx.c
+++ b/sound/isa/es18xx.c
@@ -1344,11 +1344,8 @@ ES18XX_SINGLE("GPO1 Switch", 0, ES18XX_PM, 1, 1, ES18XX_FL_PMPORT),
 
 static int snd_es18xx_config_read(struct snd_es18xx *chip, unsigned char reg)
 {
-	int data;
-
 	outb(reg, chip->ctrl_port);
-	data = inb(chip->ctrl_port + 1);
-	return data;
+	return inb(chip->ctrl_port + 1);
 }
 
 static void snd_es18xx_config_write(struct snd_es18xx *chip,
-- 
2.25.1
Re: [PATCH linux-next] ALSA: es18xx: Remove the unneeded result variable
Posted by Takashi Iwai 3 years, 6 months ago
On Tue, 20 Sep 2022 08:46:05 +0200,
cgel.zte@gmail.com wrote:
> 
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Return the value inb() directly instead of storing it in another redundant
>  variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Thanks, applied.


Takashi