[PATCH] Bluetooth: MGMT: fix zalloc-simple.cocci warnings

Yihao Han posted 1 patch 3 years, 6 months ago
net/bluetooth/mgmt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
[PATCH] Bluetooth: MGMT: fix zalloc-simple.cocci warnings
Posted by Yihao Han 3 years, 6 months ago
Use zeroing allocator rather than allocator followed by memset with 0

Generated by: scripts/coccinelle/api/alloc/zalloc-simple.cocci

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 net/bluetooth/mgmt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index b9b64030a7b0..a92e7e485feb 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -4397,12 +4397,10 @@ static int read_exp_features_info(struct sock *sk, struct hci_dev *hdev,
 
 	/* Enough space for 7 features */
 	len = sizeof(*rp) + (sizeof(rp->features[0]) * 7);
-	rp = kmalloc(len, GFP_KERNEL);
+	rp = kzalloc(len, GFP_KERNEL);
 	if (!rp)
 		return -ENOMEM;
 
-	memset(rp, 0, len);
-
 #ifdef CONFIG_BT_FEATURE_DEBUG
 	if (!hdev) {
 		flags = bt_dbg_get() ? BIT(0) : 0;
-- 
2.17.1
Re: [PATCH] Bluetooth: MGMT: fix zalloc-simple.cocci warnings
Posted by patchwork-bot+bluetooth@kernel.org 3 years, 6 months ago
Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 19 Sep 2022 20:19:58 -0700 you wrote:
> Use zeroing allocator rather than allocator followed by memset with 0
> 
> Generated by: scripts/coccinelle/api/alloc/zalloc-simple.cocci
> 
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
>  net/bluetooth/mgmt.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Here is the summary with links:
  - Bluetooth: MGMT: fix zalloc-simple.cocci warnings
    https://git.kernel.org/bluetooth/bluetooth-next/c/239491111238

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html