[PATCH -next] net: sched: simplify code in mall_reoffload

williamsukatube@163.com posted 1 patch 3 years, 6 months ago
net/sched/cls_matchall.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
[PATCH -next] net: sched: simplify code in mall_reoffload
Posted by williamsukatube@163.com 3 years, 6 months ago
From: William Dean <williamsukatube@163.com>

such expression:
	if (err)
		return err;
	return 0;
can simplify to:
	return err;

Signed-off-by: William Dean <williamsukatube@163.com>
---
 net/sched/cls_matchall.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matchall.c
index 06cf22adbab7..63b99ffb7dbc 100644
--- a/net/sched/cls_matchall.c
+++ b/net/sched/cls_matchall.c
@@ -313,10 +313,7 @@ static int mall_reoffload(struct tcf_proto *tp, bool add, flow_setup_cb_t *cb,
 	tc_cleanup_offload_action(&cls_mall.rule->action);
 	kfree(cls_mall.rule);

-	if (err)
-		return err;
-
-	return 0;
+	return err;
 }

 static void mall_stats_hw_filter(struct tcf_proto *tp,
--
2.25.1
Re: [PATCH -next] net: sched: simplify code in mall_reoffload
Posted by patchwork-bot+netdevbpf@kernel.org 3 years, 6 months ago
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 17 Sep 2022 14:35:56 +0800 you wrote:
> From: William Dean <williamsukatube@163.com>
> 
> such expression:
> 	if (err)
> 		return err;
> 	return 0;
> can simplify to:
> 	return err;
> 
> [...]

Here is the summary with links:
  - [-next] net: sched: simplify code in mall_reoffload
    https://git.kernel.org/netdev/net-next/c/2801f30e2cef

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html