[v1] net: ethernet: ti: am65-cpsw: remove unused parameter of am65_cpsw_nuss_common_open()

[PATCH] net: ethernet: ti: am65-cpsw: remove unused parameter of am65_cpsw_nuss_common_open()

Posted by Guangbin Huang 3 years, 6 months ago

From: Jian Shen <shenjian15@huawei.com>

The inptu parameter 'features' is unused now. so remove it.

Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index 7ef5d8208a4e..4f8f3dda7764 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -363,8 +363,7 @@ static void am65_cpsw_init_host_port_emac(struct am65_cpsw_common *common);
 static void am65_cpsw_init_port_switch_ale(struct am65_cpsw_port *port);
 static void am65_cpsw_init_port_emac_ale(struct am65_cpsw_port *port);
 
-static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common,
-				      netdev_features_t features)
+static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common)
 {
 	struct am65_cpsw_host *host_p = am65_common_get_host(common);
 	int port_idx, i, ret;
@@ -577,7 +576,7 @@ static int am65_cpsw_nuss_ndo_slave_open(struct net_device *ndev)
 	for (i = 0; i < common->tx_ch_num; i++)
 		netdev_tx_reset_queue(netdev_get_tx_queue(ndev, i));
 
-	ret = am65_cpsw_nuss_common_open(common, ndev->features);
+	ret = am65_cpsw_nuss_common_open(common);
 	if (ret)
 		return ret;
 
-- 
2.33.0

Re: [PATCH] net: ethernet: ti: am65-cpsw: remove unused parameter of am65_cpsw_nuss_common_open()

Posted by huangguangbin (A) 3 years, 6 months ago

Sorry, please ignore this patch because target tree name is
not specified in the subject and not cc s-vadapalli@ti.com.

I will send this patch again.


On 2022/9/16 10:35, Guangbin Huang wrote:
> From: Jian Shen <shenjian15@huawei.com>
> 
> The inptu parameter 'features' is unused now. so remove it.
> 
> Signed-off-by: Jian Shen <shenjian15@huawei.com>
> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
> ---
>   drivers/net/ethernet/ti/am65-cpsw-nuss.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> index 7ef5d8208a4e..4f8f3dda7764 100644
> --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> @@ -363,8 +363,7 @@ static void am65_cpsw_init_host_port_emac(struct am65_cpsw_common *common);
>   static void am65_cpsw_init_port_switch_ale(struct am65_cpsw_port *port);
>   static void am65_cpsw_init_port_emac_ale(struct am65_cpsw_port *port);
>   
> -static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common,
> -				      netdev_features_t features)
> +static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common)
>   {
>   	struct am65_cpsw_host *host_p = am65_common_get_host(common);
>   	int port_idx, i, ret;
> @@ -577,7 +576,7 @@ static int am65_cpsw_nuss_ndo_slave_open(struct net_device *ndev)
>   	for (i = 0; i < common->tx_ch_num; i++)
>   		netdev_tx_reset_queue(netdev_get_tx_queue(ndev, i));
>   
> -	ret = am65_cpsw_nuss_common_open(common, ndev->features);
> +	ret = am65_cpsw_nuss_common_open(common);
>   	if (ret)
>   		return ret;
>   
>