On Thu, Sep 15, 2022 at 09:55:36AM +0300, Arınç ÜNAL wrote:
> Add syscon as a constant string on the compatible property as it's required
> for the SoC to work. Update the example accordingly.
I read this and start to give you the same reply as v1. Then I remember
saying this already...
Update the commit message such that it answers my question and I don't
think you just ignored me and have to go find v1. The fact that this
change makes the binding match what is already in use in dts files is an
important detail.
>
> Fixes: 5278e4a181ff ("dt-bindings: memory: add binding for Mediatek's MT7621 SDRAM memory controller")
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> .../bindings/memory-controllers/mediatek,mt7621-memc.yaml | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,mt7621-memc.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,mt7621-memc.yaml
> index 85e02854f083..ba8cd6d81d08 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,mt7621-memc.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,mt7621-memc.yaml
> @@ -11,7 +11,9 @@ maintainers:
>
> properties:
> compatible:
> - const: mediatek,mt7621-memc
> + items:
> + - const: mediatek,mt7621-memc
> + - const: syscon
>
> reg:
> maxItems: 1
> @@ -24,7 +26,7 @@ additionalProperties: false
>
> examples:
> - |
> - memory-controller@5000 {
> - compatible = "mediatek,mt7621-memc";
> + syscon@5000 {
> + compatible = "mediatek,mt7621-memc", "syscon";
> reg = <0x5000 0x1000>;
> };
> --
> 2.34.1
>
>