[PATCH] m68k: fix the comments of via_rtc_send

Deming Wang posted 1 patch 3 years, 6 months ago
arch/m68k/mac/misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] m68k: fix the comments of via_rtc_send
Posted by Deming Wang 3 years, 6 months ago
remove the double word of 'in'.

Signed-off-by: Deming Wang <wangdeming@inspur.com>
---
 arch/m68k/mac/misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/misc.c
index 4fab34791758..29a4cb46af01 100644
--- a/arch/m68k/mac/misc.c
+++ b/arch/m68k/mac/misc.c
@@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data)
 
 	reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData);
 
-	/* The bits of the byte go in in MSB order */
+	/* The bits of the byte go in MSB order */
 
 	for (i = 0 ; i < 8 ; i++) {
 		bit = data & 0x80? 1 : 0;
-- 
2.27.0
Re: [PATCH] m68k: fix the comments of via_rtc_send
Posted by Michael Schmitz 3 years, 6 months ago
Here we go again ...

In the interest of avoiding further patches of this nature, can we 
please change the comment to read:

'The bits of the byte go into the RTC in MSB order'

That ought to make it abundantly clear the duplicate 'in' isn't. (As 
would have looking at comment in the the function just before 
via_rtc_send() ...)

Cheers,

	Michael

Am 15.09.2022 um 13:47 schrieb Deming Wang:
> remove the double word of 'in'.
>
> Signed-off-by: Deming Wang <wangdeming@inspur.com>
> ---
>  arch/m68k/mac/misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/misc.c
> index 4fab34791758..29a4cb46af01 100644
> --- a/arch/m68k/mac/misc.c
> +++ b/arch/m68k/mac/misc.c
> @@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data)
>
>  	reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData);
>
> -	/* The bits of the byte go in in MSB order */
> +	/* The bits of the byte go in MSB order */
>
>  	for (i = 0 ; i < 8 ; i++) {
>  		bit = data & 0x80? 1 : 0;
>