arch/arm64/boot/dts/mediatek/mt8183.dtsi | 57 ------------------------ 1 file changed, 57 deletions(-)
Thermal zones without trip point are not registered by thermal core.
tzts1 ~ tzts6 zones of mt8183 were intially introduced for test-purpose
only but are not supposed to remain on DT.
Remove the zones above and keep only cpu_thermal.
Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 57 ------------------------
1 file changed, 57 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 9d32871973a2..f65fae8939de 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -1182,63 +1182,6 @@ THERMAL_NO_LIMIT
};
};
};
-
- /* The tzts1 ~ tzts6 don't need to polling */
- /* The tzts1 ~ tzts6 don't need to thermal throttle */
-
- tzts1: tzts1 {
- polling-delay-passive = <0>;
- polling-delay = <0>;
- thermal-sensors = <&thermal 1>;
- sustainable-power = <5000>;
- trips {};
- cooling-maps {};
- };
-
- tzts2: tzts2 {
- polling-delay-passive = <0>;
- polling-delay = <0>;
- thermal-sensors = <&thermal 2>;
- sustainable-power = <5000>;
- trips {};
- cooling-maps {};
- };
-
- tzts3: tzts3 {
- polling-delay-passive = <0>;
- polling-delay = <0>;
- thermal-sensors = <&thermal 3>;
- sustainable-power = <5000>;
- trips {};
- cooling-maps {};
- };
-
- tzts4: tzts4 {
- polling-delay-passive = <0>;
- polling-delay = <0>;
- thermal-sensors = <&thermal 4>;
- sustainable-power = <5000>;
- trips {};
- cooling-maps {};
- };
-
- tzts5: tzts5 {
- polling-delay-passive = <0>;
- polling-delay = <0>;
- thermal-sensors = <&thermal 5>;
- sustainable-power = <5000>;
- trips {};
- cooling-maps {};
- };
-
- tztsABB: tztsABB {
- polling-delay-passive = <0>;
- polling-delay = <0>;
- thermal-sensors = <&thermal 6>;
- sustainable-power = <5000>;
- trips {};
- cooling-maps {};
- };
};
pwm0: pwm@1100e000 {
--
2.37.3
On 14/09/2022 15:13, Amjad Ouled-Ameur wrote:
> Thermal zones without trip point are not registered by thermal core.
>
> tzts1 ~ tzts6 zones of mt8183 were intially introduced for test-purpose
> only but are not supposed to remain on DT.
>
> Remove the zones above and keep only cpu_thermal.
>
My understanding is that this thermal zones exist but are not used. DTS should
describe the HW as it is, so I propose to add
status = "disabled";
to the zones.
Regards,
Matthias
> Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 57 ------------------------
> 1 file changed, 57 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 9d32871973a2..f65fae8939de 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1182,63 +1182,6 @@ THERMAL_NO_LIMIT
> };
> };
> };
> -
> - /* The tzts1 ~ tzts6 don't need to polling */
> - /* The tzts1 ~ tzts6 don't need to thermal throttle */
> -
> - tzts1: tzts1 {
> - polling-delay-passive = <0>;
> - polling-delay = <0>;
> - thermal-sensors = <&thermal 1>;
> - sustainable-power = <5000>;
> - trips {};
> - cooling-maps {};
> - };
> -
> - tzts2: tzts2 {
> - polling-delay-passive = <0>;
> - polling-delay = <0>;
> - thermal-sensors = <&thermal 2>;
> - sustainable-power = <5000>;
> - trips {};
> - cooling-maps {};
> - };
> -
> - tzts3: tzts3 {
> - polling-delay-passive = <0>;
> - polling-delay = <0>;
> - thermal-sensors = <&thermal 3>;
> - sustainable-power = <5000>;
> - trips {};
> - cooling-maps {};
> - };
> -
> - tzts4: tzts4 {
> - polling-delay-passive = <0>;
> - polling-delay = <0>;
> - thermal-sensors = <&thermal 4>;
> - sustainable-power = <5000>;
> - trips {};
> - cooling-maps {};
> - };
> -
> - tzts5: tzts5 {
> - polling-delay-passive = <0>;
> - polling-delay = <0>;
> - thermal-sensors = <&thermal 5>;
> - sustainable-power = <5000>;
> - trips {};
> - cooling-maps {};
> - };
> -
> - tztsABB: tztsABB {
> - polling-delay-passive = <0>;
> - polling-delay = <0>;
> - thermal-sensors = <&thermal 6>;
> - sustainable-power = <5000>;
> - trips {};
> - cooling-maps {};
> - };
> };
>
> pwm0: pwm@1100e000 {
Hi Matthias,
Thank you for your review.
On 9/14/22 16:15, Matthias Brugger wrote:
>
>
> On 14/09/2022 15:13, Amjad Ouled-Ameur wrote:
>> Thermal zones without trip point are not registered by thermal core.
>>
>> tzts1 ~ tzts6 zones of mt8183 were intially introduced for test-purpose
>> only but are not supposed to remain on DT.
>>
>> Remove the zones above and keep only cpu_thermal.
>>
>
> My understanding is that this thermal zones exist but are not used.
> DTS should describe the HW as it is, so I propose to add
> status = "disabled";
> to the zones.
>
Correct, they are unused unless for testing purposes. Thus, your
suggestion of disabling them seems more relevant
than removal.
Regards,
Amjad
> Regards,
> Matthias
>
>> Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
>> ---
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 57 ------------------------
>> 1 file changed, 57 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index 9d32871973a2..f65fae8939de 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -1182,63 +1182,6 @@ THERMAL_NO_LIMIT
>> };
>> };
>> };
>> -
>> - /* The tzts1 ~ tzts6 don't need to polling */
>> - /* The tzts1 ~ tzts6 don't need to thermal throttle */
>> -
>> - tzts1: tzts1 {
>> - polling-delay-passive = <0>;
>> - polling-delay = <0>;
>> - thermal-sensors = <&thermal 1>;
>> - sustainable-power = <5000>;
>> - trips {};
>> - cooling-maps {};
>> - };
>> -
>> - tzts2: tzts2 {
>> - polling-delay-passive = <0>;
>> - polling-delay = <0>;
>> - thermal-sensors = <&thermal 2>;
>> - sustainable-power = <5000>;
>> - trips {};
>> - cooling-maps {};
>> - };
>> -
>> - tzts3: tzts3 {
>> - polling-delay-passive = <0>;
>> - polling-delay = <0>;
>> - thermal-sensors = <&thermal 3>;
>> - sustainable-power = <5000>;
>> - trips {};
>> - cooling-maps {};
>> - };
>> -
>> - tzts4: tzts4 {
>> - polling-delay-passive = <0>;
>> - polling-delay = <0>;
>> - thermal-sensors = <&thermal 4>;
>> - sustainable-power = <5000>;
>> - trips {};
>> - cooling-maps {};
>> - };
>> -
>> - tzts5: tzts5 {
>> - polling-delay-passive = <0>;
>> - polling-delay = <0>;
>> - thermal-sensors = <&thermal 5>;
>> - sustainable-power = <5000>;
>> - trips {};
>> - cooling-maps {};
>> - };
>> -
>> - tztsABB: tztsABB {
>> - polling-delay-passive = <0>;
>> - polling-delay = <0>;
>> - thermal-sensors = <&thermal 6>;
>> - sustainable-power = <5000>;
>> - trips {};
>> - cooling-maps {};
>> - };
>> };
>> pwm0: pwm@1100e000 {
On 14/09/2022 16:15, Matthias Brugger wrote: > > > On 14/09/2022 15:13, Amjad Ouled-Ameur wrote: >> Thermal zones without trip point are not registered by thermal core. >> >> tzts1 ~ tzts6 zones of mt8183 were intially introduced for test-purpose >> only but are not supposed to remain on DT. >> >> Remove the zones above and keep only cpu_thermal. >> > > My understanding is that this thermal zones exist but are not used. DTS > should describe the HW as it is, so I propose to add > status = "disabled"; > to the zones. > At least the trip points must be declared as stated in the bindings https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/thermal/thermal-zones.yaml#n213 -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Hi, On 9/15/22 17:50, Daniel Lezcano wrote: > On 14/09/2022 16:15, Matthias Brugger wrote: >> >> >> On 14/09/2022 15:13, Amjad Ouled-Ameur wrote: >>> Thermal zones without trip point are not registered by thermal core. >>> >>> tzts1 ~ tzts6 zones of mt8183 were intially introduced for test-purpose >>> only but are not supposed to remain on DT. >>> >>> Remove the zones above and keep only cpu_thermal. >>> >> >> My understanding is that this thermal zones exist but are not used. >> DTS should describe the HW as it is, so I propose to add >> status = "disabled"; >> to the zones. >> > > At least the trip points must be declared as stated in the bindings > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/thermal/thermal-zones.yaml#n213 > > In the base case we should but there are no trip points for these sensors according to MediaTek. Regards, Amjad
© 2016 - 2024 Red Hat, Inc.