1. Patchew
  2. linux
  3. View series

[PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes

Alexandre Torgue posted 1 patch 3 years, 3 months ago
[PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes
Posted by Alexandre Torgue 3 years, 3 months ago 
Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to
fix dtb validation.

Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>

diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
index d35dcc4f0242..92582cccbb1b 100644
--- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
@@ -65,6 +65,10 @@ patternProperties:
       '#gpio-cells':
         const: 2
 
+      interrupt-controller: true
+      '#interrupt-cells':
+        const: 2
+
       reg:
         maxItems: 1
       clocks:
@@ -80,6 +84,8 @@ patternProperties:
         minimum: 1
         maximum: 16
 
+      gpio-line-names: true
+
       st,bank-name:
         description:
           Should be a name string for this bank as specified in the datasheet.
-- 
2.17.1
Re: [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes
Posted by Krzysztof Kozlowski 3 years, 2 months ago 
On 13/09/2022 09:46, Alexandre Torgue wrote:
> Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to
> fix dtb validation.

Rebase your patch on recent Linux kernel and use get_maintainers.pl.

> 
> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> index d35dcc4f0242..92582cccbb1b 100644
> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> @@ -65,6 +65,10 @@ patternProperties:
>        '#gpio-cells':
>          const: 2
>  
> +      interrupt-controller: true
> +      '#interrupt-cells':
> +        const: 2
> +
>        reg:
>          maxItems: 1
>        clocks:
> @@ -80,6 +84,8 @@ patternProperties:
>          minimum: 1
>          maximum: 16
>  
> +      gpio-line-names: true

maxItems?


Best regards,
Krzysztof
Re: [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes
Posted by Alexandre TORGUE 3 years, 2 months ago 
Hi Krzysztof

On 9/19/22 13:32, Krzysztof Kozlowski wrote:
> On 13/09/2022 09:46, Alexandre Torgue wrote:
>> Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to
>> fix dtb validation.
> 
> Rebase your patch on recent Linux kernel and use get_maintainers.pl.

I did it on 6.0-rc5 but yes I used your kernel.org address instead of 
linaro ones. Sorry.

> 
>>
>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>> index d35dcc4f0242..92582cccbb1b 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>> @@ -65,6 +65,10 @@ patternProperties:
>>         '#gpio-cells':
>>           const: 2
>>   
>> +      interrupt-controller: true
>> +      '#interrupt-cells':
>> +        const: 2
>> +
>>         reg:
>>           maxItems: 1
>>         clocks:
>> @@ -80,6 +84,8 @@ patternProperties:
>>           minimum: 1
>>           maximum: 16
>>   
>> +      gpio-line-names: true
> 
> maxItems?

Generic question, Is it mandatory to add maxItems information for all 
entries ?

For sure I'll send a v2 with it.

Alex

> 
> 
> Best regards,
> Krzysztof
Re: [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes
Posted by Krzysztof Kozlowski 3 years, 2 months ago 
On 23/09/2022 10:29, Alexandre TORGUE wrote:
> Hi Krzysztof
> 
> On 9/19/22 13:32, Krzysztof Kozlowski wrote:
>> On 13/09/2022 09:46, Alexandre Torgue wrote:
>>> Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to
>>> fix dtb validation.
>>
>> Rebase your patch on recent Linux kernel and use get_maintainers.pl.
> 
> I did it on 6.0-rc5 but yes I used your kernel.org address instead of 
> linaro ones. Sorry.
> 
>>
>>>
>>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>>
>>> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>>> index d35dcc4f0242..92582cccbb1b 100644
>>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>>> @@ -65,6 +65,10 @@ patternProperties:
>>>         '#gpio-cells':
>>>           const: 2
>>>   
>>> +      interrupt-controller: true
>>> +      '#interrupt-cells':
>>> +        const: 2
>>> +
>>>         reg:
>>>           maxItems: 1
>>>         clocks:
>>> @@ -80,6 +84,8 @@ patternProperties:
>>>           minimum: 1
>>>           maximum: 16
>>>   
>>> +      gpio-line-names: true
>>
>> maxItems?
> 
> Generic question, Is it mandatory to add maxItems information for all 
> entries ?

It's not mandatory for all. For some it is recommended, for some it does
not make sense. Here it's quite easy to add and it will validate the
entry. Any reason not to add it?

Best regards,
Krzysztof
Re: [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes
Posted by Alexandre TORGUE 3 years, 2 months ago 
On 9/23/22 11:21, Krzysztof Kozlowski wrote:
> On 23/09/2022 10:29, Alexandre TORGUE wrote:
>> Hi Krzysztof
>>
>> On 9/19/22 13:32, Krzysztof Kozlowski wrote:
>>> On 13/09/2022 09:46, Alexandre Torgue wrote:
>>>> Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to
>>>> fix dtb validation.
>>>
>>> Rebase your patch on recent Linux kernel and use get_maintainers.pl.
>>
>> I did it on 6.0-rc5 but yes I used your kernel.org address instead of
>> linaro ones. Sorry.
>>
>>>
>>>>
>>>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>>>> index d35dcc4f0242..92582cccbb1b 100644
>>>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>>>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
>>>> @@ -65,6 +65,10 @@ patternProperties:
>>>>          '#gpio-cells':
>>>>            const: 2
>>>>    
>>>> +      interrupt-controller: true
>>>> +      '#interrupt-cells':
>>>> +        const: 2
>>>> +
>>>>          reg:
>>>>            maxItems: 1
>>>>          clocks:
>>>> @@ -80,6 +84,8 @@ patternProperties:
>>>>            minimum: 1
>>>>            maximum: 16
>>>>    
>>>> +      gpio-line-names: true
>>>
>>> maxItems?
>>
>> Generic question, Is it mandatory to add maxItems information for all
>> entries ?
> 
> It's not mandatory for all. For some it is recommended, for some it does
> not make sense. Here it's quite easy to add and it will validate the
> entry. Any reason not to add it?

Ok understood. To be honest, no reasons to not add it.

cheers
alex

> 
> Best regards,
> Krzysztof
>
Re: [PATCH] dt-bindings: pinctrl: stm32: add missing entries for gpio subnodes
Posted by Rob Herring 3 years, 3 months ago 
On Tue, 13 Sep 2022 09:46:39 +0200, Alexandre Torgue wrote:
> Add "interrupt-controller" and gpio-line-names to gpio subnodes in order to
> fix dtb validation.
> 
> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
> 

Acked-by: Rob Herring <robh@kernel.org>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.