[PATCH -next] clk: davinci: cfgchip: Use dev_err_probe() helper

Yang Yingliang posted 1 patch 3 years, 6 months ago
drivers/clk/davinci/da8xx-cfgchip.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH -next] clk: davinci: cfgchip: Use dev_err_probe() helper
Posted by Yang Yingliang 3 years, 6 months ago
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/clk/davinci/da8xx-cfgchip.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/davinci/da8xx-cfgchip.c b/drivers/clk/davinci/da8xx-cfgchip.c
index 77d18276bfe8..4103d605e804 100644
--- a/drivers/clk/davinci/da8xx-cfgchip.c
+++ b/drivers/clk/davinci/da8xx-cfgchip.c
@@ -510,8 +510,7 @@ da8xx_cfgchip_register_usb0_clk48(struct device *dev,
 
 	fck_clk = devm_clk_get(dev, "fck");
 	if (IS_ERR(fck_clk)) {
-		if (PTR_ERR(fck_clk) != -EPROBE_DEFER)
-			dev_err(dev, "Missing fck clock\n");
+		dev_err_probe(dev, PTR_ERR(fck_clk), "Missing fck clock\n");
 		return ERR_CAST(fck_clk);
 	}
 
-- 
2.25.1
Re: [PATCH -next] clk: davinci: cfgchip: Use dev_err_probe() helper
Posted by Stephen Boyd 3 years, 6 months ago
Quoting Yang Yingliang (2022-09-12 20:22:28)
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---

Applied to clk-next
Re: [PATCH -next] clk: davinci: cfgchip: Use dev_err_probe() helper
Posted by David Lechner 3 years, 6 months ago
On 9/12/22 10:22 PM, Yang Yingliang wrote:
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---

Reviewed-by: David Lechner <david@lechnology.com>