speakup/utils: use "!P" instead of "P == 0"

[PATCH linux-next] speakup/utils: use "!P" instead of "P == 0"

Posted by cgel.zte@gmail.com 3 years, 6 months ago

From: Xu Panda <xu.panda@zte.com.cn>

comparing pointer to 0, use !P instead of it.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
---
 drivers/accessibility/speakup/utils.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
index 4bf2ee8ac246..58ca9847637f 100644
--- a/drivers/accessibility/speakup/utils.h
+++ b/drivers/accessibility/speakup/utils.h
@@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
        else
                snprintf(filename, sizeof(filename), "%s", name);
        infile = fopen(filename, "r");
-       if (infile == 0) {
+       if (!infile) {
                fprintf(stderr, "can't open %s\n", filename);
                exit(1);
        }
-- 
2.15.2

Re: [PATCH linux-next] speakup/utils: use "!P" instead of "P == 0"

Posted by Samuel Thibault 3 years, 6 months ago

cgel.zte@gmail.com, le lun. 12 sept. 2022 10:21:00 +0000, a ecrit:
> From: Xu Panda <xu.panda@zte.com.cn>
> 
> comparing pointer to 0, use !P instead of it.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  drivers/accessibility/speakup/utils.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4bf2ee8ac246..58ca9847637f 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
>         else
>                 snprintf(filename, sizeof(filename), "%s", name);
>         infile = fopen(filename, "r");
> -       if (infile == 0) {
> +       if (!infile) {
>                 fprintf(stderr, "can't open %s\n", filename);
>                 exit(1);
>         }
> -- 
> 2.15.2
>