[PATCH] ia64: export memory_add_physaddr_to_nid to fix cxl build error

Randy Dunlap posted 1 patch 3 years, 6 months ago
arch/ia64/mm/numa.c |    1 +
1 file changed, 1 insertion(+)
[PATCH] ia64: export memory_add_physaddr_to_nid to fix cxl build error
Posted by Randy Dunlap 3 years, 6 months ago
cxl_pmem.ko uses memory_add_physaddr_to_nid() but ia64 does not export it,
so this causes a build error:

ERROR: modpost: "memory_add_physaddr_to_nid" [drivers/cxl/cxl_pmem.ko] undefined!

Fix this by exporting that function.

Fixes: 8c2676a5870a ("hot-add-mem x86_64: memory_add_physaddr_to_nid node fixup")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Ben Widawsky <bwidawsk@kernel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: linux-ia64@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Keith Mannthey <kmannth@us.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
Arnd, can you take this in your one-off fixes arch tree, or would
you prefer for Andrew to take it?

 arch/ia64/mm/numa.c |    1 +
 1 file changed, 1 insertion(+)

--- a/arch/ia64/mm/numa.c
+++ b/arch/ia64/mm/numa.c
@@ -75,5 +75,6 @@ int memory_add_physaddr_to_nid(u64 addr)
 		return 0;
 	return nid;
 }
+EXPORT_SYMBOL(memory_add_physaddr_to_nid);
 #endif
 #endif
Re: [PATCH] ia64: export memory_add_physaddr_to_nid to fix cxl build error
Posted by Arnd Bergmann 3 years, 6 months ago
On Sun, Sep 11, 2022, at 3:26 AM, Randy Dunlap wrote:
> cxl_pmem.ko uses memory_add_physaddr_to_nid() but ia64 does not export it,
> so this causes a build error:
>
> ERROR: modpost: "memory_add_physaddr_to_nid" [drivers/cxl/cxl_pmem.ko] 
> undefined!
>
> Fix this by exporting that function.
>
> Fixes: 8c2676a5870a ("hot-add-mem x86_64: memory_add_physaddr_to_nid 
> node fixup")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Ben Widawsky <bwidawsk@kernel.org>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: linux-ia64@vger.kernel.org
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Keith Mannthey <kmannth@us.ibm.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> Arnd, can you take this in your one-off fixes arch tree, or would
> you prefer for Andrew to take it?

I've applied it to the asm-generic tree for 6.1 now, as I don't
expect any other bugfixes for 6.0 to go through that tree. It's
clearly a bugfix, but since the original commit you cite was from
2006, I assume it can wait a little longer.

     Arnd