[patch RFC 04/29] printk: Remove bogus comment vs. boot consoles

Thomas Gleixner posted 29 patches 3 years, 6 months ago
[patch RFC 04/29] printk: Remove bogus comment vs. boot consoles
Posted by Thomas Gleixner 3 years, 6 months ago
The comment about unregistering boot consoles is just not matching the
reality. Remove it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/printk/printk.c |    3 ---
 1 file changed, 3 deletions(-)

--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -3213,9 +3213,6 @@ void register_console(struct console *ne
 	if (bootcon_enabled &&
 	    ((newcon->flags & (CON_CONSDEV | CON_BOOT)) == CON_CONSDEV) &&
 	    !keep_bootcon) {
-		/* We need to iterate through all boot consoles, to make
-		 * sure we print everything out, before we unregister them.
-		 */
 		for_each_console(con)
 			if (con->flags & CON_BOOT)
 				unregister_console(con);
Re: [patch RFC 04/29] printk: Remove bogus comment vs. boot consoles
Posted by Sergey Senozhatsky 3 years, 6 months ago
On (22/09/11 00:27), Thomas Gleixner wrote:
> Date: Sun, 11 Sep 2022 00:27:38 +0200 (CEST)
> From: Thomas Gleixner <tglx@linutronix.de>
> To: LKML <linux-kernel@vger.kernel.org>
> Cc: John Ogness <john.ogness@linutronix.de>, Petr Mladek
>  <pmladek@suse.com>, Sergey Senozhatsky <senozhatsky@chromium.org>, Steven
>  Rostedt <rostedt@goodmis.org>, Linus Torvalds
>  <torvalds@linuxfoundation.org>, Peter Zijlstra <peterz@infradead.org>,
>  "Paul E. McKenney" <paulmck@kernel.org>, Daniel Vetter <daniel@ffwll.ch>,
>  Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Helge Deller
>  <deller@gmx.de>, Jason Wessel <jason.wessel@windriver.com>, Daniel
>  Thompson <daniel.thompson@linaro.org>
> Subject: [patch RFC 04/29] printk: Remove bogus comment vs. boot consoles
> Message-ID: <20220910222300.582492276@linutronix.de>
> 
> The comment about unregistering boot consoles is just not matching the
> reality. Remove it.

Hmm, yeah, we ~CON_ENABLED console that we unregister before we console_unlock().

> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>