[PATCH 07/16] mm: remove obsolete pgdat_is_empty()

Miaohe Lin posted 16 patches 3 years, 6 months ago
There is a newer version of this series
[PATCH 07/16] mm: remove obsolete pgdat_is_empty()
Posted by Miaohe Lin 3 years, 6 months ago
There's no caller. Remove it.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 include/linux/mmzone.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 6950179a20a2..ab17a0e6f26f 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -1247,11 +1247,6 @@ static inline unsigned long pgdat_end_pfn(pg_data_t *pgdat)
 	return pgdat->node_start_pfn + pgdat->node_spanned_pages;
 }
 
-static inline bool pgdat_is_empty(pg_data_t *pgdat)
-{
-	return !pgdat->node_start_pfn && !pgdat->node_spanned_pages;
-}
-
 #include <linux/memory_hotplug.h>
 
 void build_all_zonelists(pg_data_t *pgdat);
-- 
2.23.0
Re: [PATCH 07/16] mm: remove obsolete pgdat_is_empty()
Posted by David Hildenbrand 3 years, 6 months ago
On 09.09.22 11:24, Miaohe Lin wrote:
> There's no caller. Remove it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>   include/linux/mmzone.h | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 6950179a20a2..ab17a0e6f26f 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -1247,11 +1247,6 @@ static inline unsigned long pgdat_end_pfn(pg_data_t *pgdat)
>   	return pgdat->node_start_pfn + pgdat->node_spanned_pages;
>   }
>   
> -static inline bool pgdat_is_empty(pg_data_t *pgdat)
> -{
> -	return !pgdat->node_start_pfn && !pgdat->node_spanned_pages;
> -}
> -
>   #include <linux/memory_hotplug.h>
>   
>   void build_all_zonelists(pg_data_t *pgdat);

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb
Re: [PATCH 07/16] mm: remove obsolete pgdat_is_empty()
Posted by Anshuman Khandual 3 years, 6 months ago

On 9/9/22 14:54, Miaohe Lin wrote:
> There's no caller. Remove it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

> ---
>  include/linux/mmzone.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 6950179a20a2..ab17a0e6f26f 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -1247,11 +1247,6 @@ static inline unsigned long pgdat_end_pfn(pg_data_t *pgdat)
>  	return pgdat->node_start_pfn + pgdat->node_spanned_pages;
>  }
>  
> -static inline bool pgdat_is_empty(pg_data_t *pgdat)
> -{
> -	return !pgdat->node_start_pfn && !pgdat->node_spanned_pages;
> -}
> -
>  #include <linux/memory_hotplug.h>
>  
>  void build_all_zonelists(pg_data_t *pgdat);
Re: [PATCH 07/16] mm: remove obsolete pgdat_is_empty()
Posted by Oscar Salvador 3 years, 6 months ago
On Fri, Sep 09, 2022 at 05:24:42PM +0800, Miaohe Lin wrote:
> There's no caller. Remove it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Reviewed-by: Oscar Salvador <osalvador@suse.de>

 

-- 
Oscar Salvador
SUSE Labs