fsnotify: remove unused declaration

[PATCH] fsnotify: remove unused declaration

Posted by Gaosheng Cui 3 years, 6 months ago

fsnotify_alloc_event_holder() and fsnotify_destroy_event_holder()
has been removed since commit 7053aee26a35 ("fsnotify: do not share
events between notification groups"), so remove it.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 fs/notify/fsnotify.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/notify/fsnotify.h b/fs/notify/fsnotify.h
index 87d8a50ee803..fde74eb333cc 100644
--- a/fs/notify/fsnotify.h
+++ b/fs/notify/fsnotify.h
@@ -76,10 +76,6 @@ static inline void fsnotify_clear_marks_by_sb(struct super_block *sb)
  */
 extern void __fsnotify_update_child_dentry_flags(struct inode *inode);
 
-/* allocate and destroy and event holder to attach events to notification/access queues */
-extern struct fsnotify_event_holder *fsnotify_alloc_event_holder(void);
-extern void fsnotify_destroy_event_holder(struct fsnotify_event_holder *holder);
-
 extern struct kmem_cache *fsnotify_mark_connector_cachep;
 
 #endif	/* __FS_NOTIFY_FSNOTIFY_H_ */
-- 
2.25.1

Re: [PATCH] fsnotify: remove unused declaration

Posted by Ritesh Harjani (IBM) 3 years, 6 months ago

On 22/09/09 11:38AM, Gaosheng Cui wrote:
> fsnotify_alloc_event_holder() and fsnotify_destroy_event_holder()
> has been removed since commit 7053aee26a35 ("fsnotify: do not share
> events between notification groups"), so remove it.

It's a 2014 commit. Nice spotting. 
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  fs/notify/fsnotify.h | 4 ----
>  1 file changed, 4 deletions(-)


> 
> diff --git a/fs/notify/fsnotify.h b/fs/notify/fsnotify.h
> index 87d8a50ee803..fde74eb333cc 100644
> --- a/fs/notify/fsnotify.h
> +++ b/fs/notify/fsnotify.h
> @@ -76,10 +76,6 @@ static inline void fsnotify_clear_marks_by_sb(struct super_block *sb)
>   */
>  extern void __fsnotify_update_child_dentry_flags(struct inode *inode);
>  
> -/* allocate and destroy and event holder to attach events to notification/access queues */
> -extern struct fsnotify_event_holder *fsnotify_alloc_event_holder(void);
> -extern void fsnotify_destroy_event_holder(struct fsnotify_event_holder *holder);
> -
>  extern struct kmem_cache *fsnotify_mark_connector_cachep;
>  
>  #endif	/* __FS_NOTIFY_FSNOTIFY_H_ */
> -- 
> 2.25.1
>

Re: [PATCH] fsnotify: remove unused declaration

Posted by Jan Kara 3 years, 6 months ago

On Fri 09-09-22 11:38:28, Gaosheng Cui wrote:
> fsnotify_alloc_event_holder() and fsnotify_destroy_event_holder()
> has been removed since commit 7053aee26a35 ("fsnotify: do not share
> events between notification groups"), so remove it.
> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>

Thanks! I've added the patch to my tree.

								Honza

> ---
>  fs/notify/fsnotify.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/notify/fsnotify.h b/fs/notify/fsnotify.h
> index 87d8a50ee803..fde74eb333cc 100644
> --- a/fs/notify/fsnotify.h
> +++ b/fs/notify/fsnotify.h
> @@ -76,10 +76,6 @@ static inline void fsnotify_clear_marks_by_sb(struct super_block *sb)
>   */
>  extern void __fsnotify_update_child_dentry_flags(struct inode *inode);
>  
> -/* allocate and destroy and event holder to attach events to notification/access queues */
> -extern struct fsnotify_event_holder *fsnotify_alloc_event_holder(void);
> -extern void fsnotify_destroy_event_holder(struct fsnotify_event_holder *holder);
> -
>  extern struct kmem_cache *fsnotify_mark_connector_cachep;
>  
>  #endif	/* __FS_NOTIFY_FSNOTIFY_H_ */
> -- 
> 2.25.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR