[PATCH] ipc: mqueue: remove unnecessary conditionals

Jingyu Wang posted 1 patch 3 years, 6 months ago
ipc/mqueue.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH] ipc: mqueue: remove unnecessary conditionals
Posted by Jingyu Wang 3 years, 6 months ago
iput() has already handled null and non-null parameter, so it is no
need to use if().

Signed-off-by: Jingyu Wang <jingyuwang_vip@163.com>
---
 ipc/mqueue.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ipc/mqueue.c b/ipc/mqueue.c
index 9cf314b3f079..467a194b8a2e 100644
--- a/ipc/mqueue.c
+++ b/ipc/mqueue.c
@@ -986,8 +986,7 @@ SYSCALL_DEFINE1(mq_unlink, const char __user *, u_name)
 
 out_unlock:
 	inode_unlock(d_inode(mnt->mnt_root));
-	if (inode)
-		iput(inode);
+	iput(inode);
 	mnt_drop_write(mnt);
 out_name:
 	putname(name);

base-commit: 5957ac6635a1a12d4aa2661bbf04d3085a73372a
-- 
2.34.1
Re: [PATCH] ipc: mqueue: remove unnecessary conditionals
Posted by Roman Gushchin 3 years, 6 months ago
On Fri, Sep 09, 2022 at 02:54:52AM +0800, Jingyu Wang wrote:
> iput() has already handled null and non-null parameter, so it is no
> need to use if().
> 
> Signed-off-by: Jingyu Wang <jingyuwang_vip@163.com>

Acked-by: Roman Gushchin <roman.gushchin@linux.dev>

Thanks!