[v3] Enable initial support for StarFive VisionFive V1 SBC

[PATCH v3 0/3] Enable initial support for StarFive VisionFive V1 SBC

Posted by Cristian Ciocaltea 3 years, 6 months ago

The StarFive VisionFive V1 SBC [1] is similar with the already supported
BeagleV Starlight Beta board, both being based on the StarFive JH7100 SoC.

In addition to documenting the necessary compatibles, this patch series 
moves most of the content from jh7100-beaglev-starlight.dts to a new file
jh7100-common.dtsi, to be shared between the two boards.

No other changes are required in order to successfully boot the board.

[1] https://github.com/starfive-tech/VisionFive

Changes in v3:
 - Added Reviewed-by tag from Krzysztof in patch 1/3
 - Optimized patch 2/3 by enabling copy detection on "git format-patch",
   as indicated by Krzysztof

Changes in v2:
 - Simplified documentation by using 'enum' instead of 'const' in 
   patch 1/3, according to Conor's review
 - Added Reviewed-by tags from Conor

Cristian Ciocaltea (3):
  dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
  riscv: dts: starfive: Add common DT for JH7100 based boards
  riscv: dts: starfive: Add StarFive VisionFive V1 device tree

 .../devicetree/bindings/riscv/starfive.yaml   |   4 +-
 arch/riscv/boot/dts/starfive/Makefile         |   2 +-
 .../dts/starfive/jh7100-beaglev-starlight.dts | 153 +-----------------
 ...aglev-starlight.dts => jh7100-common.dtsi} |   3 -
 .../jh7100-starfive-visionfive-v1.dts         |  20 +++
 5 files changed, 25 insertions(+), 157 deletions(-)
 copy arch/riscv/boot/dts/starfive/{jh7100-beaglev-starlight.dts => jh7100-common.dtsi} (96%)
 create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts

-- 
2.37.3

Re: [PATCH v3 0/3] Enable initial support for StarFive VisionFive V1 SBC

Posted by Cristian Ciocaltea 3 years, 6 months ago

Please let me know if there is anything else missing in order to get 
this queued for merging.

Thanks,
Cristian

On 9/8/22 17:29, Cristian Ciocaltea wrote:
> The StarFive VisionFive V1 SBC [1] is similar with the already supported
> BeagleV Starlight Beta board, both being based on the StarFive JH7100 SoC.
> 
> In addition to documenting the necessary compatibles, this patch series
> moves most of the content from jh7100-beaglev-starlight.dts to a new file
> jh7100-common.dtsi, to be shared between the two boards.
> 
> No other changes are required in order to successfully boot the board.
> 
> [1] https://github.com/starfive-tech/VisionFive
> 
> Changes in v3:
>   - Added Reviewed-by tag from Krzysztof in patch 1/3
>   - Optimized patch 2/3 by enabling copy detection on "git format-patch",
>     as indicated by Krzysztof
> 
> Changes in v2:
>   - Simplified documentation by using 'enum' instead of 'const' in
>     patch 1/3, according to Conor's review
>   - Added Reviewed-by tags from Conor
> 
> Cristian Ciocaltea (3):
>    dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
>    riscv: dts: starfive: Add common DT for JH7100 based boards
>    riscv: dts: starfive: Add StarFive VisionFive V1 device tree
> 
>   .../devicetree/bindings/riscv/starfive.yaml   |   4 +-
>   arch/riscv/boot/dts/starfive/Makefile         |   2 +-
>   .../dts/starfive/jh7100-beaglev-starlight.dts | 153 +-----------------
>   ...aglev-starlight.dts => jh7100-common.dtsi} |   3 -
>   .../jh7100-starfive-visionfive-v1.dts         |  20 +++
>   5 files changed, 25 insertions(+), 157 deletions(-)
>   copy arch/riscv/boot/dts/starfive/{jh7100-beaglev-starlight.dts => jh7100-common.dtsi} (96%)
>   create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
>

Re: [PATCH v3 0/3] Enable initial support for StarFive VisionFive V1 SBC

Posted by Conor Dooley 3 years, 6 months ago

On Mon, Oct 03, 2022 at 02:06:32PM +0300, Cristian Ciocaltea wrote:
> Please let me know if there is anything else missing in order to get this
> queued for merging.

Hey Cristian,

LinusW has applied a conflicting change for 6.1 as he renamed the
pinctrl header that you have moved from one file to another in this
patch [0]. Could you rebase once that lands upstream please?

Thanks,
Conor.

0 - https://lore.kernel.org/linux-riscv/CACRpkdZmmMjVwpHxkJP+Ui0XJgrdZx8kpVybifbwkRB1_uMhAg@mail.gmail.com/

> 
> Thanks,
> Cristian
> 
> On 9/8/22 17:29, Cristian Ciocaltea wrote:
> > The StarFive VisionFive V1 SBC [1] is similar with the already supported
> > BeagleV Starlight Beta board, both being based on the StarFive JH7100 SoC.
> > 
> > In addition to documenting the necessary compatibles, this patch series
> > moves most of the content from jh7100-beaglev-starlight.dts to a new file
> > jh7100-common.dtsi, to be shared between the two boards.
> > 
> > No other changes are required in order to successfully boot the board.
> > 
> > [1] https://github.com/starfive-tech/VisionFive
> > 
> > Changes in v3:
> >   - Added Reviewed-by tag from Krzysztof in patch 1/3
> >   - Optimized patch 2/3 by enabling copy detection on "git format-patch",
> >     as indicated by Krzysztof
> > 
> > Changes in v2:
> >   - Simplified documentation by using 'enum' instead of 'const' in
> >     patch 1/3, according to Conor's review
> >   - Added Reviewed-by tags from Conor
> > 
> > Cristian Ciocaltea (3):
> >    dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
> >    riscv: dts: starfive: Add common DT for JH7100 based boards
> >    riscv: dts: starfive: Add StarFive VisionFive V1 device tree
> > 
> >   .../devicetree/bindings/riscv/starfive.yaml   |   4 +-
> >   arch/riscv/boot/dts/starfive/Makefile         |   2 +-
> >   .../dts/starfive/jh7100-beaglev-starlight.dts | 153 +-----------------
> >   ...aglev-starlight.dts => jh7100-common.dtsi} |   3 -
> >   .../jh7100-starfive-visionfive-v1.dts         |  20 +++
> >   5 files changed, 25 insertions(+), 157 deletions(-)
> >   copy arch/riscv/boot/dts/starfive/{jh7100-beaglev-starlight.dts => jh7100-common.dtsi} (96%)
> >   create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
> > 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
>

Re: [PATCH v3 0/3] Enable initial support for StarFive VisionFive V1 SBC

Posted by Cristian Ciocaltea 3 years, 6 months ago

On 10/4/22 12:52, Conor Dooley wrote:
> On Mon, Oct 03, 2022 at 02:06:32PM +0300, Cristian Ciocaltea wrote:
>> Please let me know if there is anything else missing in order to get this
>> queued for merging.
> 
> Hey Cristian,
> 
> LinusW has applied a conflicting change for 6.1 as he renamed the
> pinctrl header that you have moved from one file to another in this
> patch [0]. Could you rebase once that lands upstream please?

Hi Conor,

Sure, I will rebase as soon as rc1 is out.

Thanks,
Cristian

> 
> Thanks,
> Conor.
> 
> 0 - https://lore.kernel.org/linux-riscv/CACRpkdZmmMjVwpHxkJP+Ui0XJgrdZx8kpVybifbwkRB1_uMhAg@mail.gmail.com/
> 
>>
>> Thanks,
>> Cristian
>>
>> On 9/8/22 17:29, Cristian Ciocaltea wrote:
>>> The StarFive VisionFive V1 SBC [1] is similar with the already supported
>>> BeagleV Starlight Beta board, both being based on the StarFive JH7100 SoC.
>>>
>>> In addition to documenting the necessary compatibles, this patch series
>>> moves most of the content from jh7100-beaglev-starlight.dts to a new file
>>> jh7100-common.dtsi, to be shared between the two boards.
>>>
>>> No other changes are required in order to successfully boot the board.
>>>
>>> [1] https://github.com/starfive-tech/VisionFive
>>>
>>> Changes in v3:
>>>    - Added Reviewed-by tag from Krzysztof in patch 1/3
>>>    - Optimized patch 2/3 by enabling copy detection on "git format-patch",
>>>      as indicated by Krzysztof
>>>
>>> Changes in v2:
>>>    - Simplified documentation by using 'enum' instead of 'const' in
>>>      patch 1/3, according to Conor's review
>>>    - Added Reviewed-by tags from Conor
>>>
>>> Cristian Ciocaltea (3):
>>>     dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
>>>     riscv: dts: starfive: Add common DT for JH7100 based boards
>>>     riscv: dts: starfive: Add StarFive VisionFive V1 device tree
>>>
>>>    .../devicetree/bindings/riscv/starfive.yaml   |   4 +-
>>>    arch/riscv/boot/dts/starfive/Makefile         |   2 +-
>>>    .../dts/starfive/jh7100-beaglev-starlight.dts | 153 +-----------------
>>>    ...aglev-starlight.dts => jh7100-common.dtsi} |   3 -
>>>    .../jh7100-starfive-visionfive-v1.dts         |  20 +++
>>>    5 files changed, 25 insertions(+), 157 deletions(-)
>>>    copy arch/riscv/boot/dts/starfive/{jh7100-beaglev-starlight.dts => jh7100-common.dtsi} (96%)
>>>    create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
>>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
>>

Re: [PATCH v3 0/3] Enable initial support for StarFive VisionFive V1 SBC

Posted by Cristian Ciocaltea 3 years, 5 months ago

On 10/4/22 13:15, Cristian Ciocaltea wrote:
> On 10/4/22 12:52, Conor Dooley wrote:
>> On Mon, Oct 03, 2022 at 02:06:32PM +0300, Cristian Ciocaltea wrote:
>>> Please let me know if there is anything else missing in order to get 
>>> this
>>> queued for merging.
>>
>> Hey Cristian,
>>
>> LinusW has applied a conflicting change for 6.1 as he renamed the
>> pinctrl header that you have moved from one file to another in this
>> patch [0]. Could you rebase once that lands upstream please?
> 
> Hi Conor,
> 
> Sure, I will rebase as soon as rc1 is out.

I have submitted v4:

https://lore.kernel.org/all/20221017210542.979051-1-cristian.ciocaltea@collabora.com/

> Thanks,
> Cristian
> 
>>
>> Thanks,
>> Conor.
>>
>> 0 - 
>> https://lore.kernel.org/linux-riscv/CACRpkdZmmMjVwpHxkJP+Ui0XJgrdZx8kpVybifbwkRB1_uMhAg@mail.gmail.com/
>>
>>>
>>> Thanks,
>>> Cristian
>>>
>>> On 9/8/22 17:29, Cristian Ciocaltea wrote:
>>>> The StarFive VisionFive V1 SBC [1] is similar with the already 
>>>> supported
>>>> BeagleV Starlight Beta board, both being based on the StarFive 
>>>> JH7100 SoC.
>>>>
>>>> In addition to documenting the necessary compatibles, this patch series
>>>> moves most of the content from jh7100-beaglev-starlight.dts to a new 
>>>> file
>>>> jh7100-common.dtsi, to be shared between the two boards.
>>>>
>>>> No other changes are required in order to successfully boot the board.
>>>>
>>>> [1] https://github.com/starfive-tech/VisionFive
>>>>
>>>> Changes in v3:
>>>>    - Added Reviewed-by tag from Krzysztof in patch 1/3
>>>>    - Optimized patch 2/3 by enabling copy detection on "git 
>>>> format-patch",
>>>>      as indicated by Krzysztof
>>>>
>>>> Changes in v2:
>>>>    - Simplified documentation by using 'enum' instead of 'const' in
>>>>      patch 1/3, according to Conor's review
>>>>    - Added Reviewed-by tags from Conor
>>>>
>>>> Cristian Ciocaltea (3):
>>>>     dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
>>>>     riscv: dts: starfive: Add common DT for JH7100 based boards
>>>>     riscv: dts: starfive: Add StarFive VisionFive V1 device tree
>>>>
>>>>    .../devicetree/bindings/riscv/starfive.yaml   |   4 +-
>>>>    arch/riscv/boot/dts/starfive/Makefile         |   2 +-
>>>>    .../dts/starfive/jh7100-beaglev-starlight.dts | 153 
>>>> +-----------------
>>>>    ...aglev-starlight.dts => jh7100-common.dtsi} |   3 -
>>>>    .../jh7100-starfive-visionfive-v1.dts         |  20 +++
>>>>    5 files changed, 25 insertions(+), 157 deletions(-)
>>>>    copy arch/riscv/boot/dts/starfive/{jh7100-beaglev-starlight.dts 
>>>> => jh7100-common.dtsi} (96%)
>>>>    create mode 100644 
>>>> arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
>>>>
>>>
>>> _______________________________________________
>>> linux-riscv mailing list
>>> linux-riscv@lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-riscv
>>>