[PATCH v2 0/9] pwm: lpss: Clean up and convert to a pure library

Andy Shevchenko posted 9 patches 3 years, 6 months ago
There is a newer version of this series
drivers/pwm/pwm-lpss-pci.c                 | 48 +++++-----------------
drivers/pwm/pwm-lpss-platform.c            | 40 +++++-------------
drivers/pwm/pwm-lpss.c                     | 46 ++++++++++++++++++---
drivers/pwm/pwm-lpss.h                     | 22 ++++------
include/linux/platform_data/x86/pwm-lpss.h | 33 +++++++++++++++
5 files changed, 101 insertions(+), 88 deletions(-)
create mode 100644 include/linux/platform_data/x86/pwm-lpss.h
[PATCH v2 0/9] pwm: lpss: Clean up and convert to a pure library
Posted by Andy Shevchenko 3 years, 6 months ago
First of all, a set of cleanups and code deduplications (for better
maintenance) to the PWM LPSS driver.

Second, we may (re-)use the core part as a library in the future in
the devices that combine the same PWM IP in their address space. So
convert the core file to be a pure library which doesn't require any
special resource handling or alike.

Changelog v2:
- replace patch 1 by Uwe's version (Uwe)
- update NS patch to have a default namespace defined (Uwe)
- describe all changes done in patch 4 (Uwe)

Andy Shevchenko (8):
  pwm: lpss: Move exported symbols to PWM_LPSS namespace
  pwm: lpss: Move resource mapping to the glue drivers
  pwm: lpss: Include headers we are direct user of
  pwm: lpss: Use device_get_match_data to get device data
  pwm: lpss: Use DEFINE_RUNTIME_DEV_PM_OPS() and pm_ptr() macros
  pwm: lpss: Make use of bits.h macros for all masks
  pwm: lpss: Add a comment to the bypass field
  pwm: lpss: Allow other drivers to enable PWM LPSS

Uwe Kleine-König (1):
  pwm: lpss: Deduplicate board info data structures

 drivers/pwm/pwm-lpss-pci.c                 | 48 +++++-----------------
 drivers/pwm/pwm-lpss-platform.c            | 40 +++++-------------
 drivers/pwm/pwm-lpss.c                     | 46 ++++++++++++++++++---
 drivers/pwm/pwm-lpss.h                     | 22 ++++------
 include/linux/platform_data/x86/pwm-lpss.h | 33 +++++++++++++++
 5 files changed, 101 insertions(+), 88 deletions(-)
 create mode 100644 include/linux/platform_data/x86/pwm-lpss.h

-- 
2.35.1

Re: [PATCH v2 0/9] pwm: lpss: Clean up and convert to a pure library
Posted by Hans de Goede 3 years, 6 months ago
Hi,

On 9/8/22 15:56, Andy Shevchenko wrote:
> First of all, a set of cleanups and code deduplications (for better
> maintenance) to the PWM LPSS driver.
> 
> Second, we may (re-)use the core part as a library in the future in
> the devices that combine the same PWM IP in their address space. So
> convert the core file to be a pure library which doesn't require any
> special resource handling or alike.
> 
> Changelog v2:
> - replace patch 1 by Uwe's version (Uwe)
> - update NS patch to have a default namespace defined (Uwe)
> - describe all changes done in patch 4 (Uwe)
> 
> Andy Shevchenko (8):
>   pwm: lpss: Move exported symbols to PWM_LPSS namespace
>   pwm: lpss: Move resource mapping to the glue drivers
>   pwm: lpss: Include headers we are direct user of
>   pwm: lpss: Use device_get_match_data to get device data
>   pwm: lpss: Use DEFINE_RUNTIME_DEV_PM_OPS() and pm_ptr() macros
>   pwm: lpss: Make use of bits.h macros for all masks
>   pwm: lpss: Add a comment to the bypass field
>   pwm: lpss: Allow other drivers to enable PWM LPSS
> 
> Uwe Kleine-König (1):
>   pwm: lpss: Deduplicate board info data structures
> 
>  drivers/pwm/pwm-lpss-pci.c                 | 48 +++++-----------------
>  drivers/pwm/pwm-lpss-platform.c            | 40 +++++-------------
>  drivers/pwm/pwm-lpss.c                     | 46 ++++++++++++++++++---
>  drivers/pwm/pwm-lpss.h                     | 22 ++++------
>  include/linux/platform_data/x86/pwm-lpss.h | 33 +++++++++++++++
>  5 files changed, 101 insertions(+), 88 deletions(-)
>  create mode 100644 include/linux/platform_data/x86/pwm-lpss.h

Uwe, thank you for Cc-ing me.

Andy, thank you for the patches.

The entire series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans

Re: [PATCH v2 0/9] pwm: lpss: Clean up and convert to a pure library
Posted by Andy Shevchenko 3 years, 6 months ago
On Thu, Sep 08, 2022 at 04:56:49PM +0300, Andy Shevchenko wrote:
> First of all, a set of cleanups and code deduplications (for better
> maintenance) to the PWM LPSS driver.
> 
> Second, we may (re-)use the core part as a library in the future in
> the devices that combine the same PWM IP in their address space. So
> convert the core file to be a pure library which doesn't require any
> special resource handling or alike.

What happened to the PWM subsystem maintenance again?
For weeks there is no reaction from the maintainer(s)... :-(
If there is a lag of maintaining, perhaps we should mark it
as Orphaned?

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v2 0/9] pwm: lpss: Clean up and convert to a pure library
Posted by Uwe Kleine-König 3 years, 6 months ago
Hello,

On Fri, Sep 23, 2022 at 08:03:39PM +0300, Andy Shevchenko wrote:
> On Thu, Sep 08, 2022 at 04:56:49PM +0300, Andy Shevchenko wrote:
> > First of all, a set of cleanups and code deduplications (for better
> > maintenance) to the PWM LPSS driver.
> > 
> > Second, we may (re-)use the core part as a library in the future in
> > the devices that combine the same PWM IP in their address space. So
> > convert the core file to be a pure library which doesn't require any
> > special resource handling or alike.
> 
> What happened to the PWM subsystem maintenance again?
> For weeks there is no reaction from the maintainer(s)... :-(
> If there is a lag of maintaining, perhaps we should mark it
> as Orphaned?

I thought I already acked most of the patches, will take another look.

Up to now it's Thierry who has the last word on things and applies
patches. I'm open to take a more active role.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |