perf: Clean up by adding helpers

[PATCH 0/4] perf: Clean up by adding helpers

Posted by Shang XiaoJing 3 years, 7 months ago

Some clean up in builtin-lock.c, builtin-timechart.c, and
builtin-trace.c.

Shang XiaoJing (4):
  perf trace: Use zalloc to save initialization of syscall_stats
  perf lock: Add get_key_by_aggr_mode helper
  perf timechart: Add create_pidcomm helper
  perf timechart: Add p_state_end helper

 tools/perf/builtin-lock.c      | 129 ++++++++++++++-------------------
 tools/perf/builtin-timechart.c |  65 +++++++++--------
 tools/perf/builtin-trace.c     |   5 +-
 3 files changed, 88 insertions(+), 111 deletions(-)

-- 
2.17.1

Re: [PATCH 0/4] perf: Clean up by adding helpers

Posted by Namhyung Kim 3 years, 7 months ago

Hello,

On Wed, Sep 7, 2022 at 6:37 PM Shang XiaoJing <shangxiaojing@huawei.com> wrote:
>
> Some clean up in builtin-lock.c, builtin-timechart.c, and
> builtin-trace.c.
>
> Shang XiaoJing (4):
>   perf trace: Use zalloc to save initialization of syscall_stats
>   perf lock: Add get_key_by_aggr_mode helper
>   perf timechart: Add create_pidcomm helper
>   perf timechart: Add p_state_end helper

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


>
>  tools/perf/builtin-lock.c      | 129 ++++++++++++++-------------------
>  tools/perf/builtin-timechart.c |  65 +++++++++--------
>  tools/perf/builtin-trace.c     |   5 +-
>  3 files changed, 88 insertions(+), 111 deletions(-)
>
> --
> 2.17.1
>

Re: [PATCH 0/4] perf: Clean up by adding helpers

Posted by Arnaldo Carvalho de Melo 3 years, 6 months ago

Em Thu, Sep 08, 2022 at 12:08:06AM -0700, Namhyung Kim escreveu:
> Hello,
> 
> On Wed, Sep 7, 2022 at 6:37 PM Shang XiaoJing <shangxiaojing@huawei.com> wrote:
> >
> > Some clean up in builtin-lock.c, builtin-timechart.c, and
> > builtin-trace.c.
> >
> > Shang XiaoJing (4):
> >   perf trace: Use zalloc to save initialization of syscall_stats
> >   perf lock: Add get_key_by_aggr_mode helper
> >   perf timechart: Add create_pidcomm helper
> >   perf timechart: Add p_state_end helper
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applied.

- Arnaldo

 
> Thanks,
> Namhyung
> 
> 
> >
> >  tools/perf/builtin-lock.c      | 129 ++++++++++++++-------------------
> >  tools/perf/builtin-timechart.c |  65 +++++++++--------
> >  tools/perf/builtin-trace.c     |   5 +-
> >  3 files changed, 88 insertions(+), 111 deletions(-)
> >
> > --
> > 2.17.1
> >

-- 

- Arnaldo