[PATCH -next] mm/hwpoison: add __init/__exit annotations to module init/exit funcs

Xiu Jianfeng posted 1 patch 3 years, 7 months ago
mm/hwpoison-inject.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH -next] mm/hwpoison: add __init/__exit annotations to module init/exit funcs
Posted by Xiu Jianfeng 3 years, 7 months ago
Add missing __init/__exit annotations to module init/exit funcs.

Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
 mm/hwpoison-inject.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
index 65e242b5a432..d0548e382b6b 100644
--- a/mm/hwpoison-inject.c
+++ b/mm/hwpoison-inject.c
@@ -63,13 +63,13 @@ static int hwpoison_unpoison(void *data, u64 val)
 DEFINE_DEBUGFS_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n");
 DEFINE_DEBUGFS_ATTRIBUTE(unpoison_fops, NULL, hwpoison_unpoison, "%lli\n");
 
-static void pfn_inject_exit(void)
+static void __exit pfn_inject_exit(void)
 {
 	hwpoison_filter_enable = 0;
 	debugfs_remove_recursive(hwpoison_dir);
 }
 
-static int pfn_inject_init(void)
+static int __init pfn_inject_init(void)
 {
 	hwpoison_dir = debugfs_create_dir("hwpoison", NULL);
 
-- 
2.17.1
Re: [PATCH -next] mm/hwpoison: add __init/__exit annotations to module init/exit funcs
Posted by Miaohe Lin 3 years, 7 months ago
On 2022/9/6 17:35, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

LGTM. Thanks.

Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>

Thanks,
Miaohe Lin

> ---
>  mm/hwpoison-inject.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
> index 65e242b5a432..d0548e382b6b 100644
> --- a/mm/hwpoison-inject.c
> +++ b/mm/hwpoison-inject.c
> @@ -63,13 +63,13 @@ static int hwpoison_unpoison(void *data, u64 val)
>  DEFINE_DEBUGFS_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n");
>  DEFINE_DEBUGFS_ATTRIBUTE(unpoison_fops, NULL, hwpoison_unpoison, "%lli\n");
>  
> -static void pfn_inject_exit(void)
> +static void __exit pfn_inject_exit(void)
>  {
>  	hwpoison_filter_enable = 0;
>  	debugfs_remove_recursive(hwpoison_dir);
>  }
>  
> -static int pfn_inject_init(void)
> +static int __init pfn_inject_init(void)
>  {
>  	hwpoison_dir = debugfs_create_dir("hwpoison", NULL);
>  
>
Re: [PATCH -next] mm/hwpoison: add __init/__exit annotations to module init/exit funcs
Posted by HORIGUCHI NAOYA(堀口 直也) 3 years, 7 months ago
On Tue, Sep 06, 2022 at 05:35:30PM +0800, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>

Thank you.
- Naoya Horiguchi