misc: microchip: pci1xxxx: Include depends on PCI & select AUXILIARY_BUS in the Kconfig file to resolve build issues.

[PATCH char-misc-next] misc: microchip: pci1xxxx: Include depends on PCI & select AUXILIARY_BUS in the Kconfig file to resolve build issues.

Posted by Kumaravel Thiagarajan 3 years, 7 months ago

Some build errors were reported by kernel test robot <lkp@intel.com> on
the char-misc-next branch. This add-on patch will fix the errors.

Fixes: 393fc2f5948fd340d016a9557eea6e1ac2f6c60c
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
---
 drivers/misc/mchp_pci1xxxx/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/misc/mchp_pci1xxxx/Kconfig b/drivers/misc/mchp_pci1xxxx/Kconfig
index f6a6970d2a59..0fd0aaa218d5 100644
--- a/drivers/misc/mchp_pci1xxxx/Kconfig
+++ b/drivers/misc/mchp_pci1xxxx/Kconfig
@@ -1,7 +1,9 @@
 config GP_PCI1XXXX
        tristate "Microchip PCI1XXXX PCIe to GPIO Expander + OTP/EEPROM manager"
        depends on PCI	
+       depends on GPIOLIB
        select GPIOLIB_IRQCHIP
+       select AUXILIARY_BUS
        help
          PCI1XXXX is a PCIe GEN 3 switch with one of the endpoints having
          multiple functions and one of the functions is a GPIO controller
-- 
2.25.1

Re: [PATCH char-misc-next] misc: microchip: pci1xxxx: Include depends on PCI & select AUXILIARY_BUS in the Kconfig file to resolve build issues.

Posted by Greg KH 3 years, 7 months ago

Your subject line is way too long :(


On Tue, Sep 06, 2022 at 02:05:55PM +0530, Kumaravel Thiagarajan wrote:
> Some build errors were reported by kernel test robot <lkp@intel.com> on
> the char-misc-next branch. This add-on patch will fix the errors.

You should list the errors here so that we know what they are. 

> 
> Fixes: 393fc2f5948fd340d016a9557eea6e1ac2f6c60c

As per the kernel documentation, this should be:
Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-function endpoint of pci1xxxx device.")

Can you fix this up and send a v2?

thanks,

greg k-h

RE: [PATCH char-misc-next] misc: microchip: pci1xxxx: Include depends on PCI & select AUXILIARY_BUS in the Kconfig file to resolve build issues.

Posted by Kumaravel.Thiagarajan@microchip.com 3 years, 7 months ago

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Tuesday, September 6, 2022 2:19 PM
> To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@microchip.com>
> Cc: linux-kernel@vger.kernel.org; kbuild-all@lists.01.org; lkp@intel.com
> Subject: Re: [PATCH char-misc-next] misc: microchip: pci1xxxx: Include
> depends on PCI & select AUXILIARY_BUS in the Kconfig file to resolve build
> issues.
> 
> 
> Your subject line is way too long :(
I have tried to make it a little shorter.

> 
> 
> On Tue, Sep 06, 2022 at 02:05:55PM +0530, Kumaravel Thiagarajan wrote:
> > Some build errors were reported by kernel test robot <lkp@intel.com>
> > on the char-misc-next branch. This add-on patch will fix the errors.
> 
> You should list the errors here so that we know what they are.
Ok. This is taken care of in v2.

> 
> >
> > Fixes: 393fc2f5948fd340d016a9557eea6e1ac2f6c60c
> 
> As per the kernel documentation, this should be:
> Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus driver for
> the PIO function in the multi-function endpoint of pci1xxxx device.")
Ok. This is taken care of in v2.

> 
> Can you fix this up and send a v2?
I have sent you the v2 but just now noticed that I did not include v1 -> V2 change history. I am really sorry about that.

Thank You.

Regards,
Kumaravel